Skip to content

Switch default memory format of clone operator to Preserve#30089

Closed
VitalyFedyunin wants to merge 8 commits intogh/VitalyFedyunin/89/basefrom
gh/VitalyFedyunin/89/head
Closed

Switch default memory format of clone operator to Preserve#30089
VitalyFedyunin wants to merge 8 commits intogh/VitalyFedyunin/89/basefrom
gh/VitalyFedyunin/89/head

Conversation

@VitalyFedyunin
Copy link
Contributor

@VitalyFedyunin VitalyFedyunin commented Nov 19, 2019

Stack from ghstack:

Differential Revision: D18624985

VitalyFedyunin added a commit that referenced this pull request Nov 20, 2019
VitalyFedyunin added a commit that referenced this pull request Nov 21, 2019
… of clone operator to Preserve"

Differential Revision: [D18624985](https://our.internmc.facebook.com/intern/diff/D18624985)

[ghstack-poisoned]
@kostmo
Copy link
Member

kostmo commented Dec 12, 2019

CircleCI build failures summary

As of commit 26b760b:

  • 1/2 broken upstream at merge base 20a2e52 (see grid view)
    • You may want to rebase on the viable/strict branch (see its recency history):
      • If your commit is newer than viable/strict, you can try basing on an older, stable commit:
        git fetch viable/strict
        git rebase --onto viable/strict $(git merge-base origin/master HEAD)
        
      • If your commit is older than viable/strict:
        git fetch viable/strict
        git rebase viable/strict
        
  • 1/2 failures introduced in this PR

Detailed failure analysis

One may explore the probable reasons each build failed interactively on the Dr. CI website.

1 new failure recognized by patterns

The following build failures don't appear to be due to upstream breakage:

See CircleCI build pytorch_xla_linux_xenial_py3_6_clang7_test (1/1)

Step: "Test" (details)

Dec 13 02:24:25 +++ eval 'extract_trap_cmd ' 
Dec 13 02:24:25 ++++ extract_trap_cmd 
Dec 13 02:24:25 ++++ printf '%s\n' '' 
Dec 13 02:24:25 +++ printf '%s\n' cleanup 
Dec 13 02:24:25 ++ trap -- ' 
Dec 13 02:24:25 cleanup' EXIT 
Dec 13 02:24:25 ++ which sccache 
Dec 13 02:24:25 ++ sccache --stop-server 
Dec 13 02:24:25 Stopping sccache server... 
Dec 13 02:24:25 error: couldn't connect to server 
Dec 13 02:24:25 caused by: Connection refused (os error 111) 
Dec 13 02:24:25 ++ true 
Dec 13 02:24:25 ++ rm /var/lib/jenkins/sccache_error.log 
Dec 13 02:24:25 ++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log 
Dec 13 02:24:25 ++ SCCACHE_IDLE_TIMEOUT=1200 
Dec 13 02:24:25 ++ RUST_LOG=sccache::server=error 
Dec 13 02:24:25 ++ sccache --start-server 
Dec 13 02:24:25 Starting sccache server... 
Dec 13 02:24:25 ++ sccache --zero-stats 
Dec 13 02:24:25 Compile requests                 0 
Dec 13 02:24:25 Compile requests executed        0 

1 failure not recognized by patterns:

Job Step Status
CircleCI pytorch_linux_xenial_cuda9_cudnn7_py3_build Build 🛑 Broken upstream

This comment was automatically generated by Dr. CI.
Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 5 times.

@facebook-github-bot
Copy link
Contributor

@VitalyFedyunin merged this pull request in c35cddb.

@facebook-github-bot facebook-github-bot deleted the gh/VitalyFedyunin/89/head branch December 18, 2019 15:17
@ppwwyyxx
Copy link
Collaborator

This may qualify as a BC-breaking change since we have some code that implicitly assumes the result of some op is contiguous. Might be better to mention it in release notes.

xxtEchjovs44 pushed a commit to xxtEchjovs44/pytorch that referenced this pull request Jan 29, 2020
facebook-github-bot pushed a commit to facebookresearch/detectron2 that referenced this pull request Jan 29, 2020
Summary:
Pytorch changes the behavior of copy_ to preserve memory layout,
in the stack of pytorch/pytorch#30089.

Our kernel needs to adopt to such change.

Reviewed By: rbgirshick

Differential Revision: D19617086

fbshipit-source-id: 992a0e957aa86c48152ffdcea1e9c184b3a47be2
wuhuikx pushed a commit to wuhuikx/pytorch that referenced this pull request Jan 30, 2020
Summary: Pull Request resolved: pytorch#30089

Test Plan: Imported from OSS

Differential Revision: D18624985

Pulled By: VitalyFedyunin

fbshipit-source-id: 8d315b08b7b5858fd0a81d3375b44ccb94787ad4
@VitalyFedyunin VitalyFedyunin added the module: bc-breaking Related to a BC-breaking change label Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged module: bc-breaking Related to a BC-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants