Switch default memory format of clone operator to Preserve#30089
Closed
VitalyFedyunin wants to merge 8 commits intogh/VitalyFedyunin/89/basefrom
Closed
Switch default memory format of clone operator to Preserve#30089VitalyFedyunin wants to merge 8 commits intogh/VitalyFedyunin/89/basefrom
VitalyFedyunin wants to merge 8 commits intogh/VitalyFedyunin/89/basefrom
Conversation
[ghstack-poisoned]
This was referenced Nov 19, 2019
…e operator to Preserve" [ghstack-poisoned]
…Preserve" Differential Revision: [D18624985](https://our.internmc.facebook.com/intern/diff/D18624985) [ghstack-poisoned]
… of clone operator to Preserve" Differential Revision: [D18624985](https://our.internmc.facebook.com/intern/diff/D18624985) [ghstack-poisoned]
…or to Preserve" Differential Revision: [D18624985](https://our.internmc.facebook.com/intern/diff/D18624985) [ghstack-poisoned]
This was referenced Dec 4, 2019
Closed
Closed
Closed
This was referenced Dec 11, 2019
…o Preserve" Differential Revision: [D18624985](https://our.internmc.facebook.com/intern/diff/D18624985) [ghstack-poisoned]
gchanan
approved these changes
Dec 12, 2019
Member
CircleCI build failures summaryAs of commit 26b760b:
Detailed failure analysisOne may explore the probable reasons each build failed interactively on the Dr. CI website. 1 new failure recognized by patternsThe following build failures don't appear to be due to upstream breakage:
|
| Job | Step | Status |
|---|---|---|
| Build | 🛑 Broken upstream |
This comment was automatically generated by Dr. CI.
Follow this link to opt-out of these comments for your Pull Requests.
Please report bugs/suggestions on the GitHub issue tracker.
This comment has been revised 5 times.
…erve" Differential Revision: [D18624985](https://our.internmc.facebook.com/intern/diff/D18624985) [ghstack-poisoned]
This was referenced Dec 13, 2019
…erve" Differential Revision: [D18624985](https://our.internmc.facebook.com/intern/diff/D18624985) [ghstack-poisoned]
Contributor
|
@VitalyFedyunin merged this pull request in c35cddb. |
Collaborator
|
This may qualify as a BC-breaking change since we have some code that implicitly assumes the result of some op is contiguous. Might be better to mention it in release notes. |
xxtEchjovs44
pushed a commit
to xxtEchjovs44/pytorch
that referenced
this pull request
Jan 29, 2020
ghstack-source-id: 48aa081 Pull Request resolved: pytorch/pytorch#30089
facebook-github-bot
pushed a commit
to facebookresearch/detectron2
that referenced
this pull request
Jan 29, 2020
Summary: Pytorch changes the behavior of copy_ to preserve memory layout, in the stack of pytorch/pytorch#30089. Our kernel needs to adopt to such change. Reviewed By: rbgirshick Differential Revision: D19617086 fbshipit-source-id: 992a0e957aa86c48152ffdcea1e9c184b3a47be2
wuhuikx
pushed a commit
to wuhuikx/pytorch
that referenced
this pull request
Jan 30, 2020
Summary: Pull Request resolved: pytorch#30089 Test Plan: Imported from OSS Differential Revision: D18624985 Pulled By: VitalyFedyunin fbshipit-source-id: 8d315b08b7b5858fd0a81d3375b44ccb94787ad4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
.tooperator to preserve strides whenselfshould be returned #31227 Fix.tooperator to preserve strides whenselfshould be returnedzeros,ones,full#31131 Add memory_format support tozeros,ones,full(still need tests)Differential Revision: D18624985