Skip to content

Switch default memory format of _like operators to Preserve#30087

Closed
VitalyFedyunin wants to merge 8 commits intogh/VitalyFedyunin/87/basefrom
gh/VitalyFedyunin/87/head
Closed

Switch default memory format of _like operators to Preserve#30087
VitalyFedyunin wants to merge 8 commits intogh/VitalyFedyunin/87/basefrom
gh/VitalyFedyunin/87/head

Conversation

@VitalyFedyunin
Copy link
Contributor

@VitalyFedyunin VitalyFedyunin commented Nov 19, 2019 •
edited
Loading

Stack from ghstack:

Differential Revision: D18624986

This was referenced Nov 19, 2019
Closed
Closed
Closed
@VitalyFedyunin
Copy link
Contributor Author

VitalyFedyunin commented Nov 22, 2019

@ailzhang can you please take a look at XLA failure

@ailzhang
Copy link
Contributor

ailzhang commented Nov 22, 2019

@VitalyFedyunin XLA is passing, no? ;)

@VitalyFedyunin
add experimental code to check model on "Switch default memory format…
fc2caa0 
… of _like operators to Preserve"

Differential Revision: [D18624986](https://our.internmc.facebook.com/intern/diff/D18624986)

[ghstack-poisoned]
@VitalyFedyunin VitalyFedyunin mentioned this pull request Nov 22, 2019
Closed
This was referenced Dec 4, 2019
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 11, 2019
Closed
Closed
@kostmo
Copy link
Member

kostmo commented Dec 12, 2019 •
edited
Loading

CircleCI build failures summary

As of commit 093aa7c:

  • 2/2 failures introduced in this PR

Detailed failure analysis

One may explore the probable reasons each build failed interactively on the Dr. CI website.

2 new failures recognized by patterns

The following build failures don't appear to be due to upstream breakage:

See CircleCI build pytorch_xla_linux_xenial_py3_6_clang7_test (1/2)

Step: "Test" (details)

Dec 13 02:22:58 +++ eval 'extract_trap_cmd ' 
Dec 13 02:22:58 ++++ extract_trap_cmd 
Dec 13 02:22:58 ++++ printf '%s\n' '' 
Dec 13 02:22:58 +++ printf '%s\n' cleanup 
Dec 13 02:22:58 ++ trap -- ' 
Dec 13 02:22:58 cleanup' EXIT 
Dec 13 02:22:58 ++ which sccache 
Dec 13 02:22:58 ++ sccache --stop-server 
Dec 13 02:22:58 Stopping sccache server... 
Dec 13 02:22:58 error: couldn't connect to server 
Dec 13 02:22:58 caused by: Connection refused (os error 111) 
Dec 13 02:22:58 ++ true 
Dec 13 02:22:58 ++ rm /var/lib/jenkins/sccache_error.log 
Dec 13 02:22:58 ++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log 
Dec 13 02:22:58 ++ SCCACHE_IDLE_TIMEOUT=1200 
Dec 13 02:22:58 ++ RUST_LOG=sccache::server=error 
Dec 13 02:22:58 ++ sccache --start-server 
Dec 13 02:22:58 Starting sccache server... 
Dec 13 02:22:58 ++ sccache --zero-stats 
Dec 13 02:22:58 Compile requests                 0 
Dec 13 02:22:58 Compile requests executed        0

See CircleCI build pytorch_macos_10_13_py3_test (2/2)

Step: "Test" (details)

Dec 12 19:59:33 Generating XML reports... 
Dec 12 19:59:33 Running test_quantized_nn_mods ... [2019-12-12 19:59:33.576169] 
Dec 12 19:59:34  
Dec 12 19:59:34 Running tests... 
Dec 12 19:59:34 ---------------------------------------------------------------------- 
Dec 12 19:59:35 s...Traceback (most recent call last): 
Dec 12 19:59:35   File "test/run_test.py", line 456, in <module> 
Dec 12 19:59:35     main() 
Dec 12 19:59:35   File "test/run_test.py", line 449, in main 
Dec 12 19:59:35     raise RuntimeError(message) 
Dec 12 19:59:35 RuntimeError: test_quantized_nn_mods failed! Received signal: SIGSEGV 
Dec 12 19:59:35 + cleanup 
Dec 12 19:59:35 + retcode=1 
Dec 12 19:59:35 + set +x

This comment was automatically generated by Dr. CI.
Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 6 times.

gchanan
gchanan reviewed Dec 12, 2019
View reviewed changes
aten/src/ATen/native/TensorFactories.cpp

auto memory_format =
optional_memory_format.value_or(MemoryFormat::Contiguous);
optional_memory_format.value_or(MemoryFormat::Preserve);
Copy link
Contributor

@gchanan gchanan Dec 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you going to change new_empty (below)? I don't know what the right answer is, just asking.

Copy link
Contributor Author

@VitalyFedyunin VitalyFedyunin Dec 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually yes, as we start increasing support.

This was referenced Dec 13, 2019
Closed
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Dec 18, 2019

@VitalyFedyunin merged this pull request in 927588d.

@facebook-github-bot facebook-github-bot deleted the gh/VitalyFedyunin/87/head branch December 18, 2019 15:17
xxtEchjovs44 pushed a commit to xxtEchjovs44/pytorch that referenced this pull request Jan 29, 2020
@VitalyFedyunin
Switch default memory format of _like operators to Preserve
8cec783 
ghstack-source-id: 1bc2a0d
Pull Request resolved: pytorch/pytorch#30087
wuhuikx pushed a commit to wuhuikx/pytorch that referenced this pull request Jan 30, 2020
@VitalyFedyunin @facebook-github-bot
Switch default memory format of _like operators to Preserve
a8dd74f 
Summary: Pull Request resolved: pytorch#30087

Test Plan: Imported from OSS

Differential Revision: D18624986

Pulled By: VitalyFedyunin

fbshipit-source-id: 8e434966f872ffaddf1249248ea445cbbab300ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gchanan gchanan gchanan approved these changes

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@VitalyFedyunin @ailzhang @kostmo @facebook-github-bot @gchanan @mruberry