Remove BUILD_NAMEDTENSOR from codegen and .cu files#31047
Closed
zou3519 wants to merge 4 commits intogh/zou3519/220/basefrom
Closed
Remove BUILD_NAMEDTENSOR from codegen and .cu files#31047zou3519 wants to merge 4 commits intogh/zou3519/220/basefrom
zou3519 wants to merge 4 commits intogh/zou3519/220/basefrom
Conversation
Changelist: - remove BUILD_NAMEDTENSOR from .cu files - remove BUILD_NAMEDTENSOR special handling in function_wrapper.py - remove BUILD_NAMEDTENSOR from cpp_extension.py. This code actually did nothing because we always compile with BUILD_NAMEDTENSOR. Test Plan: - run tests [ghstack-poisoned]
zou3519
added a commit
that referenced
this pull request
Dec 10, 2019
Changelist: - remove BUILD_NAMEDTENSOR from .cu files - remove BUILD_NAMEDTENSOR special handling in function_wrapper.py - remove BUILD_NAMEDTENSOR from cpp_extension.py. This code actually did nothing because we always compile with BUILD_NAMEDTENSOR. Test Plan: - run tests ghstack-source-id: 30cd505 Pull Request resolved: #31047
Changelist: - remove BUILD_NAMEDTENSOR from .cu files - remove BUILD_NAMEDTENSOR special handling in function_wrapper.py, gen.py - remove BUILD_NAMEDTENSOR from cpp_extension.py. This code actually did nothing because we always compile with BUILD_NAMEDTENSOR. Test Plan: - run tests Differential Revision: [D18908442](https://our.internmc.facebook.com/intern/diff/D18908442) [ghstack-poisoned]
zou3519
added a commit
that referenced
this pull request
Dec 10, 2019
Changelist: - remove BUILD_NAMEDTENSOR from .cu files - remove BUILD_NAMEDTENSOR special handling in function_wrapper.py, gen.py - remove BUILD_NAMEDTENSOR from cpp_extension.py. This code actually did nothing because we always compile with BUILD_NAMEDTENSOR. Test Plan: - run tests ghstack-source-id: a8c8b30 Pull Request resolved: #31047
Changelist: - remove BUILD_NAMEDTENSOR from .cu files - remove BUILD_NAMEDTENSOR special handling in function_wrapper.py, gen.py - remove BUILD_NAMEDTENSOR from cpp_extension.py. This code actually did nothing because we always compile with BUILD_NAMEDTENSOR. Test Plan: - run tests Differential Revision: [D18908442](https://our.internmc.facebook.com/intern/diff/D18908442) [ghstack-poisoned]
zou3519
added a commit
that referenced
this pull request
Dec 10, 2019
Changelist: - remove BUILD_NAMEDTENSOR from .cu files - remove BUILD_NAMEDTENSOR special handling in function_wrapper.py, gen.py - remove BUILD_NAMEDTENSOR from cpp_extension.py. This code actually did nothing because we always compile with BUILD_NAMEDTENSOR. Test Plan: - run tests ghstack-source-id: 1cb4897 Pull Request resolved: #31047
Collaborator
|
Can you also add what work remains for removing the flag after this PR (or if this is the final PR)? |
nairbv
approved these changes
Dec 10, 2019
Contributor
Author
I'll add it to the body of the PR. There is some work remaining. |
Changelist: - remove BUILD_NAMEDTENSOR from .cu files - remove BUILD_NAMEDTENSOR special handling in function_wrapper.py, gen.py - remove BUILD_NAMEDTENSOR from cpp_extension.py. This code actually did nothing because we always compile with BUILD_NAMEDTENSOR. Future work: - Remove torch._C.BUILD_NAMEDTENSOR. This is used in some python functions. - Remove aten/src/ATen/env.py, which defines BUILD_NAMEDTENSOR=True for codegen. There should be no use cases of this left after this PR, but it is future work to check that. - Remove `aten/src/ATen/core/EnableNamedTensor.h`, which defines the BUILD_NAMEDTENSOR C++ macro. There should be no uses of this left after this PR, but it is future work to check that Test Plan: - run tests Differential Revision: [D18908442](https://our.internmc.facebook.com/intern/diff/D18908442) [ghstack-poisoned]
zou3519
added a commit
that referenced
this pull request
Dec 10, 2019
Changelist: - remove BUILD_NAMEDTENSOR from .cu files - remove BUILD_NAMEDTENSOR special handling in function_wrapper.py, gen.py - remove BUILD_NAMEDTENSOR from cpp_extension.py. This code actually did nothing because we always compile with BUILD_NAMEDTENSOR. Future work: - Remove torch._C.BUILD_NAMEDTENSOR. This is used in some python functions. - Remove aten/src/ATen/env.py, which defines BUILD_NAMEDTENSOR=True for codegen. There should be no use cases of this left after this PR, but it is future work to check that. - Remove `aten/src/ATen/core/EnableNamedTensor.h`, which defines the BUILD_NAMEDTENSOR C++ macro. There should be no uses of this left after this PR, but it is future work to check that Test Plan: - run tests ghstack-source-id: 12136d1 Pull Request resolved: #31047
Contributor
Author
|
The |
This was referenced Dec 11, 2019
Contributor
wuhuikx
pushed a commit
to wuhuikx/pytorch
that referenced
this pull request
Jan 30, 2020
Summary: Pull Request resolved: pytorch#31047 Changelist: - remove BUILD_NAMEDTENSOR from .cu files - remove BUILD_NAMEDTENSOR special handling in function_wrapper.py - remove BUILD_NAMEDTENSOR from cpp_extension.py. This code actually did nothing because we always compile with BUILD_NAMEDTENSOR. Test Plan: - run tests Differential Revision: D18908442 Pulled By: zou3519 fbshipit-source-id: b239e24de58580adaf3cef573350773a38b1e4f0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Changelist:
gen.py
did nothing because we always compile with BUILD_NAMEDTENSOR.
Future work:
functions.
codegen. There should be no use cases of this left after this PR, but it
is future work to check that.
aten/src/ATen/core/EnableNamedTensor.h, which definesthe BUILD_NAMEDTENSOR C++ macro. There should be no uses of this left
after this PR, but it is future work to check that
Test Plan:
Differential Revision: D18908442