Skip to content

Remove all remaining usages of BUILD_NAMEDTENSOR#31116

Closed
zou3519 wants to merge 3 commits intogh/zou3519/221/basefrom
gh/zou3519/221/head
Closed

Remove all remaining usages of BUILD_NAMEDTENSOR#31116
zou3519 wants to merge 3 commits intogh/zou3519/221/basefrom
gh/zou3519/221/head

Conversation

@zou3519
Copy link
Contributor

@zou3519 zou3519 commented Dec 11, 2019 •
edited
Loading

Stack from ghstack:

Changelist:

  • remove BUILD_NAMEDTENSOR macro
  • remove torch._C._BUILD_NAMEDTENSOR
  • remove all python behavior that relies on torch._C._BUILD_NAMEDTENSOR

Future:

  • In the next diff, I will remove all usages of
    ATen/core/EnableNamedTensor.h since that header doesn't do anything
    anymore
  • After that, we'll be done with the BUILD_NAMEDTENSOR removal.

Test Plan:

  • run CI

Differential Revision: D18934951

@zou3519
Remove all remaining usages of BUILD_NAMEDTENSOR
df1eb36 
Changelist:
- remove BUILD_NAMEDTENSOR macro
- remove torch._C._BUILD_NAMEDTENSOR
- remove all python behavior that relies on torch._C._BUILD_NAMEDTENSOR

Future:
- In the next diff, I will remove all usages of
ATen/core/EnableNamedTensor.h since that header doesn't do anything
anymore
- After that, we'll be done with the BUILD_NAMEDTENSOR removal.

Test Plan:
- run CI

[ghstack-poisoned]
This was referenced Dec 11, 2019
Closed
Closed
@zou3519
Update on "Remove all remaining usages of BUILD_NAMEDTENSOR"
4b56a9f 
Changelist:
- remove BUILD_NAMEDTENSOR macro
- remove torch._C._BUILD_NAMEDTENSOR
- remove all python behavior that relies on torch._C._BUILD_NAMEDTENSOR

Future:
- In the next diff, I will remove all usages of
ATen/core/EnableNamedTensor.h since that header doesn't do anything
anymore
- After that, we'll be done with the BUILD_NAMEDTENSOR removal.

Test Plan:
- run CI

[ghstack-poisoned]
@zou3519 zou3519 requested review from gchanan, izdeby and nairbv December 11, 2019 17:27
@zou3519
Update on "Remove all remaining usages of BUILD_NAMEDTENSOR"
ed73563 
Changelist:
- remove BUILD_NAMEDTENSOR macro
- remove torch._C._BUILD_NAMEDTENSOR
- remove all python behavior that relies on torch._C._BUILD_NAMEDTENSOR

Future:
- In the next diff, I will remove all usages of
ATen/core/EnableNamedTensor.h since that header doesn't do anything
anymore
- After that, we'll be done with the BUILD_NAMEDTENSOR removal.

Test Plan:
- run CI

Differential Revision: [D18934951](https://our.internmc.facebook.com/intern/diff/D18934951)

[ghstack-poisoned]
@kostmo
Copy link
Member

kostmo commented Dec 12, 2019 •
edited
Loading

CircleCI build failures summary

As of commit ed73563:

  • 3/3 failures introduced in this PR

Detailed failure analysis

One may explore the probable reasons each build failed interactively on the Dr. CI website.

1 new failure recognized by patterns

The following build failures don't appear to be due to upstream breakage:

See CircleCI build pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-build (1/1)

Step: "pytorch android gradle build" (details)

sys	0m0.129s
++ docker run --cap-add=SYS_PTRACE --security-opt seccomp=unconfined -t -d -w /var/lib/jenkins 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-xenial-py3-clang5-android-ndk-r19c:405-ed73563c7cde0433b7c587fc544bd8a236e2fb7c-android-x86_32
+ export id_x86_32=a93cc1c2714522d14a05a22b7c43c827e88c03a99bf6e297e3996d2418e12959
+ id_x86_32=a93cc1c2714522d14a05a22b7c43c827e88c03a99bf6e297e3996d2418e12959
+ export 'COMMAND=((echo "source ./workspace/env" && echo "sudo chown -R jenkins workspace") | docker exec -u jenkins -i "$id_x86_32" bash) 2>&1'
+ COMMAND='((echo "source ./workspace/env" && echo "sudo chown -R jenkins workspace") | docker exec -u jenkins -i "$id_x86_32" bash) 2>&1'
+ echo '((echo' '"source' './workspace/env"' '&&' echo '"sudo' chown -R jenkins 'workspace")' '|' docker exec -u jenkins -i '"$id_x86_32"' 'bash)' '2>&1'
+ unbuffer bash ./command.sh
+ ts
+ docker pull 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-xenial-py3-clang5-android-ndk-r19c:405-ed73563c7cde0433b7c587fc544bd8a236e2fb7c-android-arm-v7a
Error response from daemon: manifest for 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-xenial-py3-clang5-android-ndk-r19c:405-ed73563c7cde0433b7c587fc544bd8a236e2fb7c-android-arm-v7a not found

2 failures not recognized by patterns:

Job Step
CircleCI pytorch_xla_linux_xenial_py3_6_clang7_build Build
CircleCI pytorch_windows_build Build

This comment was automatically generated by Dr. CI.
Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 2 times.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Dec 13, 2019

@zou3519 merged this pull request in 9047d4d.

@facebook-github-bot facebook-github-bot deleted the gh/zou3519/221/head branch December 16, 2019 15:18
wuhuikx pushed a commit to wuhuikx/pytorch that referenced this pull request Jan 30, 2020
@zou3519 @facebook-github-bot
Remove all remaining usages of BUILD_NAMEDTENSOR (pytorch#31116)
beed756 
Summary:
Pull Request resolved: pytorch#31116

Changelist:
- remove BUILD_NAMEDTENSOR macro
- remove torch._C._BUILD_NAMEDTENSOR
- remove all python behavior that relies on torch._C._BUILD_NAMEDTENSOR

Future:
- In the next diff, I will remove all usages of
ATen/core/EnableNamedTensor.h since that header doesn't do anything
anymore
- After that, we'll be done with the BUILD_NAMEDTENSOR removal.

Test Plan: - run CI

Differential Revision: D18934951

Pulled By: zou3519

fbshipit-source-id: 0a0df0f1f0470d0a01c495579333a2835aac9f5d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nairbv nairbv nairbv approved these changes

@gchanan gchanan Awaiting requested review from gchanan

@izdeby izdeby Awaiting requested review from izdeby

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zou3519 @kostmo @facebook-github-bot @nairbv @mruberry