Remove unnecessary ATen/core/EnableNamedTensor.h#31117
Closed
zou3519 wants to merge 3 commits intogh/zou3519/222/basefrom
Closed
Remove unnecessary ATen/core/EnableNamedTensor.h#31117zou3519 wants to merge 3 commits intogh/zou3519/222/basefrom
zou3519 wants to merge 3 commits intogh/zou3519/222/basefrom
Conversation
After this diff, we will have completely removed the named tensor feature flagging. This means that named tensors are always on and that there is no mechanism to turn them off. There should be no more follow-up diffs. I performed the deletion of the header with ``` find . -type f -print0 | xargs -0 sed -i '/#include <ATen\/core\/EnableNamedTensor.h>/d' ``` Test Plan: - wait for CI [ghstack-poisoned]
This was referenced Dec 11, 2019
After this diff, we will have completely removed the named tensor feature flagging. This means that named tensors are always on and that there is no mechanism to turn them off. There should be no more follow-up diffs. I performed the deletion of the header with ``` find . -type f -print0 | xargs -0 sed -i '/#include <ATen\/core\/EnableNamedTensor.h>/d' ``` Test Plan: - wait for CI [ghstack-poisoned]
nairbv
reviewed
Dec 11, 2019
| @@ -1,2 +0,0 @@ | |||
| #pragma once | |||
| // We are working on removing the BUILD_NAMEDTENSOR flag from the codebase. | |||
Collaborator
There was a problem hiding this comment.
it's a bit unclear to me from github, is this removing the file or just the contents of the file? if not removing, then I'd think we still have one more PR to add to the stack?
Contributor
Author
There was a problem hiding this comment.
This is removing the file
nairbv
approved these changes
Dec 11, 2019
After this diff, we will have completely removed the named tensor feature flagging. This means that named tensors are always on and that there is no mechanism to turn them off. There should be no more follow-up diffs. I performed the deletion of the header with ``` find . -type f -print0 | xargs -0 sed -i '/#include <ATen\/core\/EnableNamedTensor.h>/d' ``` Test Plan: - wait for CI Differential Revision: [D18934952](https://our.internmc.facebook.com/intern/diff/D18934952) [ghstack-poisoned]
zou3519
added a commit
that referenced
this pull request
Dec 12, 2019
After this diff, we will have completely removed the named tensor feature flagging. This means that named tensors are always on and that there is no mechanism to turn them off. There should be no more follow-up diffs. I performed the deletion of the header with ``` find . -type f -print0 | xargs -0 sed -i '/#include <ATen\/core\/EnableNamedTensor.h>/d' ``` Test Plan: - wait for CI ghstack-source-id: e7593e6 Pull Request resolved: #31117
Member
CircleCI build failures summaryAs of commit b31cc46:
Detailed failure analysisOne may explore the probable reasons each build failed interactively on the Dr. CI website. 1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI. Please report bugs/suggestions on the GitHub issue tracker. |
Contributor
Author
|
I reran the windows build and it succeeded: https://app.circleci.com/jobs/github/pytorch/pytorch/3923679 so the build looks flaky. |
Contributor
wuhuikx
pushed a commit
to wuhuikx/pytorch
that referenced
this pull request
Jan 30, 2020
Summary: Pull Request resolved: pytorch#31117 After this diff, we will have completely removed the named tensor feature flagging. This means that named tensors are always on and that there is no mechanism to turn them off. There should be no more follow-up diffs. I performed the deletion of the header with ``` find . -type f -print0 | xargs -0 sed -i '/#include <ATen\/core\/EnableNamedTensor.h>/d' ``` Test Plan: - wait for CI Differential Revision: D18934952 Pulled By: zou3519 fbshipit-source-id: 253d059074b910fef15bdf885ebf71e0edf5bea5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
After this diff, we will have completely removed the named tensor
feature flagging. This means that named tensors are always on and that
there is no mechanism to turn them off. There should be no more follow-up
diffs.
I performed the deletion of the header with
Test Plan:
Differential Revision: D18934952