Skip to content

Moving average for statistics in observers#26626

Closed
raghuramank100 wants to merge 6 commits intogh/raghuramank100/37/basefrom
gh/raghuramank100/37/head
Closed

Moving average for statistics in observers#26626
raghuramank100 wants to merge 6 commits intogh/raghuramank100/37/basefrom
gh/raghuramank100/37/head

Conversation

@raghuramank100
Copy link
Copy Markdown
Contributor

@raghuramank100 raghuramank100 commented Sep 22, 2019 •
edited
Loading

Stack from ghstack:

Differential Revision: D17520344

This was referenced Sep 22, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
dzhulgakov
dzhulgakov reviewed Sep 24, 2019
View reviewed changes
Comment thread torch/quantization/observer.py
# aten/src/ATen/native/quantized/cpu/qconv.cpp
# This is not the optimal choice for non x86 backends as
# lose a bit of precision for activations.
self.averaging_constant = kwargs.pop('averaging_constant', 0.01)
Copy link
Copy Markdown
Collaborator

@dzhulgakov dzhulgakov Sep 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: you don't need to do pop, just do __init__(self, averaging_constant=0.01, **kwargs) above

Comment thread torch/quantization/observer.py

def __init__(self, bins=2048, **kwargs):
# bins: The number of bins used for histogram calculation.
self.averaging_constant = kwargs.pop('averaging_constant', 0.01)
Copy link
Copy Markdown
Collaborator

@dzhulgakov dzhulgakov Sep 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@raghuramank100 raghuramank100 added this to the 1.3 milestone Sep 27, 2019
@gchanan gchanan added the oncall: quantization Quantization support in PyTorch label Oct 4, 2019
xxtEchjovs44 pushed a commit to xxtEchjovs44/pytorch that referenced this pull request Jan 29, 2020
@raghuramank10000
Moving average for statistics in observers
5f605f8 
Pull Request resolved: pytorch/pytorch#26626


ghstack-source-id: 90704730

Differential Revision: [D17520344](https://our.internmc.facebook.com/intern/diff/D17520344/)
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Feb 17, 2022

Hi @raghuramank100!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 18, 2022

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions Bot added the Stale label Apr 18, 2022
@github-actions github-actions Bot closed this May 18, 2022
@facebook-github-bot facebook-github-bot deleted the gh/raghuramank100/37/head branch June 17, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dzhulgakov dzhulgakov dzhulgakov left review comments

@hx89 hx89 Awaiting requested review from hx89

@lly-zero-one lly-zero-one Awaiting requested review from lly-zero-one

Assignees

No one assigned

Labels

cla signed oncall: quantization Quantization support in PyTorch open source Stale

Projects

None yet

Milestone

1.3

Development

Successfully merging this pull request may close these issues.

6 participants

@raghuramank100 @facebook-github-bot @dzhulgakov @gchanan @pytorchbot @raghuramank10000