Default histogram observer#26622
Closed
raghuramank100 wants to merge 10 commits intogh/raghuramank100/33/basefrom
Closed
Default histogram observer#26622raghuramank100 wants to merge 10 commits intogh/raghuramank100/33/basefrom
raghuramank100 wants to merge 10 commits intogh/raghuramank100/33/basefrom
Conversation
Differential Revision: [D17508787](https://our.internmc.facebook.com/intern/diff/D17508787/) [ghstack-poisoned]
This was referenced Sep 22, 2019
Closed
jerryzh168
reviewed
Sep 23, 2019
| kwargs.setdefault("reduce_range", True) | ||
| return observer(MinMaxObserver, **kwargs) | ||
|
|
||
| def default_l2_observer(**kwargs): |
Contributor
There was a problem hiding this comment.
nit: should we use default_histogram_observer to align the names?
jerryzh168
reviewed
Sep 23, 2019
Differential Revision: [D17508787](https://our.internmc.facebook.com/intern/diff/D17508787/) [ghstack-poisoned]
Differential Revision: [D17508787](https://our.internmc.facebook.com/intern/diff/D17508787/) [ghstack-poisoned]
Differential Revision: [D17508787](https://our.internmc.facebook.com/intern/diff/D17508787/) [ghstack-poisoned]
raghuramank100
pushed a commit
that referenced
this pull request
Sep 23, 2019
Pull Request resolved: #26622 ghstack-source-id: 90632954 Differential Revision: [D17508787](https://our.internmc.facebook.com/intern/diff/D17508787/)
dzhulgakov
reviewed
Sep 23, 2019
Differential Revision: [D17508787](https://our.internmc.facebook.com/intern/diff/D17508787/) [ghstack-poisoned]
Differential Revision: [D17508787](https://our.internmc.facebook.com/intern/diff/D17508787/) [ghstack-poisoned]
Differential Revision: [D17508787](https://our.internmc.facebook.com/intern/diff/D17508787/) [ghstack-poisoned]
Differential Revision: [D17508787](https://our.internmc.facebook.com/intern/diff/D17508787/) [ghstack-poisoned]
Differential Revision: [D17508787](https://our.internmc.facebook.com/intern/diff/D17508787/) [ghstack-poisoned]
Differential Revision: [D17508787](https://our.internmc.facebook.com/intern/diff/D17508787/) [ghstack-poisoned]
Contributor
|
This pull request has been merged in 102a148. |
pdlive215
pushed a commit
to pdlive215/pytorch
that referenced
this pull request
Nov 27, 2019
Summary: Pull Request resolved: pytorch#26622 ghstack-source-id: 90897064 Test Plan: buck test caffe2/test:quantization -- --print-passing-details Differential Revision: D17508787 fbshipit-source-id: ae733ab35ec9b0233264014b8054d4d870fb05e1
xxtEchjovs44
pushed a commit
to xxtEchjovs44/pytorch
that referenced
this pull request
Jan 29, 2020
Pull Request resolved: pytorch/pytorch#26622 ghstack-source-id: 90632954 Differential Revision: [D17508787](https://our.internmc.facebook.com/intern/diff/D17508787/)
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#26622 ghstack-source-id: 90897064 Test Plan: buck test caffe2/test:quantization -- --print-passing-details Differential Revision: D17508787 fbshipit-source-id: ae733ab35ec9b0233264014b8054d4d870fb05e1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D17508787