Fake quantization enhancements for QAT/PTQ support- fix tests#26876
Closed
raghuramank100 wants to merge 3 commits intogh/raghuramank100/39/basefrom
Closed
Fake quantization enhancements for QAT/PTQ support- fix tests#26876raghuramank100 wants to merge 3 commits intogh/raghuramank100/39/basefrom
raghuramank100 wants to merge 3 commits intogh/raghuramank100/39/basefrom
Conversation
Add ability to turn fake quantization and observers independently. Differential Revision: [D17592961](https://our.internmc.facebook.com/intern/diff/D17592961/) [ghstack-poisoned]
This was referenced Sep 26, 2019
Closed
dzhulgakov
approved these changes
Sep 26, 2019
Collaborator
dzhulgakov
left a comment
There was a problem hiding this comment.
Tests on this one fail with autograd error which seems to be related. But it's probably from another PR in the stack
| def enable_fake_quant(self): | ||
| self.observer.enable() | ||
| self.weight_fake_quant.enable() | ||
| self.observer.enable_fake_quant() |
Collaborator
There was a problem hiding this comment.
I feel the ordering of the PRs is weird as you delete it later :) but it's ok
Contributor
Author
There was a problem hiding this comment.
Yes, on hind-sight having fewer PRs would have been better.
…sts" Add ability to turn fake quantization and observers independently. Differential Revision: [D17592961](https://our.internmc.facebook.com/intern/diff/D17592961/) [ghstack-poisoned]
…sts" Add ability to turn fake quantization and observers independently. Differential Revision: [D17592961](https://our.internmc.facebook.com/intern/diff/D17592961/) [ghstack-poisoned]
Contributor
|
This pull request has been merged in 9a5e2e8. |
pdlive215
pushed a commit
to pdlive215/pytorch
that referenced
this pull request
Nov 27, 2019
…h#26876) Summary: Pull Request resolved: pytorch#26876 Add ability to turn fake quantization and observers independently. ghstack-source-id: 90892132 Test Plan: buck test caffe2/test:quantized -- 'test_conv_bn_relu \(test_qat\.IntrinsicQATModuleTest\)' --print-passing-details Differential Revision: D17592961 fbshipit-source-id: 24c60c94ed7c6c9fa55c634a8545731614e4f52f
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…h#26876) Summary: Pull Request resolved: pytorch#26876 Add ability to turn fake quantization and observers independently. ghstack-source-id: 90892132 Test Plan: buck test caffe2/test:quantized -- 'test_conv_bn_relu \(test_qat\.IntrinsicQATModuleTest\)' --print-passing-details Differential Revision: D17592961 fbshipit-source-id: 24c60c94ed7c6c9fa55c634a8545731614e4f52f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Add ability to turn fake quantization and observers independently.
Differential Revision: D17592961