Default observer and fake-quant for backends#26627
Closed
raghuramank100 wants to merge 11 commits intogh/raghuramank100/38/basefrom
Closed
Default observer and fake-quant for backends#26627raghuramank100 wants to merge 11 commits intogh/raghuramank100/38/basefrom
raghuramank100 wants to merge 11 commits intogh/raghuramank100/38/basefrom
Conversation
Differential Revision: [D17518194](https://our.internmc.facebook.com/intern/diff/D17518194/) [ghstack-poisoned]
This was referenced Sep 22, 2019
Closed
raghuramank100
pushed a commit
that referenced
this pull request
Sep 22, 2019
Differential Revision: [D17518194](https://our.internmc.facebook.com/intern/diff/D17518194/) ghstack-source-id: 90556162 Pull Request resolved: #26627
Differential Revision: [D17518194](https://our.internmc.facebook.com/intern/diff/D17518194/) [ghstack-poisoned]
raghuramank100
pushed a commit
that referenced
this pull request
Sep 23, 2019
Pull Request resolved: #26627 ghstack-source-id: 90556162 Differential Revision: [D17518194](https://our.internmc.facebook.com/intern/diff/D17518194/)
Differential Revision: [D17518194](https://our.internmc.facebook.com/intern/diff/D17518194/) [ghstack-poisoned]
Differential Revision: [D17518194](https://our.internmc.facebook.com/intern/diff/D17518194/) [ghstack-poisoned]
raghuramank100
pushed a commit
that referenced
this pull request
Sep 23, 2019
Pull Request resolved: #26627 ghstack-source-id: 90623342 Differential Revision: [D17518194](https://our.internmc.facebook.com/intern/diff/D17518194/)
Differential Revision: [D17518194](https://our.internmc.facebook.com/intern/diff/D17518194/) [ghstack-poisoned]
raghuramank100
pushed a commit
that referenced
this pull request
Sep 24, 2019
Pull Request resolved: #26627 ghstack-source-id: 90623342 Differential Revision: [D17518194](https://our.internmc.facebook.com/intern/diff/D17518194/)
dzhulgakov
reviewed
Sep 24, 2019
| default_qat_qconfig = QConfig(activation=default_fake_quant, | ||
| weight=default_weight_fake_quant) | ||
|
|
||
| def get_default_qconfig(backend='fbgemm'): |
Collaborator
There was a problem hiding this comment.
technically - it's not even fbgemm, but rather fbgemm on per-CooperLake x86 :-\ . But I don't know how to make it nicer.
Contributor
Author
There was a problem hiding this comment.
I agree, perhaps just call it server and have a comment stating that you need to know about the hardware platform to ensure you are picking a good default?
Contributor
Author
There was a problem hiding this comment.
Actually with mkl-dnn not sure how to improve on this, so leaving this as is for now
| def get_default_qconfig(backend='fbgemm'): | ||
| if backend == 'fbgemm': | ||
| qconfig = QConfig(activation=HistogramObserver.with_args(reduce_range=True), | ||
| weight=default_per_channel_weight_observer) |
Collaborator
There was a problem hiding this comment.
so we do per-channel only for fbgemm, not for mobile?
Contributor
Author
There was a problem hiding this comment.
Mobile does not support per-channel kernels currently. If and when QNNPACK supports it, we can change that.
torch/quantization/QConfig.py
Outdated
|
|
||
| def get_default_qat_qconfig(backend='fbgemm'): | ||
| if backend == 'fbgemm': | ||
| qconfig = QConfig(activation=FakeQuantize.with_args(observer=default_l2_observer(reduce_range = True), |
Collaborator
There was a problem hiding this comment.
I think this will create the same instance of observer for each FakeQuant - you probably need double with_args, but it gets ugly...
Differential Revision: [D17518194](https://our.internmc.facebook.com/intern/diff/D17518194/) [ghstack-poisoned]
raghuramank100
pushed a commit
that referenced
this pull request
Sep 24, 2019
Pull Request resolved: #26627 ghstack-source-id: 90704697 Differential Revision: [D17518194](https://our.internmc.facebook.com/intern/diff/D17518194/)
Differential Revision: [D17518194](https://our.internmc.facebook.com/intern/diff/D17518194/) [ghstack-poisoned]
Differential Revision: [D17518194](https://our.internmc.facebook.com/intern/diff/D17518194/) [ghstack-poisoned]
raghuramank100
pushed a commit
that referenced
this pull request
Sep 28, 2019
Pull Request resolved: #26627 ghstack-source-id: 90979560 Differential Revision: [D17518194](https://our.internmc.facebook.com/intern/diff/D17518194/)
dzhulgakov
approved these changes
Sep 28, 2019
Collaborator
dzhulgakov
left a comment
There was a problem hiding this comment.
Feel free to land this PR before the others (reorder the stack) as it's useful
Differential Revision: [D17518194](https://our.internmc.facebook.com/intern/diff/D17518194/) [ghstack-poisoned]
raghuramank100
pushed a commit
that referenced
this pull request
Sep 29, 2019
Pull Request resolved: #26627 ghstack-source-id: 90997604 Differential Revision: [D17518194](https://our.internmc.facebook.com/intern/diff/D17518194/)
Differential Revision: [D17518194](https://our.internmc.facebook.com/intern/diff/D17518194/) [ghstack-poisoned]
Differential Revision: [D17518194](https://our.internmc.facebook.com/intern/diff/D17518194/) [ghstack-poisoned]
raghuramank100
pushed a commit
that referenced
this pull request
Sep 30, 2019
Pull Request resolved: #26627 ghstack-source-id: 91008337 Differential Revision: [D17518194](https://our.internmc.facebook.com/intern/diff/D17518194/)
Contributor
|
This pull request has been merged in d5298b6. |
jamesr66a
pushed a commit
that referenced
this pull request
Oct 3, 2019
Summary: Pull Request resolved: #26627 ghstack-source-id: 91008337 Test Plan: buck test caffe2/test:quantization -- --print-passing-details Differential Revision: D17518194 fbshipit-source-id: 1eb8a7a85dc811c4ee5228d68563abb157613ceb
jamesr66a
pushed a commit
that referenced
this pull request
Oct 3, 2019
Summary: Pull Request resolved: #26627 ghstack-source-id: 91008337 Test Plan: buck test caffe2/test:quantization -- --print-passing-details Differential Revision: D17518194 fbshipit-source-id: 1eb8a7a85dc811c4ee5228d68563abb157613ceb
jamesr66a
pushed a commit
that referenced
this pull request
Oct 4, 2019
Summary: Pull Request resolved: #26627 ghstack-source-id: 91008337 Test Plan: buck test caffe2/test:quantization -- --print-passing-details Differential Revision: D17518194 fbshipit-source-id: 1eb8a7a85dc811c4ee5228d68563abb157613ceb
jamesr66a
pushed a commit
that referenced
this pull request
Oct 4, 2019
Summary: Pull Request resolved: #26627 ghstack-source-id: 91008337 Test Plan: buck test caffe2/test:quantization -- --print-passing-details Differential Revision: D17518194 fbshipit-source-id: 1eb8a7a85dc811c4ee5228d68563abb157613ceb
soumith
pushed a commit
that referenced
this pull request
Oct 7, 2019
Summary: Pull Request resolved: #26627 ghstack-source-id: 91008337 Test Plan: buck test caffe2/test:quantization -- --print-passing-details Differential Revision: D17518194 fbshipit-source-id: 1eb8a7a85dc811c4ee5228d68563abb157613ceb
pdlive215
pushed a commit
to pdlive215/pytorch
that referenced
this pull request
Nov 27, 2019
Summary: Pull Request resolved: pytorch#26627 ghstack-source-id: 91008337 Test Plan: buck test caffe2/test:quantization -- --print-passing-details Differential Revision: D17518194 fbshipit-source-id: 1eb8a7a85dc811c4ee5228d68563abb157613ceb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D17518194