[pytorch][cmake] improve how pytorch_android cmake imports static lib#26525
Closed
ljk53 wants to merge 1 commit intogh/ljk53/52/basefrom
Closed
[pytorch][cmake] improve how pytorch_android cmake imports static lib#26525ljk53 wants to merge 1 commit intogh/ljk53/52/basefrom
ljk53 wants to merge 1 commit intogh/ljk53/52/basefrom
Conversation
Summary: Create a util function to avoid boilerplate code as we are adding more libraries. Test Plan: - build CI; [ghstack-poisoned]
This was referenced Sep 20, 2019
IvanKobzarev
approved these changes
Sep 20, 2019
Contributor
mingbowan
pushed a commit
to mingbowan/pytorch
that referenced
this pull request
Sep 23, 2019
Summary: Pull Request resolved: pytorch#26525 Create a util function to avoid boilerplate code as we are adding more libraries. Test Plan: - build CI; Differential Revision: D17495394 Pulled By: ljk53 fbshipit-source-id: 9e19f96ede4867bdff5157424fa68b71e6cff8bf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Create a util function to avoid boilerplate code as we are adding more
libraries.
Test Plan:
Differential Revision: D17495394