[pytorch] expose USE_STATIC_DISPATCH macro to public headers#26476
Closed
ljk53 wants to merge 2 commits intogh/ljk53/49/basefrom
Closed
[pytorch] expose USE_STATIC_DISPATCH macro to public headers#26476ljk53 wants to merge 2 commits intogh/ljk53/49/basefrom
ljk53 wants to merge 2 commits intogh/ljk53/49/basefrom
Conversation
Summary: USE_STATIC_DISPATCH needs to be exposed as we don't hide header files containing it for iOS (yet). Otherwise it's error-prone to request all external projects to set the macro correctly on their own. Also remove redundant USE_STATIC_DISPATCH definition from other places. Test Plan: - build android gradle to confirm linker can still strip out dead code; - integrate with demo app to confirm inference can run without problem; [ghstack-poisoned]
Summary: USE_STATIC_DISPATCH needs to be exposed as we don't hide header files containing it for iOS (yet). Otherwise it's error-prone to request all external projects to set the macro correctly on their own. Also remove redundant USE_STATIC_DISPATCH definition from other places. Test Plan: - build android gradle to confirm linker can still strip out dead code; - integrate with demo app to confirm inference can run without problem; Differential Revision: [D17484260](https://our.internmc.facebook.com/intern/diff/D17484260) [ghstack-poisoned]
ezyang
approved these changes
Sep 20, 2019
dreiss
approved these changes
Sep 20, 2019
Contributor
Author
|
Already landed but somehow hasn't been closed automatically... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
USE_STATIC_DISPATCH needs to be exposed as we don't hide header files
containing it for iOS (yet). Otherwise it's error-prone to request all
external projects to set the macro correctly on their own.
Also remove redundant USE_STATIC_DISPATCH definition from other places.
Test Plan:
Differential Revision: D17484260