[pytorch] update android/iOS build library packing#26565
Closed
ljk53 wants to merge 2 commits intogh/ljk53/53/basefrom
Closed
[pytorch] update android/iOS build library packing#26565ljk53 wants to merge 2 commits intogh/ljk53/53/basefrom
ljk53 wants to merge 2 commits intogh/ljk53/53/basefrom
Conversation
Summary: For OSS mobile build we should keep QNNPACK off and PYTORCH_QNNPACK on as we don't include caffe2 ops that use third_party/QNNPACK. Update android/iOS build script to include new libraries accordingly. Test Plan: - CI build [ghstack-poisoned]
This was referenced Sep 20, 2019
xta0
approved these changes
Sep 20, 2019
IvanKobzarev
approved these changes
Sep 20, 2019
dreiss
approved these changes
Sep 20, 2019
Summary: For OSS mobile build we should keep QNNPACK off and PYTORCH_QNNPACK on as we don't include caffe2 ops that use third_party/QNNPACK. Update android/iOS build script to include new libraries accordingly. Test Plan: - CI build Differential Revision: [D17508918](https://our.internmc.facebook.com/intern/diff/D17508918) [ghstack-poisoned]
Contributor
mingbowan
pushed a commit
to mingbowan/pytorch
that referenced
this pull request
Sep 23, 2019
Summary: Pull Request resolved: pytorch#26565 For OSS mobile build we should keep QNNPACK off and PYTORCH_QNNPACK on as we don't include caffe2 ops that use third_party/QNNPACK. Update android/iOS build script to include new libraries accordingly. Test Plan: - CI build Differential Revision: D17508918 Pulled By: ljk53 fbshipit-source-id: 0483d45646d4d503b4e5c1d483e4df72cffc6c68
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
For OSS mobile build we should keep QNNPACK off and PYTORCH_QNNPACK on
as we don't include caffe2 ops that use third_party/QNNPACK.
Update android/iOS build script to include new libraries accordingly.
Test Plan:
Differential Revision: D17508918