[pytorch] update build_android.sh to not build host protoc for libtorch#25896
Closed
ljk53 wants to merge 2 commits intogh/ljk53/39/basefrom
Closed
[pytorch] update build_android.sh to not build host protoc for libtorch#25896ljk53 wants to merge 2 commits intogh/ljk53/39/basefrom
ljk53 wants to merge 2 commits intogh/ljk53/39/basefrom
Conversation
Summary: Similar change as PR #25822. Test Plan: - Updated CI to use the new script. - Will check pytorch android CI output to make sure it builds libtorch instead of libcaffe2.
This was referenced Sep 10, 2019
Closed
… for libtorch" Summary: Similar change as PR #25822. Test Plan: - Updated CI to use the new script. - Will check pytorch android CI output to make sure it builds libtorch instead of libcaffe2. Pull Request resolved: #25896 Differential Revision: [D17279722](https://our.internmc.facebook.com/intern/diff/D17279722)
ljk53
added a commit
that referenced
this pull request
Sep 10, 2019
… mobile build Summary: Should have cleaned up the remaining protobuf dependencies before landing PR #25896. Test Plan: - CI build;
Contributor
Author
|
SORRY seems this broke the android CI - landed from internal diff and forgot the external CI... If PR #25958 doesn't fix the build I'll revert... |
ljk53
added a commit
that referenced
this pull request
Sep 10, 2019
…or libtorch mobile build" Summary: Should have cleaned up the remaining protobuf dependencies before landing PR #25896. Test Plan: - CI build; Pull Request resolved: #25958 Differential Revision: [D17296949](https://our.internmc.facebook.com/intern/diff/D17296949)
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Similar change as PR #25822.
Test Plan:
instead of libcaffe2.
Pull Request resolved: #25896
Differential Revision: D17279722