Closed
Conversation
Summary Since protobuf has been removed from mobile, the `build_host_protoc.sh` can be removed from `build_ios.sh` as well. However, the old caffe2 mobile build might still depends on it, therefore, I introduced this `BUILD_PYTORCH_MOBILE` flag to gate the build. - iOS device build ``` BUILD_PYTORCH_MOBILE=1 IOS_ARCH=arm64 ./scripts/build_ios.sh BUILD_PYTORCH_MOBILE=1 IOS_ARCH=armv7s ./scripts/build_ios.sh ``` - iOS simulator build ``` BUILD_PYTORCH_MOBILE=1 IOS_PLATFORM=SIMULATOR ./scripts/build_ios.sh ``` Test Plan All device and simulator builds run successfully
Summary Since protobuf has been removed from mobile, the `build_host_protoc.sh` can be removed from `build_ios.sh` as well. However, the old caffe2 mobile build might still depends on it, therefore, I introduced this `BUILD_PYTORCH_MOBILE` flag to gate the build. - iOS device build ``` BUILD_PYTORCH_MOBILE=1 IOS_ARCH=arm64 ./scripts/build_ios.sh BUILD_PYTORCH_MOBILE=1 IOS_ARCH=armv7s ./scripts/build_ios.sh ``` - iOS simulator build ``` BUILD_PYTORCH_MOBILE=1 IOS_PLATFORM=SIMULATOR ./scripts/build_ios.sh ``` Test Plan All device and simulator builds run successfully
### Summary Since protobuf has been removed from mobile, the `build_host_protoc.sh` can be removed from `build_ios.sh` as well. However, the old caffe2 mobile build still depend on it, therefore, I introduced this `BUILD_PYTORCH_MOBILE` flag to gate the build. - iOS device build ``` BUILD_PYTORCH_MOBILE=1 IOS_ARCH=arm64 ./scripts/build_ios.sh BUILD_PYTORCH_MOBILE=1 IOS_ARCH=armv7s ./scripts/build_ios.sh ``` - iOS simulator build ``` BUILD_PYTORCH_MOBILE=1 IOS_PLATFORM=SIMULATOR ./scripts/build_ios.sh ``` ### Test Plan All device and simulator builds run successfully
xta0
added a commit
that referenced
this pull request
Sep 7, 2019
Summary Since protobuf has been removed from mobile, the `build_host_protoc.sh` can be removed from `build_ios.sh` as well. However, the old caffe2 mobile build might still depends on it, therefore, I introduced this `BUILD_PYTORCH_MOBILE` flag to gate the build. - iOS device build ``` BUILD_PYTORCH_MOBILE=1 IOS_ARCH=arm64 ./scripts/build_ios.sh BUILD_PYTORCH_MOBILE=1 IOS_ARCH=armv7s ./scripts/build_ios.sh ``` - iOS simulator build ``` BUILD_PYTORCH_MOBILE=1 IOS_PLATFORM=SIMULATOR ./scripts/build_ios.sh ``` Test Plan All device and simulator builds run successfully ghstack-source-id: 94701cc Pull Request resolved: #25822
Contributor
ljk53
added a commit
that referenced
this pull request
Sep 10, 2019
Summary: Similar change as PR #25822. Test Plan: - Updated CI to use the new script. - Will check pytorch android CI output to make sure it builds libtorch instead of libcaffe2.
ljk53
added a commit
that referenced
this pull request
Sep 10, 2019
… for libtorch" Summary: Similar change as PR #25822. Test Plan: - Updated CI to use the new script. - Will check pytorch android CI output to make sure it builds libtorch instead of libcaffe2. Pull Request resolved: #25896 Differential Revision: [D17279722](https://our.internmc.facebook.com/intern/diff/D17279722)
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 10, 2019
Summary: Pull Request resolved: #25896 Similar change as PR #25822. Test Plan: - Updated CI to use the new script. - Will check pytorch android CI output to make sure it builds libtorch instead of libcaffe2. Reviewed By: dreiss Differential Revision: D17279722 Pulled By: ljk53 fbshipit-source-id: 93abcef0dfb93df197fabff29e53d71db5674255
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary
Since protobuf has been removed from mobile, the
build_host_protoc.shcan be removed frombuild_ios.shas well. However, the old caffe2 mobile build still depend on it, therefore, I introduced thisBUILD_PYTORCH_MOBILEflag to gate the build.Test Plan
All device and simulator builds run successfully
Differential Revision: D17264469