[pytorch][cmake] remove protobuf from Dependencies.cmake for libtorch mobile build#25958
Closed
ljk53 wants to merge 2 commits intogh/ljk53/42/basefrom
Closed
[pytorch][cmake] remove protobuf from Dependencies.cmake for libtorch mobile build#25958ljk53 wants to merge 2 commits intogh/ljk53/42/basefrom
ljk53 wants to merge 2 commits intogh/ljk53/42/basefrom
Conversation
… mobile build Summary: Should have cleaned up the remaining protobuf dependencies before landing PR #25896. Test Plan: - CI build;
…or libtorch mobile build" Summary: Should have cleaned up the remaining protobuf dependencies before landing PR #25896. Test Plan: - CI build; Pull Request resolved: #25958 Differential Revision: [D17296949](https://our.internmc.facebook.com/intern/diff/D17296949)
This was referenced Sep 10, 2019
Contributor
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 11, 2019
…5958) Summary: Pull Request resolved: pytorch/pytorch#25958 Should have cleaned up the remaining protobuf dependencies before landing PR #25896. Test Plan: - CI build; Reviewed By: dreiss Differential Revision: D17296949 Pulled By: ljk53 fbshipit-source-id: 20c444e63900c7fa054db3cc757d3f18614af630
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Should have cleaned up the remaining protobuf dependencies before landing PR #25896.
Test Plan:
Pull Request resolved: #25958
Differential Revision: D17296949