Skip to content

Add ignore_index to NLLLoss2d#2077

Closed
fyu wants to merge 2 commits intopytorch:masterfrom
fyu:ignore_index_2d
Closed

Add ignore_index to NLLLoss2d#2077
fyu wants to merge 2 commits intopytorch:masterfrom
fyu:ignore_index_2d

Conversation

@fyu
Copy link
Contributor

@fyu fyu commented Jul 13, 2017

It always exists in NLLLoss and this can be very useful for semantic segmentation.

@fyu fyu force-pushed the ignore_index_2d branch 2 times, most recently from 8d67651 to 2b106be Compare July 13, 2017 10:52
@fyu fyu force-pushed the ignore_index_2d branch from 2b106be to 78020a5 Compare July 13, 2017 10:53
@fyu
Copy link
Contributor Author

fyu commented Jul 13, 2017

@apaszke Any hint on why checks succeed on python 2.7.8 but failed on the others?

@soumith
Copy link
Collaborator

soumith commented Jul 14, 2017

needed a very minor fix in legacy, loading from previously serialized models wouldn't have self.ignore_index. I fixed this and merged the PR into master.
Thanks @fyu !

@soumith soumith closed this Jul 14, 2017
@fyu
Copy link
Contributor Author

fyu commented Jul 14, 2017

Thanks @soumith @apaszke for the prompt merge!

houseroad added a commit to houseroad/pytorch that referenced this pull request Jun 27, 2019
…2f85f1

Summary:
Previous import was 355a4954ea4e5836a5e943589509951c44feb6b4

Included changes:
- **[d94f99d2](onnx/onnx@d94f99d2)**: Avoid unnecessary copies of names by checker (pytorch#2098) <Scott McKay>
- **[01f77251](onnx/onnx@01f77251)**: update qlinear conv test (pytorch#2120) <Ashwini Khade>
- **[1f0c13d3](onnx/onnx@1f0c13d3)**: Add shape inference for LinearClassifier (pytorch#2077) <Hariharan Seshadri>
- **[eb798fcf](onnx/onnx@eb798fcf)**: Fix inconsistency in describing graph's initializer. The initializer (pytorch#2115) <xykong58>

Differential Revision: D16040208

fbshipit-source-id: eca5f963cf5a84572f553b4ae4136973a5e30441
houseroad added a commit to houseroad/pytorch that referenced this pull request Jun 28, 2019
…8ddcca

Summary:
Previous import was 355a4954ea4e5836a5e943589509951c44feb6b4

Included changes:
- **[806aa863](onnx/onnx@806aa863)**: Expose ONNX_ML build option to python (pytorch#2138) <bddppq>
- **[8f6e60db](onnx/onnx@8f6e60db)**: Missing newline fix   (pytorch#2128) <Chris Seymour>
- **[d94f99d2](onnx/onnx@d94f99d2)**: Avoid unnecessary copies of names by checker (pytorch#2098) <Scott McKay>
- **[01f77251](onnx/onnx@01f77251)**: update qlinear conv test (pytorch#2120) <Ashwini Khade>
- **[1f0c13d3](onnx/onnx@1f0c13d3)**: Add shape inference for LinearClassifier (pytorch#2077) <Hariharan Seshadri>
- **[eb798fcf](onnx/onnx@eb798fcf)**: Fix inconsistency in describing graph's initializer. The initializer (pytorch#2115) <xykong58>

Reviewed By: zrphercule

Differential Revision: D16061494

fbshipit-source-id: effe2fa669cf840c715ecd8f5f128efe27415bd0
facebook-github-bot pushed a commit that referenced this pull request Jun 29, 2019
…8ddcca (#22359)

Summary:
Pull Request resolved: #22359

Previous import was 355a4954ea4e5836a5e943589509951c44feb6b4

Included changes:
- **[806aa863](onnx/onnx@806aa863)**: Expose ONNX_ML build option to python (#2138) <bddppq>
- **[8f6e60db](onnx/onnx@8f6e60db)**: Missing newline fix   (#2128) <Chris Seymour>
- **[d94f99d2](onnx/onnx@d94f99d2)**: Avoid unnecessary copies of names by checker (#2098) <Scott McKay>
- **[01f77251](onnx/onnx@01f77251)**: update qlinear conv test (#2120) <Ashwini Khade>
- **[1f0c13d3](onnx/onnx@1f0c13d3)**: Add shape inference for LinearClassifier (#2077) <Hariharan Seshadri>
- **[eb798fcf](onnx/onnx@eb798fcf)**: Fix inconsistency in describing graph's initializer. The initializer (#2115) <xykong58>

Reviewed By: bddppq, zrphercule

Differential Revision: D16061494

fbshipit-source-id: 6ccb63c135c27b307048aa42c11313675027ffb7
xzhu1900 pushed a commit to xzhu1900/pytorch that referenced this pull request Jul 5, 2019
…8ddcca (pytorch#22359)

Summary:
Pull Request resolved: pytorch#22359

Previous import was 355a4954ea4e5836a5e943589509951c44feb6b4

Included changes:
- **[806aa863](onnx/onnx@806aa863)**: Expose ONNX_ML build option to python (pytorch#2138) <bddppq>
- **[8f6e60db](onnx/onnx@8f6e60db)**: Missing newline fix   (pytorch#2128) <Chris Seymour>
- **[d94f99d2](onnx/onnx@d94f99d2)**: Avoid unnecessary copies of names by checker (pytorch#2098) <Scott McKay>
- **[01f77251](onnx/onnx@01f77251)**: update qlinear conv test (pytorch#2120) <Ashwini Khade>
- **[1f0c13d3](onnx/onnx@1f0c13d3)**: Add shape inference for LinearClassifier (pytorch#2077) <Hariharan Seshadri>
- **[eb798fcf](onnx/onnx@eb798fcf)**: Fix inconsistency in describing graph's initializer. The initializer (pytorch#2115) <xykong58>

Reviewed By: bddppq, zrphercule

Differential Revision: D16061494

fbshipit-source-id: 6ccb63c135c27b307048aa42c11313675027ffb7
jagadish-amd pushed a commit to jagadish-amd/pytorch that referenced this pull request May 20, 2025
…MM with no bias vector. (pytorch#2077)

Omit the bias type argument for BLAS logging when there is a ScaledGEMM
with no bias vector.

Pull Request resolved: pytorch#149357
Approved by: https://github.com/jeffdaily

(cherry picked from commit dbea13e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants