Fix when running with python -O#2120
Merged
soumith merged 1 commit intopytorch:masterfrom Jul 16, 2017
Merged
Conversation
Collaborator
|
thanks! |
Contributor
|
This is still incorrect, because if someone runs with -O, then we won't even check if the initialization completed without errors. I have a patch in a PR that I'll send in a moment |
houseroad
added a commit
to houseroad/pytorch
that referenced
this pull request
Jun 27, 2019
…2f85f1 Summary: Previous import was 355a4954ea4e5836a5e943589509951c44feb6b4 Included changes: - **[d94f99d2](onnx/onnx@d94f99d2)**: Avoid unnecessary copies of names by checker (pytorch#2098) <Scott McKay> - **[01f77251](onnx/onnx@01f77251)**: update qlinear conv test (pytorch#2120) <Ashwini Khade> - **[1f0c13d3](onnx/onnx@1f0c13d3)**: Add shape inference for LinearClassifier (pytorch#2077) <Hariharan Seshadri> - **[eb798fcf](onnx/onnx@eb798fcf)**: Fix inconsistency in describing graph's initializer. The initializer (pytorch#2115) <xykong58> Differential Revision: D16040208 fbshipit-source-id: eca5f963cf5a84572f553b4ae4136973a5e30441
houseroad
added a commit
to houseroad/pytorch
that referenced
this pull request
Jun 28, 2019
…8ddcca Summary: Previous import was 355a4954ea4e5836a5e943589509951c44feb6b4 Included changes: - **[806aa863](onnx/onnx@806aa863)**: Expose ONNX_ML build option to python (pytorch#2138) <bddppq> - **[8f6e60db](onnx/onnx@8f6e60db)**: Missing newline fix (pytorch#2128) <Chris Seymour> - **[d94f99d2](onnx/onnx@d94f99d2)**: Avoid unnecessary copies of names by checker (pytorch#2098) <Scott McKay> - **[01f77251](onnx/onnx@01f77251)**: update qlinear conv test (pytorch#2120) <Ashwini Khade> - **[1f0c13d3](onnx/onnx@1f0c13d3)**: Add shape inference for LinearClassifier (pytorch#2077) <Hariharan Seshadri> - **[eb798fcf](onnx/onnx@eb798fcf)**: Fix inconsistency in describing graph's initializer. The initializer (pytorch#2115) <xykong58> Reviewed By: zrphercule Differential Revision: D16061494 fbshipit-source-id: effe2fa669cf840c715ecd8f5f128efe27415bd0
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 29, 2019
…8ddcca (#22359) Summary: Pull Request resolved: #22359 Previous import was 355a4954ea4e5836a5e943589509951c44feb6b4 Included changes: - **[806aa863](onnx/onnx@806aa863)**: Expose ONNX_ML build option to python (#2138) <bddppq> - **[8f6e60db](onnx/onnx@8f6e60db)**: Missing newline fix (#2128) <Chris Seymour> - **[d94f99d2](onnx/onnx@d94f99d2)**: Avoid unnecessary copies of names by checker (#2098) <Scott McKay> - **[01f77251](onnx/onnx@01f77251)**: update qlinear conv test (#2120) <Ashwini Khade> - **[1f0c13d3](onnx/onnx@1f0c13d3)**: Add shape inference for LinearClassifier (#2077) <Hariharan Seshadri> - **[eb798fcf](onnx/onnx@eb798fcf)**: Fix inconsistency in describing graph's initializer. The initializer (#2115) <xykong58> Reviewed By: bddppq, zrphercule Differential Revision: D16061494 fbshipit-source-id: 6ccb63c135c27b307048aa42c11313675027ffb7
xzhu1900
pushed a commit
to xzhu1900/pytorch
that referenced
this pull request
Jul 5, 2019
…8ddcca (pytorch#22359) Summary: Pull Request resolved: pytorch#22359 Previous import was 355a4954ea4e5836a5e943589509951c44feb6b4 Included changes: - **[806aa863](onnx/onnx@806aa863)**: Expose ONNX_ML build option to python (pytorch#2138) <bddppq> - **[8f6e60db](onnx/onnx@8f6e60db)**: Missing newline fix (pytorch#2128) <Chris Seymour> - **[d94f99d2](onnx/onnx@d94f99d2)**: Avoid unnecessary copies of names by checker (pytorch#2098) <Scott McKay> - **[01f77251](onnx/onnx@01f77251)**: update qlinear conv test (pytorch#2120) <Ashwini Khade> - **[1f0c13d3](onnx/onnx@1f0c13d3)**: Add shape inference for LinearClassifier (pytorch#2077) <Hariharan Seshadri> - **[eb798fcf](onnx/onnx@eb798fcf)**: Fix inconsistency in describing graph's initializer. The initializer (pytorch#2115) <xykong58> Reviewed By: bddppq, zrphercule Differential Revision: D16061494 fbshipit-source-id: 6ccb63c135c27b307048aa42c11313675027ffb7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running optimized python removes
asserts which causes #1848 .