[ROCm][TunableOp] Minor fix to BLAS logging for ScaledGEMM with no bias vector.#149357
Closed
naromero77amd wants to merge 1 commit intopytorch:mainfrom
Closed
[ROCm][TunableOp] Minor fix to BLAS logging for ScaledGEMM with no bias vector.#149357naromero77amd wants to merge 1 commit intopytorch:mainfrom
naromero77amd wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/149357
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (3 Unrelated Failures)As of commit 431622d with merge base e51615c ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jeffdaily
approved these changes
Mar 18, 2025
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
naromero77amd
added a commit
to ROCm/pytorch
that referenced
this pull request
Apr 23, 2025
…as vector. (pytorch#149357) Omit the bias type argument for BLAS logging when there is a ScaledGEMM with no bias vector. Pull Request resolved: pytorch#149357 Approved by: https://github.com/jeffdaily (cherry picked from commit dbea13e)
naromero77amd
added a commit
to ROCm/pytorch
that referenced
this pull request
Apr 30, 2025
…as vector. (pytorch#149357) Omit the bias type argument for BLAS logging when there is a ScaledGEMM with no bias vector. Pull Request resolved: pytorch#149357 Approved by: https://github.com/jeffdaily (cherry picked from commit dbea13e)
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Apr 30, 2025
…MM with no bias vector. (#2077) Omit the bias type argument for BLAS logging when there is a ScaledGEMM with no bias vector. Pull Request resolved: pytorch#149357 Approved by: https://github.com/jeffdaily (cherry picked from commit dbea13e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Omit the bias type argument for BLAS logging when there is a ScaledGEMM with no bias vector.
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang