Revert "[BE] Remove Optional and Union usage repo wide (#176918)"#177184
Revert "[BE] Remove Optional and Union usage repo wide (#176918)"#177184huydhn wants to merge 2 commits intopytorch:mainfrom
Optional and Union usage repo wide (#176918)"#177184Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/177184
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 70 PendingAs of commit 1f9b4fe with merge base ad67e7a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot merge -f 'Should be ok, this is a revert and lint jobs have passed' |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…177314) This got revertedin #177184 due to some conflict with unrelated PR that needed to be reverted - lets finally kill Optional/Union usage! Pull Request resolved: #177314 Approved by: https://github.com/aorenste, https://github.com/fxdawnn
This reverts commit b244229.
This is needed to unblock diff train because #176918 has a merge conflict with #175497 and the latter has been reverted by #177113. The PRs and their reverts were landed in interlocking order in fbcode, so this is the only way to untangle them.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @jataylo @Lucaskabela @laithsakka As you both are updating these 2 files:
torch/fx/experimental/_size_hinting.pytorch/fx/experimental/symbolic_shapes.pyWe probably to coordinate their landing later