symbolic shapes guarding_hint_or_throw and optimization_hint by laithsakka · Pull Request #175497 · pytorch/pytorch

laithsakka · 2026-02-22T18:59:26Z

Stack from ghstack (oldest at bottom):

-> symbolic shapes guarding_hint_or_throw and optimization_hint #175497

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @jataylo @Lucaskabela

[ghstack-poisoned]

pytorch-bot · 2026-02-22T18:59:30Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/175497

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit fad6bf3 with merge base 07efc60 ():

FLAKY - The following job failed but was likely due to flakiness present on trunk:

inductor / inductor-cpu-test / test (inductor_torchbench_cpu_smoketest_perf, 1, 1, linux.24xl.spr-metal) (gh) (detected as infra flaky with no log or failing log classifier)

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

linux-aarch64 / linux-jammy-aarch64-py3.10 / test (openreg, 1, 1, lf.linux.arm64.m8g.4xlarge) (gh) (trunk failure)
'Test'

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

inductor / inductor-cpu-test / test (cpu_inductor_torchbench, 1, 2, linux.2xlarge.amx, unstable) (gh) (#174929)
detectron2_maskrcnn_r_50_fpn

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ghstack-source-id: d473b98 Pull Request resolved: #175497

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben jataylo Lucaskabela [ghstack-poisoned]

ghstack-source-id: e299aef Pull Request resolved: #175497

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben jataylo Lucaskabela [ghstack-poisoned]

ghstack-source-id: 0eeb78e Pull Request resolved: #175497

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben jataylo Lucaskabela [ghstack-poisoned]

ghstack-source-id: 8334b3a Pull Request resolved: #175497

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben jataylo Lucaskabela [ghstack-poisoned]

ghstack-source-id: dc8a5fa Pull Request resolved: #175497

laithsakka · 2026-02-24T21:54:56Z

torch/_functorch/_aot_autograd/utils.py

 strict_zip = partial(zip, strict=True)


-def _get_symint_hints(exprs: Any) -> Any:


pytorchmergebot · 2026-03-06T18:02:56Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

zou3519 · 2026-03-07T02:52:31Z

@pytorchbot revert -c "nosignal" -m "breaking compile time benchmarks"

zou3519 · 2026-03-07T02:52:53Z

pytorchmergebot · 2026-03-07T02:54:22Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

…175497)" This reverts commit 5eb1752. Reverted #175497 on behalf of https://github.com/zou3519 due to breaking compile time benchmarks ([comment](#175497 (comment)))

pytorchmergebot · 2026-03-07T02:54:30Z

@laithsakka your PR has been successfully reverted.

laithsakka · 2026-03-07T06:41:09Z

@pytorchbot revert -c "nosignal" -m "breaking compile time benchmarks"

no it was not me :( it was this PR
615c79f
@zou3519 I messaged him he have a forward fix.
#176772

laithsakka · 2026-03-07T06:48:29Z

I will land this first #176755 to unblock landing my PR
once the fix for that regression (#176772) lands it shall reset the expected numbers back

laithsakka · 2026-03-07T06:55:03Z

@pytorchbot merge -f "already landed a fix for the pr_time benchmarks, the reason for revert see comment above"

pytorchmergebot · 2026-03-07T06:56:59Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

laithsakka · 2026-03-10T23:42:55Z

@pytorchbot revert -c "internal errors :("

pytorch-bot · 2026-03-10T23:42:57Z

❌ 🤖 pytorchbot command failed:

@pytorchbot revert: error: argument -c/--classification: invalid choice: 'internal errors :(' (choose from 'nosignal', 'ignoredsignal', 'landrace', 'weird', 'ghfirst', 'autorevert')

usage: @pytorchbot revert -m MESSAGE -c
                          {nosignal,ignoredsignal,landrace,weird,ghfirst,autorevert}

Try @pytorchbot --help for more info.

laithsakka · 2026-03-11T00:35:46Z

@pytorchbot revert -c "nosignal" -m "internal errors"

pytorchmergebot · 2026-03-11T00:37:26Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot · 2026-03-11T00:37:31Z

Reverting PR 175497 failed

Reason: Command git -C /home/runner/work/pytorch/pytorch revert --no-edit 9cc969af7598c6e9a11d46646c64e4e083445665 returned non-zero exit code 1

Auto-merging test/test_dynamic_shapes.py
Auto-merging torch/_dynamo/trace_rules.py
Auto-merging torch/_dynamo/variables/torch.py
Auto-merging torch/_functorch/aot_autograd.py
Auto-merging torch/_inductor/codecache.py
Auto-merging torch/_inductor/lowering.py
Auto-merging torch/_inductor/sizevars.py
CONFLICT (content): Merge conflict in torch/_inductor/sizevars.py
Auto-merging torch/_refs/__init__.py
Auto-merging torch/_subclasses/fake_impls.py
CONFLICT (modify/delete): torch/fx/experimental/_size_hinting.py deleted in parent of 9cc969af759 (symbolic shapes guarding_hint_or_throw and optimization_hint (#175497)) and modified in HEAD.  Version HEAD of torch/fx/experimental/_size_hinting.py left in tree.
Auto-merging torch/fx/experimental/symbolic_shapes.py
CONFLICT (content): Merge conflict in torch/fx/experimental/symbolic_shapes.py
error: could not revert 9cc969af759... symbolic shapes guarding_hint_or_throw and optimization_hint (#175497)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git revert --continue".
hint: You can instead skip this commit with "git revert --skip".
hint: To abort and get back to the state before "git revert",
hint: run "git revert --abort".
hint: Disable this message with "git config set advice.mergeConflict false"

Details for Dev Infra team

Raised by workflow job

…175497)" This reverts commit 9cc969a. [ghstack-poisoned]

…175497)" This reverts commit 9cc969a. ghstack-source-id: 0392a62 Pull Request resolved: #177112

…175497)" This reverts commit 9cc969a. [ghstack-poisoned]

…175497)" This reverts commit 9cc969a. ghstack-source-id: 12278ce Pull Request resolved: #177113

…175497)" (#177113) This reverts commit 9cc969a. Due to internal issues will re-land from fbcode. Pull Request resolved: #177113 Approved by: https://github.com/huydhn

…#177184) This reverts commit b244229. This is needed to unblock diff train because #176918 has a merge conflict with #175497 and the latter has been reverted by #177113. The PRs and their reverts were landed in interlocking order in fbcode, so this is the only way to untangle them. * `torch/fx/experimental/_size_hinting.py` * `torch/fx/experimental/symbolic_shapes.py` We probably to coordinate their landing later Pull Request resolved: #177184 Approved by: https://github.com/seemethere, https://github.com/zou3519

symbolic shapes guarding_hint_or_throw

78cca7d

[ghstack-poisoned]

laithsakka requested review from albanD, aorenste, bdhirsh, bobrenjc93 and mikaylagawarecki as code owners February 22, 2026 18:59

This was referenced Feb 21, 2026

migrate size_hints from 5 files #175216

Closed

All remianing size_hint deprecation #175219

Closed

laithsakka mentioned this pull request Feb 22, 2026

Use optimization_hint for triton kernel size_hints to fix unbacked perf regression #175220

Closed

pytorch-bot bot added ciflow/inductor module: dynamo module: inductor release notes: jit release notes category labels Feb 22, 2026

This was referenced Feb 20, 2026

better get_dep_size_hint cost analysis for hinted unbacked #175221

Closed

Handle u0*12>u0 in _dynamic_reshape_indexer #175232

Closed

Delete size_vars size_hint API #175365

Closed

laithsakka added a commit that referenced this pull request Feb 22, 2026

symbolic shapes guarding_hint_or_throw

b30ffb3

ghstack-source-id: d473b98 Pull Request resolved: #175497

laithsakka marked this pull request as draft February 22, 2026 19:00

Update on "symbolic shapes guarding_hint_or_throw"

e4891cc

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben jataylo Lucaskabela [ghstack-poisoned]

laithsakka added a commit that referenced this pull request Feb 22, 2026

symbolic shapes guarding_hint_or_throw

336f5bb

ghstack-source-id: e299aef Pull Request resolved: #175497

Update on "symbolic shapes guarding_hint_or_throw"

515025d

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben jataylo Lucaskabela [ghstack-poisoned]

This was referenced Feb 22, 2026

use optimization hint in ir_node_to_tensor and rename guard_shape #174935

Closed

more size hint deprecation #174946

Closed

laithsakka added a commit that referenced this pull request Feb 22, 2026

symbolic shapes guarding_hint_or_throw

1582dc4

ghstack-source-id: 0eeb78e Pull Request resolved: #175497

Update on "symbolic shapes guarding_hint_or_throw"

c1237eb

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben jataylo Lucaskabela [ghstack-poisoned]

laithsakka added a commit that referenced this pull request Feb 24, 2026

symbolic shapes guarding_hint_or_throw

33b4d2c

ghstack-source-id: 8334b3a Pull Request resolved: #175497

Update on "symbolic shapes guarding_hint_or_throw"

5f2c9ad

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben jataylo Lucaskabela [ghstack-poisoned]

laithsakka added a commit that referenced this pull request Feb 24, 2026

symbolic shapes guarding_hint_or_throw

a78adcb

ghstack-source-id: dc8a5fa Pull Request resolved: #175497

laithsakka commented Feb 24, 2026

View reviewed changes

pytorchmergebot closed this in 5eb1752 Mar 6, 2026

pytorchmergebot removed the merging label Mar 6, 2026

pytorchmergebot reopened this Mar 7, 2026

pytorchmergebot added the merging label Mar 7, 2026

pytorchmergebot closed this in 9cc969a Mar 7, 2026

pytorchmergebot removed the merging label Mar 7, 2026

laithsakka added a commit that referenced this pull request Mar 11, 2026

Revert "symbolic shapes guarding_hint_or_throw and optimization_hint (#…

aab083c

…175497)" This reverts commit 9cc969a. [ghstack-poisoned]

laithsakka added a commit that referenced this pull request Mar 11, 2026

Revert "symbolic shapes guarding_hint_or_throw and optimization_hint (#…

9eb0fb8

…175497)" This reverts commit 9cc969a. ghstack-source-id: 0392a62 Pull Request resolved: #177112

laithsakka added a commit that referenced this pull request Mar 11, 2026

Revert "symbolic shapes guarding_hint_or_throw and optimization_hint (#…

aba7e46

…175497)" This reverts commit 9cc969a. [ghstack-poisoned]

laithsakka added a commit that referenced this pull request Mar 11, 2026

Revert "symbolic shapes guarding_hint_or_throw and optimization_hint (#…

4042831

…175497)" This reverts commit 9cc969a. ghstack-source-id: 12278ce Pull Request resolved: #177113

huydhn mentioned this pull request Mar 11, 2026

Revert "[BE] Remove Optional and Union usage repo wide (#176918)" #177184

Closed

		strict_zip = partial(zip, strict=True)


		def _get_symint_hints(exprs: Any) -> Any:

Conversation

laithsakka commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/175497

✅ You can merge normally! (3 Unrelated Failures)

Uh oh!

laithsakka Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

pytorchmergebot commented Mar 6, 2026

Merge started

Uh oh!

zou3519 commented Mar 7, 2026

Uh oh!

zou3519 commented Mar 7, 2026

Uh oh!

pytorchmergebot commented Mar 7, 2026

Uh oh!

pytorchmergebot commented Mar 7, 2026

Uh oh!

laithsakka commented Mar 7, 2026

Uh oh!

laithsakka commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laithsakka commented Mar 7, 2026

Uh oh!

pytorchmergebot commented Mar 7, 2026

Merge started

Uh oh!

laithsakka commented Mar 10, 2026

Uh oh!

pytorch-bot bot commented Mar 10, 2026

Uh oh!

laithsakka commented Mar 11, 2026

Uh oh!

pytorchmergebot commented Mar 11, 2026

Uh oh!

pytorchmergebot commented Mar 11, 2026

Reverting PR 175497 failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

laithsakka commented Feb 22, 2026 •

edited

Loading

pytorch-bot bot commented Feb 22, 2026 •

edited

Loading

laithsakka commented Mar 7, 2026 •

edited

Loading