Revert "symbolic shapes guarding_hint_or_throw and optimization_hint (#175497)"#177113
Closed
laithsakka wants to merge 1 commit intogh/laithsakka/423/basefrom
Closed
Revert "symbolic shapes guarding_hint_or_throw and optimization_hint (#175497)"#177113laithsakka wants to merge 1 commit intogh/laithsakka/423/basefrom
laithsakka wants to merge 1 commit intogh/laithsakka/423/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/177113
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (7 Unrelated Failures)As of commit aba7e46 with merge base 4bc9d7f ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
laithsakka
added a commit
that referenced
this pull request
Mar 11, 2026
Contributor
|
@pytorchbot merge |
|
This PR needs to be approved by an authorized maintainer before merge. |
huydhn
approved these changes
Mar 11, 2026
Contributor
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
Contributor
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This was referenced Mar 11, 2026
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 11, 2026
…#177184) This reverts commit b244229. This is needed to unblock diff train because #176918 has a merge conflict with #175497 and the latter has been reverted by #177113. The PRs and their reverts were landed in interlocking order in fbcode, so this is the only way to untangle them. * `torch/fx/experimental/_size_hinting.py` * `torch/fx/experimental/symbolic_shapes.py` We probably to coordinate their landing later Pull Request resolved: #177184 Approved by: https://github.com/seemethere, https://github.com/zou3519
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This reverts commit 9cc969a.
Due to internal issues will re-land from fbcode.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @jataylo @Lucaskabela