[dynamo][misc] Replace UserFunctionVariable with VariableTracker build by anijain2305 · Pull Request #165707 · pytorch/pytorch

anijain2305 · 2025-10-17T00:03:05Z

Stack from ghstack (oldest at bottom):

Audit: To prevent future issues with functools.partial or callable
objects.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela

Audit: To prevent future issues with functools.partial or callable objects. [ghstack-poisoned]

pytorch-bot · 2025-10-17T00:03:09Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165707

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit bc21357 with merge base 84b14f3 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Audit: To prevent future issues with functools.partial or callable objects. ghstack-source-id: aa3e1d7 Pull Request resolved: #165707

Lucaskabela

Thanks for propagating this through the codebase!

Lucaskabela · 2025-10-17T16:47:54Z

Probably don't need comments here since it is misc.py - I am more concerned with documenting the reaasoning inside the user_defined variable class itself

anijain2305 · 2025-10-17T16:54:23Z

@pytorchbot merge

pytorchmergebot · 2025-10-17T16:56:34Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-10-20T17:29:00Z

@anijain2305 your PR has been reverted as part of the stack under #165706.

…ker build (#165707)" This reverts commit 630520b. Reverted #165707 on behalf of https://github.com/clee2000 due to breaking internal tests D84961097 ([comment](#165706 (comment)))

…racker build" Audit: To prevent future issues with functools.partial or callable objects. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]

pytorchmergebot · 2025-10-21T06:38:07Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorch#165707) Audit: To prevent future issues with functools.partial or callable objects. Pull Request resolved: pytorch#165707 Approved by: https://github.com/Lucaskabela ghstack dependencies: pytorch#165683, pytorch#165706

…ker build (pytorch#165707)" This reverts commit 630520b. Reverted pytorch#165707 on behalf of https://github.com/clee2000 due to breaking internal tests D84961097 ([comment](pytorch#165706 (comment)))

clee2000 · 2025-10-21T19:23:27Z

@pytorchbot revert -m "failing internal tests D85160820" -c ghfirst

pytorchmergebot · 2025-10-21T19:24:59Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

…ker build (#165707)" This reverts commit 1290b07. Reverted #165707 on behalf of https://github.com/clee2000 due to failing internal tests D85160820 ([comment](#165707 (comment)))

pytorchmergebot · 2025-10-21T19:25:07Z

@anijain2305 your PR has been successfully reverted.

pytorch#165707) Audit: To prevent future issues with functools.partial or callable objects. Pull Request resolved: pytorch#165707 Approved by: https://github.com/Lucaskabela ghstack dependencies: pytorch#165683, pytorch#165706

…ker build (pytorch#165707)" This reverts commit 630520b. Reverted pytorch#165707 on behalf of https://github.com/clee2000 due to breaking internal tests D84961097 ([comment](pytorch#165706 (comment)))

pytorch#165707) Audit: To prevent future issues with functools.partial or callable objects. Pull Request resolved: pytorch#165707 Approved by: https://github.com/Lucaskabela

…ker build (pytorch#165707)" This reverts commit 1290b07. Reverted pytorch#165707 on behalf of https://github.com/clee2000 due to failing internal tests D85160820 ([comment](pytorch#165707 (comment)))

…racker build" Audit: To prevent future issues with functools.partial or callable objects. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]

Audit: To prevent future issues with functools.partial or callable objects. ghstack-source-id: fef157e Pull Request resolved: #165707

anijain2305 · 2025-10-27T16:35:19Z

@pytorchbot nerge

pytorch-bot · 2025-10-27T16:35:22Z

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'nerge' (choose from 'merge', 'revert', 'rebase', 'label', 'drci', 'cherry-pick')

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick} ...

Try @pytorchbot --help for more info.

anijain2305 · 2025-10-27T16:35:27Z

@pytorchbot merge

pytorchmergebot · 2025-10-27T16:41:40Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

#165707) Audit: To prevent future issues with functools.partial or callable objects. Pull Request resolved: #165707 Approved by: https://github.com/Lucaskabela ghstack dependencies: #166251

[dynamo][misc] Replace UserFunctionVariable with VariableTracker build

acc25a8

Audit: To prevent future issues with functools.partial or callable objects. [ghstack-poisoned]

This was referenced Oct 17, 2025

[dynamo] Use Variable Builder to build the property fget object #165683

Closed

[dynamo][user_defined] Replace UserFunctionVariable with VariableTracker build #165706

Closed

pytorch-bot bot added ciflow/inductor module: dynamo labels Oct 17, 2025

anijain2305 added a commit that referenced this pull request Oct 17, 2025

[dynamo][misc] Replace UserFunctionVariable with VariableTracker build

51c8f12

Audit: To prevent future issues with functools.partial or callable objects. ghstack-source-id: aa3e1d7 Pull Request resolved: #165707

anijain2305 mentioned this pull request Oct 17, 2025

[dynamo][nn_module] Replace UserFunctionVariable with VariableTracker build #165708

Closed

anijain2305 added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Oct 17, 2025

anijain2305 requested review from ezyang, jansel and williamwen42 October 17, 2025 01:11

Lucaskabela approved these changes Oct 17, 2025

View reviewed changes

pytorchmergebot added the merging label Oct 17, 2025

pytorchmergebot added the Merged label Oct 17, 2025

pytorchmergebot closed this in 630520b Oct 17, 2025

pytorchmergebot removed the merging label Oct 17, 2025

pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Oct 20, 2025

pytorchmergebot reopened this Oct 20, 2025

anijain2305 mentioned this pull request Oct 21, 2025

[dynamo][remaining] Replace UserFunctionVariable with VariableTracker build #165896

Closed

pytorchmergebot closed this in 1290b07 Oct 21, 2025

pytorchmergebot removed the merging label Oct 21, 2025

pytorchmergebot reopened this Oct 21, 2025

anijain2305 mentioned this pull request Oct 26, 2025

[dynamo] Fix python_type for UserDefinedClassExceptionVariable #166251

Closed

anijain2305 added a commit that referenced this pull request Oct 26, 2025

[dynamo][misc] Replace UserFunctionVariable with VariableTracker build

3ad3be5

Audit: To prevent future issues with functools.partial or callable objects. ghstack-source-id: fef157e Pull Request resolved: #165707

anijain2305 mentioned this pull request Oct 26, 2025

[dynamo] Repro for 166238 #166252

Closed

pytorchmergebot added the merging label Oct 27, 2025

pytorchmergebot closed this in 99e07c3 Oct 27, 2025

pytorchmergebot removed the merging label Oct 27, 2025

can-gaa-hou mentioned this pull request Oct 28, 2025

[dynamo] Clean up assert in dynamo [3/N] #165903

Closed

github-actions bot deleted the gh/anijain2305/913/head branch November 28, 2025 02:17

Conversation

anijain2305 commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165707

✅ No Failures

Uh oh!

Lucaskabela left a comment

Choose a reason for hiding this comment

Uh oh!

Lucaskabela commented Oct 17, 2025

Uh oh!

anijain2305 commented Oct 17, 2025

Uh oh!

pytorchmergebot commented Oct 17, 2025

Merge started

Uh oh!

pytorchmergebot commented Oct 20, 2025

Uh oh!

pytorchmergebot commented Oct 21, 2025

Merge started

Uh oh!

clee2000 commented Oct 21, 2025

Uh oh!

pytorchmergebot commented Oct 21, 2025

Uh oh!

pytorchmergebot commented Oct 21, 2025

Uh oh!

anijain2305 commented Oct 27, 2025

Uh oh!

pytorch-bot bot commented Oct 27, 2025

Uh oh!

anijain2305 commented Oct 27, 2025

Uh oh!

pytorchmergebot commented Oct 27, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

anijain2305 commented Oct 17, 2025 •

edited

Loading

pytorch-bot bot commented Oct 17, 2025 •

edited

Loading