[dynamo] Use Variable Builder to build the property fget object#165683
[dynamo] Use Variable Builder to build the property fget object#165683anijain2305 wants to merge 2 commits intogh/anijain2305/911/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165683
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 37ffd69 with merge base d61a9b8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ezyang
left a comment
There was a problem hiding this comment.
Thanks can you also check functools.partial works?
| fget_vt = VariableTracker.build(tx, subobj.fget, source=source) | ||
| return fget_vt.call_function(tx, [self], {}) |
There was a problem hiding this comment.
Does this also work with functools.partial?
There was a problem hiding this comment.
UserFunctionVariable is also used in a few other places: https://github.com/search?q=repo%3Apytorch%2Fpytorch+UserFunctionVariable%28&type=code. Do we have a similar issue in some of those?
There was a problem hiding this comment.
Yes, we need an audit of other places, where we should directly use the variable builder. I will do that.
I will add a test for the functools.partial in the followup PR.
Update - Added the functools.partial test
…bject" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
|
@pytorchbot merge |
|
@pytorchbot merge -f "stuck merge job" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…ker build (#165706) Audit: To prevent future issues with functools.partial or callable objects. Pull Request resolved: #165706 Approved by: https://github.com/Lucaskabela ghstack dependencies: #165683
#165707) Audit: To prevent future issues with functools.partial or callable objects. Pull Request resolved: #165707 Approved by: https://github.com/Lucaskabela ghstack dependencies: #165683, #165706
…rch#165683) Pull Request resolved: pytorch#165683 Approved by: https://github.com/ezyang, https://github.com/williamwen42
…ker build (pytorch#165706) Audit: To prevent future issues with functools.partial or callable objects. Pull Request resolved: pytorch#165706 Approved by: https://github.com/Lucaskabela ghstack dependencies: pytorch#165683
pytorch#165707) Audit: To prevent future issues with functools.partial or callable objects. Pull Request resolved: pytorch#165707 Approved by: https://github.com/Lucaskabela ghstack dependencies: pytorch#165683, pytorch#165706
…rch#165683) Pull Request resolved: pytorch#165683 Approved by: https://github.com/ezyang, https://github.com/williamwen42
…ker build (pytorch#165706) Audit: To prevent future issues with functools.partial or callable objects. Pull Request resolved: pytorch#165706 Approved by: https://github.com/Lucaskabela ghstack dependencies: pytorch#165683
pytorch#165707) Audit: To prevent future issues with functools.partial or callable objects. Pull Request resolved: pytorch#165707 Approved by: https://github.com/Lucaskabela ghstack dependencies: pytorch#165683, pytorch#165706
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela