[dynamo][user_defined] Replace UserFunctionVariable with VariableTracker build#165706
Closed
anijain2305 wants to merge 2 commits intogh/anijain2305/912/basefrom
Closed
[dynamo][user_defined] Replace UserFunctionVariable with VariableTracker build#165706anijain2305 wants to merge 2 commits intogh/anijain2305/912/basefrom
anijain2305 wants to merge 2 commits intogh/anijain2305/912/basefrom
Conversation
…ker build Audit: To prevent future issues with functools.partial or callable objects. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165706
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit cf4560d with merge base af4ba78 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Lucaskabela
approved these changes
Oct 17, 2025
Contributor
Lucaskabela
left a comment
There was a problem hiding this comment.
nit: Maybe include some comment in the code on why we need to use build as opposed to the UserFunctionVariable here for posterity
Contributor
|
Otherwise LGTM! |
Collaborator
|
Starting merge as part of PR stack under #165707 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 17, 2025
#165707) Audit: To prevent future issues with functools.partial or callable objects. Pull Request resolved: #165707 Approved by: https://github.com/Lucaskabela ghstack dependencies: #165683, #165706
Contributor
|
@pytorchbot revert -m "breaking internal tests D84961097" -c ghfirst |
Collaborator
|
@pytorchbot successfully started a revert job. Check the current status here. |
pytorchmergebot
added a commit
that referenced
this pull request
Oct 20, 2025
…ker build (#165707)" This reverts commit 630520b. Reverted #165707 on behalf of https://github.com/clee2000 due to breaking internal tests D84961097 ([comment](#165706 (comment)))
pytorchmergebot
added a commit
that referenced
this pull request
Oct 20, 2025
…ableTracker build (#165706)" This reverts commit 1dc9a05. Reverted #165706 on behalf of https://github.com/clee2000 due to breaking internal tests D84961097 ([comment](#165706 (comment)))
Collaborator
|
@anijain2305 your PR has been successfully reverted. |
williamwen42
approved these changes
Oct 20, 2025
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
…ker build (pytorch#165706) Audit: To prevent future issues with functools.partial or callable objects. Pull Request resolved: pytorch#165706 Approved by: https://github.com/Lucaskabela ghstack dependencies: pytorch#165683
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
pytorch#165707) Audit: To prevent future issues with functools.partial or callable objects. Pull Request resolved: pytorch#165707 Approved by: https://github.com/Lucaskabela ghstack dependencies: pytorch#165683, pytorch#165706
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
…ker build (pytorch#165707)" This reverts commit 630520b. Reverted pytorch#165707 on behalf of https://github.com/clee2000 due to breaking internal tests D84961097 ([comment](pytorch#165706 (comment)))
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
…ableTracker build (pytorch#165706)" This reverts commit 1dc9a05. Reverted pytorch#165706 on behalf of https://github.com/clee2000 due to breaking internal tests D84961097 ([comment](pytorch#165706 (comment)))
zhudada0120
pushed a commit
to zhudada0120/pytorch
that referenced
this pull request
Oct 22, 2025
…ker build (pytorch#165706) Audit: To prevent future issues with functools.partial or callable objects. Pull Request resolved: pytorch#165706 Approved by: https://github.com/Lucaskabela ghstack dependencies: pytorch#165683
zhudada0120
pushed a commit
to zhudada0120/pytorch
that referenced
this pull request
Oct 22, 2025
pytorch#165707) Audit: To prevent future issues with functools.partial or callable objects. Pull Request resolved: pytorch#165707 Approved by: https://github.com/Lucaskabela ghstack dependencies: pytorch#165683, pytorch#165706
zhudada0120
pushed a commit
to zhudada0120/pytorch
that referenced
this pull request
Oct 22, 2025
…ker build (pytorch#165707)" This reverts commit 630520b. Reverted pytorch#165707 on behalf of https://github.com/clee2000 due to breaking internal tests D84961097 ([comment](pytorch#165706 (comment)))
zhudada0120
pushed a commit
to zhudada0120/pytorch
that referenced
this pull request
Oct 22, 2025
…ableTracker build (pytorch#165706)" This reverts commit 1dc9a05. Reverted pytorch#165706 on behalf of https://github.com/clee2000 due to breaking internal tests D84961097 ([comment](pytorch#165706 (comment)))
…ariableTracker build" Audit: To prevent future issues with functools.partial or callable objects. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Audit: To prevent future issues with functools.partial or callable
objects.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela