Skip to content

[3/N] Import Callable from collections.abc in torch/distributed#164104

Closed
cyyever wants to merge 1 commit intopytorch:mainfrom
cyyever:src_ruff_0352
Closed

[3/N] Import Callable from collections.abc in torch/distributed#164104
cyyever wants to merge 1 commit intopytorch:mainfrom
cyyever:src_ruff_0352

Conversation

@cyyever
Copy link
Collaborator

@cyyever cyyever commented Sep 29, 2025

This is the result of applying the ruff UP035 check.
Callable is imported from collections.abc instead of typing.
This PR is the follow-up of #164054.

cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta @msaroufim @dcci

@cyyever cyyever requested review from a team and mruberry as code owners September 29, 2025 03:40
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 29, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164104

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 823fdbc with merge base 3cda34e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
@cyyever cyyever changed the title [3/N] Import Callable from collections.abc in torch files [3/N] Import Callable from collections.abc in torch/distributed Sep 29, 2025
@cyyever cyyever requested review from ezyang and kwen2501 September 29, 2025 04:13
@cyyever cyyever added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 29, 2025
@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 29, 2025
@cyyever
Copy link
Collaborator Author

cyyever commented Sep 30, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever deleted the src_ruff_0352 branch September 30, 2025 01:01
@cyyever cyyever restored the src_ruff_0352 branch September 30, 2025 01:01
pytorchmergebot pushed a commit that referenced this pull request Oct 1, 2025
@cyyever cyyever deleted the src_ruff_0352 branch October 2, 2025 00:08
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/h100-symm-mem ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue open source release notes: distributed (checkpoint) release notes: distributed (fsdp) release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants