Skip to content

[4/N] Apply ruff UP035 rule to python code#164206

Closed
cyyever wants to merge 2 commits intopytorch:mainfrom
cyyever:up035_10
Closed

[4/N] Apply ruff UP035 rule to python code#164206
cyyever wants to merge 2 commits intopytorch:mainfrom
cyyever:up035_10

Conversation

@cyyever
Copy link
Collaborator

@cyyever cyyever commented Sep 30, 2025 •
edited
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 30, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164206

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 85b77b6 with merge base 2610746 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever marked this pull request as draft September 30, 2025 04:25
@pytorch-bot pytorch-bot bot added the release notes: quantization release notes category label Sep 30, 2025
@cyyever cyyever changed the title Apply ruff UP035 rule [4/N] Apply ruff UP035 rule Sep 30, 2025
@cyyever cyyever changed the title [4/N] Apply ruff UP035 rule [4/N] Apply ruff UP035 rule to torch python code Sep 30, 2025
@cyyever cyyever marked this pull request as ready for review September 30, 2025 08:16
@cyyever cyyever requested a review from Skylion007 September 30, 2025 08:17
@cyyever cyyever changed the title [4/N] Apply ruff UP035 rule to torch python code [4/N] Apply ruff UP035 rule to python code Sep 30, 2025
@cyyever
Apply ruff UP035 rule
8b16f82 
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
albanD
albanD approved these changes Oct 1, 2025
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@cyyever
Copy link
Collaborator Author

cyyever commented Oct 1, 2025

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 1, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 1, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever
Copy link
Collaborator Author

cyyever commented Oct 1, 2025

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 1, 2025

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 1, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever deleted the up035_10 branch October 2, 2025 00:01
@cyyever cyyever restored the up035_10 branch October 2, 2025 00:01
@cyyever cyyever deleted the up035_10 branch October 2, 2025 00:02
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
@cyyever @Chao1Han
[4/N] Apply ruff UP035 rule to python code (pytorch#164206)
be3909f 
Follows pytorch#164104

Pull Request resolved: pytorch#164206
Approved by: https://github.com/albanD
chenqi123 pushed a commit to chenqi123/torch_npu that referenced this pull request Oct 23, 2025
@dilililiwhy
TORCH MAIN SYNC : take collections.abc.Callable (Ruff UP035)
a424f06 
Co-authored-by: dilililiwhy<why.wuhuanyu@huawei.com>



# message auto-generated for no-merge-commit merge:
!25828 merge main_sync_20251017 into master

TORCH MAIN SYNC : take collections.abc.Callable (Ruff UP035)

Created-by: dilililiwhy
Commit-by: dilililiwhy
Merged-by: ascend-robot
Description: <!--  Thanks for sending a pull request! 
-->

**What type of PR is this?**
> Uncomment only one ` /kind <>` line, hit enter to put that in a new line, and remove leading whitespaces from that line:
>
> /kind bug
> /kind task
> /kind feature


**What does this PR do / why do we need it**:
2.10.0.dev20251015

**Which issue(s) this PR fixes**:
<!-- 
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-->
Fixes #

**Special notes for your reviewers**:
pytorch/pytorch#164206




See merge request: Ascend/pytorch!25828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@eqy eqy Awaiting requested review from eqy eqy is a code owner

@syed-ahmed syed-ahmed Awaiting requested review from syed-ahmed syed-ahmed is a code owner

@mikaylagawarecki mikaylagawarecki Awaiting requested review from mikaylagawarecki mikaylagawarecki is a code owner

@titaiwangms titaiwangms Awaiting requested review from titaiwangms titaiwangms is a code owner

@justinchuby justinchuby Awaiting requested review from justinchuby justinchuby is a code owner

@soulitzer soulitzer Awaiting requested review from soulitzer soulitzer is a code owner

@Skylion007 Skylion007 Awaiting requested review from Skylion007

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fx Merged open source release notes: quantization release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cyyever @pytorchmergebot @albanD @facebook-github-bot @pytorchbot