Skip to content

[2/N] Apply ruff UP035 check in torch files#164054

Closed
cyyever wants to merge 2 commits intopytorch:mainfrom
cyyever:src_ruff_035
Closed

[2/N] Apply ruff UP035 check in torch files#164054
cyyever wants to merge 2 commits intopytorch:mainfrom
cyyever:src_ruff_035

Conversation

@cyyever
Copy link
Collaborator

@cyyever cyyever commented Sep 28, 2025 •
edited
Loading

This is the result of applying the ruff UP035 check.
Callable is imported from collections.abc instead of typing.
TypeAlias is also imported from typing.
This PR is the follow-up of #163947.
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta @msaroufim @dcci @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @jerryzh168

@pytorch-bot pytorch-bot bot added module: cpu CPU specific problem (e.g., perf, algorithm) oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: foreach_frontend release notes category labels Sep 28, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 28, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164054

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9ec62a8 with merge base 8239ba4 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever changed the title Import Callable from collections.abc in torch files [1/N] Apply ruff UP035 check in torch files Sep 28, 2025
ezyang
ezyang reviewed Sep 28, 2025
View reviewed changes
@cyyever
Copy link
Collaborator Author

cyyever commented Sep 29, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 29, 2025
@cyyever
Copy link
Collaborator Author

cyyever commented Sep 29, 2025

@pytorchbot merge -r

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 29, 2025

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@cyyever @pytorchmergebot
Import Callable from collections.abc in torch files
548544e 
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
@cyyever @pytorchmergebot
Merge imports
9ec62a8 
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 29, 2025

Successfully rebased src_ruff_035 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout src_ruff_035 && git pull --rebase)

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 29, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever changed the title [1/N] Apply ruff UP035 check in torch files [2/N] Apply ruff UP035 check in torch files Sep 29, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 29, 2025

Merge failed

Reason: Commit 3179ff3 was HEAD when comment 3344466374 was posted but now the latest commit on the PR is 9ec62a8. Please re-issue the merge command to merge the latest commit.

Details for Dev Infra team Raised by workflow job

@cyyever
Copy link
Collaborator Author

cyyever commented Sep 29, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 29, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever mentioned this pull request Sep 29, 2025
Closed
pytorchmergebot pushed a commit that referenced this pull request Sep 30, 2025
@cyyever @pytorchmergebot
[3/N] Import Callable from collections.abc in torch/distributed (#164104
da003d7 
)

This is the result of applying the ruff `UP035` check.
`Callable` is imported from `collections.abc` instead of `typing`.
This PR is the follow-up of #164054.

Pull Request resolved: #164104
Approved by: https://github.com/Skylion007
@cyyever cyyever deleted the src_ruff_035 branch October 2, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@Skylion007 Skylion007 Skylion007 approved these changes

@aorenste aorenste Awaiting requested review from aorenste

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) oncall: distributed Add this issue/PR to distributed oncall triage queue open source release notes: foreach_frontend release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cyyever @pytorchmergebot @ezyang @Skylion007 @pytorchbot