Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163947
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 05aad9f with merge base 1cc9263 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
db474a7 to
0c8b627
Compare
albanD
reviewed
Sep 26, 2025
Collaborator
|
Some of these tests are explicitly to check that tracing through typing import Tuple and tuple typing work, if I recall it's some of the files that already import / use both. I'd be more comfortable applying this change on the root torch folder than the tests to start. |
ezyang
approved these changes
Sep 27, 2025
Collaborator
Author
|
@Skylion007 I have the same concern, let me revert the changes of fx and dynamo files. |
cebd792 to
4a47c5e
Compare
4a47c5e to
20062cb
Compare
20062cb to
9c6c6e4
Compare
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
9c6c6e4 to
05aad9f
Compare
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 29, 2025
This is the result of applying the ruff `UP035` check. `Callable` is imported from `collections.abc` instead of `typing`. `TypeAlias` is also imported from `typing`. This PR is the follow-up of #163947. Pull Request resolved: #164054 Approved by: https://github.com/ezyang, https://github.com/Skylion007
jainapurva
pushed a commit
that referenced
this pull request
Sep 29, 2025
Apply UP035 `ruff` rule in tests, but some tests for `fx` and `dynamo` are excluded in case the old typing is the test target. Pull Request resolved: #163947 Approved by: https://github.com/ezyang
maggiemoss
pushed a commit
to maggiemoss/pytorch
that referenced
this pull request
Sep 29, 2025
Apply UP035 `ruff` rule in tests, but some tests for `fx` and `dynamo` are excluded in case the old typing is the test target. Pull Request resolved: pytorch#163947 Approved by: https://github.com/ezyang
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply UP035
ruffrule in tests, but some tests forfxanddynamoare excluded in case the old typing is the test target.cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta @msaroufim @dcci @ezyang @EikanWang @jgong5 @wenzhe-nrv @voznesenskym @penguinwu @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @Lucaskabela