[AOTI] windows package load dev by xuhancn · Pull Request #158671 · pytorch/pytorch

xuhancn · 2025-07-18T20:09:43Z

changes:

add extract file fail handler for Windows develop.
normalize more file paths.

cc @peterjc123 @mszhanyi @skyline75489 @nbcsm @iremyux @Blackhex @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10

pytorch-bot · 2025-07-18T20:09:48Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158671

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

linux.aws.h100.8 instance is down, potentially longer queue on linux.aws.h100

✅ No Failures

As of commit 660372e with merge base 4060f30 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

xuhancn · 2025-07-18T20:32:38Z

@pytorchbot merge

pytorchmergebot · 2025-07-18T20:34:33Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

ZainRizvi · 2025-07-21T17:39:24Z

@pytorchbot revert -c ghfirst -m "Sorry but this is breaking internally. @angelayi can you please help them validate the fixes internally? You can follow the instructions here: https://fburl.com/fixing-ghfirst-reverts"

Relevant failure:

Error message:
Stderr:
.../torch/csrc/inductor/aoti_package/model_package_loader.cpp:439:15: error: use of undeclared identifier 'normalize_path_separator'
439 | temp_dir_ = normalize_path_separator(create_temp_dir());
| ^
.../torch/csrc/inductor/aoti_package/model_package_loader.cpp:472:25: error: use of undeclared identifier 'normalize_path_separator'
472 | output_path_str = normalize_path_separator(output_path_str);
| ^
2 errors generated.

pytorchmergebot · 2025-07-21T17:41:07Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot · 2025-07-21T17:41:20Z

Reverting PR 158671 failed

Reason: Command git -C /home/runner/work/pytorch/pytorch revert --no-edit d42c40976727fed4c9908d4194f26917d0a3da66 returned non-zero exit code 1

Auto-merging torch/csrc/inductor/aoti_package/model_package_loader.cpp
CONFLICT (content): Merge conflict in torch/csrc/inductor/aoti_package/model_package_loader.cpp
error: could not revert d42c4097672... [AOTI] windows package load dev (#158671)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git revert --continue".
hint: You can instead skip this commit with "git revert --skip".
hint: To abort and get back to the state before "git revert",
hint: run "git revert --abort".
hint: Disable this message with "git config set advice.mergeConflict false"

Details for Dev Infra team

Raised by workflow job

…)" This reverts commit 8ed5e18. Reverted #158687 on behalf of https://github.com/ZainRizvi due to Sorry but I had to revert this PR in order to revert #158671 ([comment](#158687 (comment)))

Attempts to fix a memory leak reported in #158614 by wrapping manually managed MiniZ C-structs in an RAII container. I have been unable to reproduce the reported leak, but this seems like the most likely candidate. Fixes #158614 (hopefully) Pull Request resolved: #158687 Approved by: https://github.com/desertfire

This reverts commit ff0da08. Reverted #158705 on behalf of https://github.com/ZainRizvi due to Sorry but I had to revert this PR in order to revert #158671 ([comment](#158705 (comment)))

Continued to #158702 , split `zip_filename_str` and real file path. Pull Request resolved: #158705 Approved by: https://github.com/desertfire

This reverts commit 7cc1a95. Reverted #158702 on behalf of https://github.com/ZainRizvi due to Sorry but I had to revert this PR in order to revert #158671 ([comment](#158702 (comment)))

pytorchmergebot · 2025-07-21T22:20:50Z

@xuhancn your PR has been successfully reverted.

xuhancn · 2025-07-22T07:52:15Z

@desertfire could you please help on import this PR to fbcode? I guess the failure is caused by fbcode not synced.

facebook-github-bot · 2025-07-22T15:24:08Z

@angelayi has imported this pull request. If you are a Meta employee, you can view this in D78742921.

xuhancn · 2025-07-22T16:37:36Z

Hi @angelayi the code is confilict due to the PR: #158687 , so I did the rebase. Is that need to import again?

facebook-github-bot · 2025-07-22T17:31:45Z

@angelayi has imported this pull request. If you are a Meta employee, you can view this in D78742921.

angelayi · 2025-07-22T18:19:32Z

Internal seems to be doing fine, so feel free to merge whenever CI finishes!

xuhancn · 2025-07-22T18:22:10Z

Internal seems to be doing fine, so feel free to merge whenever CI finishes!

Cool, could you please trigger merge? @angelayi

xuhancn · 2025-07-22T21:28:26Z

@pytorchmergebot merge

pytorchmergebot · 2025-07-22T21:30:22Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

…ch#158687)" This reverts commit 8ed5e18. Reverted pytorch#158687 on behalf of https://github.com/ZainRizvi due to Sorry but I had to revert this PR in order to revert pytorch#158671 ([comment](pytorch#158687 (comment)))

This reverts commit ff0da08. Reverted pytorch#158705 on behalf of https://github.com/ZainRizvi due to Sorry but I had to revert this PR in order to revert pytorch#158671 ([comment](pytorch#158705 (comment)))

This reverts commit 7cc1a95. Reverted pytorch#158702 on behalf of https://github.com/ZainRizvi due to Sorry but I had to revert this PR in order to revert pytorch#158671 ([comment](pytorch#158702 (comment)))

@angelayi

This reverts commit d42c409. Reverted pytorch#158671 on behalf of https://github.com/ZainRizvi due to Sorry but this is breaking internally. @angelayi can you please help them validate the fixes internally? You can follow the instructions here: https://fburl.com/fixing-ghfirst-reverts ([comment](pytorch#158671 (comment)))

xuhancn requested a review from angelayi July 18, 2025 20:09

xuhancn added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Jul 18, 2025

pytorch-bot bot added ciflow/inductor release notes: inductor (aoti) labels Jul 18, 2025

xuhancn marked this pull request as ready for review July 18, 2025 20:09

angelayi approved these changes Jul 18, 2025

View reviewed changes

pytorchbot added the open source label Jul 18, 2025

xuhancn added module: windows Windows support for PyTorch intel This tag is for PR from Intel labels Jul 18, 2025

pytorchmergebot added the merging label Jul 18, 2025

pytorchmergebot added the Merged label Jul 19, 2025

pytorchmergebot closed this in d42c409 Jul 19, 2025

pytorchmergebot removed the merging label Jul 19, 2025

xuhancn deleted the xu_windows_package_load_dev branch July 19, 2025 08:42

ZainRizvi mentioned this pull request Jul 21, 2025

[AOTI] Convert C-struct zip handling to RAII container #158687

Closed

ZainRizvi mentioned this pull request Jul 21, 2025

[AOTI] normalize path and process model files. #158705

Closed

pytorchmergebot referenced this pull request Jul 21, 2025

[AOTI] normalize path and process model files. (#158705)

ff0da08

Continued to #158702 , split `zip_filename_str` and real file path. Pull Request resolved: #158705 Approved by: https://github.com/desertfire

ZainRizvi mentioned this pull request Jul 21, 2025

[AOTI] fix extract file failed on Windows. #158702

Closed

pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Jul 21, 2025

xuhancn restored the xu_windows_package_load_dev branch July 22, 2025 00:22

xuhancn reopened this Jul 22, 2025

xuhancn added 2 commits July 22, 2025 08:25

add extract file fail handler for Windows develop.

b819e8b

normalize more file paths.

8ff97b6

xuhancn force-pushed the xu_windows_package_load_dev branch from 65f9d1f to 8ff97b6 Compare July 22, 2025 00:29

optimize code.

0c256f0

xuhancn requested a review from desertfire July 22, 2025 07:53

xuhancn added 2 commits July 23, 2025 00:11

Merge branch 'main' into xu_windows_package_load_dev

d4e1b29

rebase code to PR_158687

660372e

desertfire approved these changes Jul 22, 2025

View reviewed changes

pytorchmergebot added the merging label Jul 22, 2025

pytorchmergebot closed this in a626dc8 Jul 22, 2025

pytorchmergebot removed the merging label Jul 22, 2025

xuhancn deleted the xu_windows_package_load_dev branch July 22, 2025 21:38

Conversation

xuhancn commented Jul 18, 2025 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158671

❗ 1 Active SEVs

✅ No Failures

Uh oh!

xuhancn commented Jul 18, 2025

Uh oh!

pytorchmergebot commented Jul 18, 2025

Merge started

Uh oh!

ZainRizvi commented Jul 21, 2025

Uh oh!

pytorchmergebot commented Jul 21, 2025

Uh oh!

pytorchmergebot commented Jul 21, 2025

Reverting PR 158671 failed

Uh oh!

pytorchmergebot commented Jul 21, 2025

Uh oh!

xuhancn commented Jul 22, 2025

Uh oh!

facebook-github-bot commented Jul 22, 2025

Uh oh!

xuhancn commented Jul 22, 2025

Uh oh!

facebook-github-bot commented Jul 22, 2025

Uh oh!

angelayi commented Jul 22, 2025

Uh oh!

xuhancn commented Jul 22, 2025

Uh oh!

xuhancn commented Jul 22, 2025

Uh oh!

pytorchmergebot commented Jul 22, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

xuhancn commented Jul 18, 2025 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Jul 18, 2025 •

edited

Loading