Skip to content

[AOTI] Convert C-struct zip handling to RAII container#158687

Closed
benjaminglass1 wants to merge 3 commits intogh/benjaminglass1/96/basefrom
gh/benjaminglass1/96/head
Closed

[AOTI] Convert C-struct zip handling to RAII container#158687
benjaminglass1 wants to merge 3 commits intogh/benjaminglass1/96/basefrom
gh/benjaminglass1/96/head

Conversation

@benjaminglass1
Copy link
Collaborator

@benjaminglass1 benjaminglass1 commented Jul 18, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Attempts to fix a memory leak reported in #158614 by wrapping manually managed MiniZ C-structs in an RAII container. I have been unable to reproduce the reported leak, but this seems like the most likely candidate.

Fixes #158614 (hopefully)

@benjaminglass1
Update
fd2830c 
[ghstack-poisoned]
@benjaminglass1 benjaminglass1 mentioned this pull request Jul 18, 2025
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 18, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158687

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 7 Unrelated Failures

As of commit 05eaa73 with merge base feaa02f (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

benjaminglass1 added a commit that referenced this pull request Jul 18, 2025
@benjaminglass1
[AOTI] Convert C-struct zip handling to RAII container
5c7a3ba 
Attempts to fix a memory leak reported in #158614 by wrapping manually managed MiniZ C-structs in an RAII container. I have been unable to reproduce the reported leak, but this seems like the most likely candidate.

Fixes #158614 (hopefully)

ghstack-source-id: f20aa19
Pull Request resolved: #158687
@benjaminglass1 benjaminglass1 mentioned this pull request Jul 18, 2025
Closed
benjaminglass1
benjaminglass1 commented Jul 18, 2025
View reviewed changes
@benjaminglass1 benjaminglass1 self-assigned this Jul 18, 2025
@benjaminglass1 benjaminglass1 marked this pull request as ready for review July 18, 2025 22:26
desertfire
desertfire approved these changes Jul 21, 2025
View reviewed changes
Copy link
Contributor

@desertfire desertfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix. There is a merge conflict to be resolved.

@benjaminglass1
Update
6b392fb 
[ghstack-poisoned]
@benjaminglass1
Copy link
Collaborator Author

benjaminglass1 commented Jul 21, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 21, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 21, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@ZainRizvi
Copy link
Contributor

ZainRizvi commented Jul 21, 2025

@pytorchbot revert -c ghfirst -m "Sorry but I had to revert this PR in order to revert #158671"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 21, 2025

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 21, 2025

@benjaminglass1 your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Jul 21, 2025
@pytorchmergebot
Revert "[AOTI] Convert C-struct zip handling to RAII container (#158687…
97d7dc1 
…)"

This reverts commit 8ed5e18.

Reverted #158687 on behalf of https://github.com/ZainRizvi due to Sorry but I had to revert this PR in order to revert #158671 ([comment](#158687 (comment)))
@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Jul 21, 2025
@benjaminglass1
Update
05eaa73 
[ghstack-poisoned]
@benjaminglass1
Copy link
Collaborator Author

benjaminglass1 commented Jul 21, 2025

Rebased out merge conflicts with reverted code, and merging again.

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 21, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 22, 2025

Merge failed

Reason: 1 jobs have failed, first few of them are: inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (cpu_inductor_torchbench, 1, 2, linux.8xlarge.amx)

Details for Dev Infra team Raised by workflow job

@benjaminglass1
Copy link
Collaborator Author

benjaminglass1 commented Jul 22, 2025

@pytorchbot merge -i

Failures are unrelated.

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 22, 2025

Merge started

Your change will be merged while ignoring the following 8 checks: trunk / verify-cachebench-cpu-test / test (verify_cachebench, 1, 1, linux.2xlarge), trunk / linux-jammy-rocm-py3.10 / test (distributed, 1, 1, linux.rocm.gpu.4), inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (cpu_inductor_torchbench, 1, 2, linux.8xlarge.amx), inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (dynamic_cpu_inductor_torchbench, 1, 2, linux.8xlarge.amx), inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (dynamic_cpu_inductor_torchbench, 2, 2, linux.8xlarge.amx), inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (cpu_inductor_torchbench, 2, 2, linux.8xlarge.amx), inductor / cuda12.8-py3.10-gcc9-sm86 / test (inductor_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu), inductor / cuda12.8-py3.10-gcc9-sm86 / test (inductor_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@xuhancn xuhancn mentioned this pull request Jul 22, 2025
Closed
saienduri pushed a commit to saienduri/pytorch that referenced this pull request Jul 22, 2025
@pytorchmergebot @saienduri
Revert "[AOTI] Convert C-struct zip handling to RAII container (pytor…
e24ed6e 
…ch#158687)"

This reverts commit 8ed5e18.

Reverted pytorch#158687 on behalf of https://github.com/ZainRizvi due to Sorry but I had to revert this PR in order to revert pytorch#158671 ([comment](pytorch#158687 (comment)))
@github-actions github-actions bot deleted the gh/benjaminglass1/96/head branch August 22, 2025 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@desertfire desertfire desertfire approved these changes

Assignees

@benjaminglass1 benjaminglass1

Labels

ci-no-td Do not run TD on this PR ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: inductor (aoti) Reverted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@benjaminglass1 @pytorchmergebot @ZainRizvi @desertfire @pytorchbot