Skip to content

[AOTI] fix extract file failed on Windows.#158702

Closed
xuhancn wants to merge 6 commits intopytorch:mainfrom
xuhancn:xu_fix_extract_file_on_win32
Closed

[AOTI] fix extract file failed on Windows.#158702
xuhancn wants to merge 6 commits intopytorch:mainfrom
xuhancn:xu_fix_extract_file_on_win32

Conversation

@xuhancn
Copy link
Collaborator

@xuhancn xuhancn commented Jul 19, 2025 •
edited
Loading

Changes:

  1. rename zip index filename, and keep it out of normalize path.
  2. normalize output path for extract file.

Extract files successful:
image

cc @peterjc123 @mszhanyi @skyline75489 @nbcsm @iremyux @Blackhex @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10

@xuhancn xuhancn added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Jul 19, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 19, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158702

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (1 Unrelated Failure)

As of commit 0b904fd with merge base f10e443 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@xuhancn xuhancn changed the title fix zip index filename. [AOTI] fix extract file failed on Windows. Jul 19, 2025
@xuhancn xuhancn added module: windows Windows support for PyTorch intel This tag is for PR from Intel labels Jul 19, 2025
@xuhancn xuhancn requested review from angelayi and desertfire July 19, 2025 06:02
@xuhancn xuhancn marked this pull request as ready for review July 19, 2025 06:04
@xuhancn xuhancn requested a review from jansel July 19, 2025 06:04
@xuhancn
Copy link
Collaborator Author

xuhancn commented Jul 19, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 19, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@xuhancn xuhancn deleted the xu_fix_extract_file_on_win32 branch July 19, 2025 09:04
@xuhancn xuhancn mentioned this pull request Jul 19, 2025
Closed
pytorchmergebot pushed a commit that referenced this pull request Jul 21, 2025
@xuhancn @pytorchmergebot
[AOTI] normalize path and process model files. (#158705)
ff0da08 
Continued to #158702 , split `zip_filename_str` and real file path.

Pull Request resolved: #158705
Approved by: https://github.com/desertfire
@ZainRizvi
Copy link
Contributor

ZainRizvi commented Jul 21, 2025

@pytorchbot revert -c ghfirst -m "Sorry but I had to revert this PR in order to revert #158671"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 21, 2025

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Jul 21, 2025
@pytorchmergebot
Revert "[AOTI] fix extract file failed on Windows. (#158702)"
5a56e6a 
This reverts commit 7cc1a95.

Reverted #158702 on behalf of https://github.com/ZainRizvi due to Sorry but I had to revert this PR in order to revert #158671 ([comment](#158702 (comment)))
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 21, 2025

@xuhancn your PR has been successfully reverted.

@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Jul 21, 2025
@xuhancn xuhancn restored the xu_fix_extract_file_on_win32 branch July 22, 2025 00:34
@xuhancn xuhancn reopened this Jul 22, 2025
saienduri pushed a commit to saienduri/pytorch that referenced this pull request Jul 22, 2025
@pytorchmergebot @saienduri
Revert "[AOTI] fix extract file failed on Windows. (pytorch#158702)"
949c54e 
This reverts commit 7cc1a95.

Reverted pytorch#158702 on behalf of https://github.com/ZainRizvi due to Sorry but I had to revert this PR in order to revert pytorch#158671 ([comment](pytorch#158702 (comment)))
pytorchmergebot pushed a commit that referenced this pull request Jul 23, 2025
@xuhancn @pytorchmergebot
[AOTI] normalize path and process model files. (#158705)
f10e443 
Continued to #158702 , split `zip_filename_str` and real file path.

Pull Request resolved: #158705
Approved by: https://github.com/desertfire
@xuhancn
Copy link
Collaborator Author

xuhancn commented Jul 23, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 23, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@xuhancn xuhancn deleted the xu_fix_extract_file_on_win32 branch July 23, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@angelayi angelayi angelayi approved these changes

@desertfire desertfire Awaiting requested review from desertfire

@jansel jansel Awaiting requested review from jansel

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request intel This tag is for PR from Intel Merged module: windows Windows support for PyTorch open source release notes: inductor (aoti) Reverted topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xuhancn @pytorchmergebot @ZainRizvi @angelayi @pytorchbot