[build] remove `wheel` from build requirements by XuehaiPan · Pull Request #158027 · pytorch/pytorch

XuehaiPan · 2025-07-10T14:19:17Z

Stack from ghstack (oldest at bottom):

cc @malfet @seemethere

[ghstack-poisoned]

pytorch-bot · 2025-07-10T14:19:22Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158027

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 4623427 with merge base 7f14b42 ():

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

pull / cuda12.8-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu, unstable) (gh) (#153987)
MISSING REGRESSION TEST

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Skylion007 · 2025-07-10T14:20:57Z

pyproject.toml

    # 70.1.0: min version for integrated bdist_wheel command from wheel package
    # 77.0.0: min version for SPDX expression support for project.license
    "setuptools>=70.1.0",
-    "wheel",


Are we sure, we don't test with build isolation... I think this might have been an issue with uv, but I forget.

The previous PR in the stack:

[build] pin setuptools>=70.1.0 for integrated bdist_wheel command #157783

replaces wheel.bdist_wheel.bdist_wheel with setuptools.command.bdist_wheel.bdist_wheel.

[ghstack-poisoned]

ghstack-source-id: 5545698 Pull-Request: #158027

[ghstack-poisoned]

requirements.txt

[ghstack-poisoned]

XuehaiPan · 2025-07-12T11:29:34Z

@pytorchbot merge

pytorchmergebot · 2025-07-12T11:31:58Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

ghstack-source-id: b6f1a88 Pull-Request: pytorch#158027

Skylion007 · 2025-07-12T15:45:51Z

requirements.txt

 psutil
 sympy>=1.13.3
 typing-extensions>=4.13.2
+wheel


Why is it needed here for generic requirements?

It is a development dependency:

pytorch/.ci/docker/common/install_cpython.sh

Lines 69 to 71 in 9508d73

${prefix}/bin/pip install wheel==0.45.1 setuptools==80.9.0

local abi_tag=$(${prefix}/bin/python -c "from wheel.pep425tags import get_abbr_impl, get_impl_ver, get_abi_tag; print('{0}{1}-{2}'.format(get_abbr_impl(), get_impl_ver(), get_abi_tag()))")

ln -sf ${prefix} /opt/python/${abi_tag}

pytorch/tools/nightly.py

Lines 584 to 608 in 9508d73

@timed("Unpacking wheel file")

def wheel_unpack(

self,

wheel: Path | str,

dest: Path | str,

**popen_kwargs: Any,

) -> subprocess.CompletedProcess[str]:

"""Unpack a wheel into a directory."""

wheel = Path(wheel).absolute()

dest = Path(dest).absolute()

assert wheel.is_file() and wheel.suffix.lower() == ".whl"

return self.wheel("unpack", f"--dest={dest}", str(wheel), **popen_kwargs)

@contextlib.contextmanager

def extracted_wheel(self, wheel: Path | str) -> Generator[Path]:

"""Download and extract a wheel into a temporary directory."""

with tempfile.TemporaryDirectory(prefix="wheel-") as tempdir:

self.wheel_unpack(wheel, tempdir)

subdirs = [p for p in Path(tempdir).absolute().iterdir() if p.is_dir()]

if len(subdirs) != 1:

raise RuntimeError(

f"Expected exactly one directory in {tempdir}, "

f"got {[str(d) for d in subdirs]}."

)

yield subdirs[0]

Update

5e6b575

[ghstack-poisoned]

XuehaiPan requested a review from jeffdaily as a code owner July 10, 2025 14:19

pytorch-bot bot added the topic: not user facing topic category label Jul 10, 2025

This was referenced Jul 10, 2025

[build] bootstrap git repo for build for non-git-clone archive #157432

Closed

[build] remove upper version pin for setuptools<80.0 #156049

Closed

[build] pin setuptools>=70.1.0 for integrated bdist_wheel command #157783

Closed

Skylion007 reviewed Jul 10, 2025

View reviewed changes

pytorchbot added the open source label Jul 10, 2025

Update

571c387

[ghstack-poisoned]

Update

77633ed

[ghstack-poisoned]

XuehaiPan added a commit that referenced this pull request Jul 10, 2025

[build] remove wheel from build requirements

f4ec7aa

ghstack-source-id: 5545698 Pull-Request: #158027

Update

b11ab1b

[ghstack-poisoned]

Update

0bac530

[ghstack-poisoned]

XuehaiPan mentioned this pull request Jul 11, 2025

[build] pin setuptools>=77 to enable PEP 639 #158104

Open

Update

d9664f6

[ghstack-poisoned]

XuehaiPan mentioned this pull request Jul 11, 2025

[BE][Easy] split build system requirements.txt to a separate file #158111

Closed

XuehaiPan requested a review from Skylion007 July 11, 2025 16:34

Skylion007 approved these changes Jul 11, 2025

View reviewed changes

Skylion007 reviewed Jul 11, 2025

View reviewed changes

requirements.txt Show resolved Hide resolved

Update

4623427

[ghstack-poisoned]

pytorchmergebot added the merging label Jul 12, 2025

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 12, 2025

[build] remove wheel from build requirements

f27e627

ghstack-source-id: b6f1a88 Pull-Request: pytorch#158027

Skylion007 reviewed Jul 12, 2025

View reviewed changes

pytorchmergebot added the Merged label Jul 12, 2025

pytorchmergebot closed this in a0308ed Jul 12, 2025

pytorchmergebot removed the merging label Jul 12, 2025

github-actions bot deleted the gh/XuehaiPan/364/head branch August 12, 2025 02:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[build] remove `wheel` from build requirements#158027

[build] remove `wheel` from build requirements#158027
XuehaiPan wants to merge 7 commits intogh/XuehaiPan/364/basefrom
gh/XuehaiPan/364/head

XuehaiPan commented Jul 10, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Jul 10, 2025 •

edited

Loading

Uh oh!

Skylion007 Jul 10, 2025

Uh oh!

XuehaiPan Jul 10, 2025

Uh oh!

Uh oh!

XuehaiPan commented Jul 12, 2025

Uh oh!

pytorchmergebot commented Jul 12, 2025

Uh oh!

Skylion007 Jul 12, 2025

Uh oh!

XuehaiPan Jul 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	${prefix}/bin/pip install wheel==0.45.1 setuptools==80.9.0
	local abi_tag=$(${prefix}/bin/python -c "from wheel.pep425tags import get_abbr_impl, get_impl_ver, get_abi_tag; print('{0}{1}-{2}'.format(get_abbr_impl(), get_impl_ver(), get_abi_tag()))")
	ln -sf ${prefix} /opt/python/${abi_tag}

	@timed("Unpacking wheel file")
	def wheel_unpack(
	self,
	wheel: Path \| str,
	dest: Path \| str,
	**popen_kwargs: Any,
	) -> subprocess.CompletedProcess[str]:
	"""Unpack a wheel into a directory."""
	wheel = Path(wheel).absolute()
	dest = Path(dest).absolute()
	assert wheel.is_file() and wheel.suffix.lower() == ".whl"
	return self.wheel("unpack", f"--dest={dest}", str(wheel), **popen_kwargs)

	@contextlib.contextmanager
	def extracted_wheel(self, wheel: Path \| str) -> Generator[Path]:
	"""Download and extract a wheel into a temporary directory."""
	with tempfile.TemporaryDirectory(prefix="wheel-") as tempdir:
	self.wheel_unpack(wheel, tempdir)
	subdirs = [p for p in Path(tempdir).absolute().iterdir() if p.is_dir()]
	if len(subdirs) != 1:
	raise RuntimeError(
	f"Expected exactly one directory in {tempdir}, "
	f"got {[str(d) for d in subdirs]}."
	)
	yield subdirs[0]

Conversation

XuehaiPan commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158027

✅ You can merge normally! (1 Unrelated Failure)

Uh oh!

Skylion007 Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

XuehaiPan Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

XuehaiPan commented Jul 12, 2025

Uh oh!

pytorchmergebot commented Jul 12, 2025

Merge started

Uh oh!

Skylion007 Jul 12, 2025

Choose a reason for hiding this comment

Uh oh!

XuehaiPan Jul 12, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

XuehaiPan commented Jul 10, 2025 •

edited

Loading

pytorch-bot bot commented Jul 10, 2025 •

edited

Loading