[AOTI] Fix AOT inductor CMake build dependency order#157557
Closed
XuehaiPan wants to merge 7 commits intogh/XuehaiPan/349/basefrom
Closed
[AOTI] Fix AOT inductor CMake build dependency order#157557XuehaiPan wants to merge 7 commits intogh/XuehaiPan/349/basefrom
XuehaiPan wants to merge 7 commits intogh/XuehaiPan/349/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157557
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 05226ef with merge base a6fab82 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Skylion007
approved these changes
Jul 3, 2025
This was referenced Jul 3, 2025
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 3, 2025
compile_model.py -> aoti_custom_class -> torch See also: - https://github.com/pytorch/pytorch/actions/runs/16041370426/job/45275085572#step:22:18348 ghstack-source-id: 8292212 Pull-Request: pytorch#157557
cyyever
approved these changes
Jul 4, 2025
Collaborator
Author
|
The fix does not work. |
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 4, 2025
compile_model.py -> aoti_custom_class -> torch See also: - https://github.com/pytorch/pytorch/actions/runs/16041370426/job/45275085572#step:22:18348 ghstack-source-id: 23dbc44 Pull-Request: pytorch#157557
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Jul 4, 2025
…> `setuptools.build_meta` (#155998) Change `build-system.build-backend`: `setuptools.build_meta:__legacy__` -> `setuptools.build_meta`. Also, move static package info from `setup.py` to `pyproject.toml`. Now the repo can be installed from source via `pip` command instead of `python setup.py develop`: ```bash python -m pip install --verbose --editable . python -m pip install --verbose --no-build-isolation --editable . ``` In addition, the SDist is also buildable: ```bash python -m build --sdist python -m install dist/torch-*.tar.gz # build from source using SDist ``` Note that we should build the SDist with a fresh git clone if we will upload the output to PyPI. Because all files under `third_party` will be included in the SDist. The SDist file will be huge if the git submodules are initialized. Pull Request resolved: #155998 Approved by: https://github.com/ezyang, https://github.com/cyyever, https://github.com/atalman ghstack dependencies: #157557
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
setuptools<80.0#156049python setup.py develop/install->[uv ]pip install --no-build-isolation [-e ].#156027setuptools.build_meta:__legacy__->setuptools.build_meta#155998compile_model.py -> aoti_custom_class -> torch
The custom command requires
torchto be installed.pytorch/test/cpp/aoti_inference/compile_model.py
Lines 1 to 7 in 8408522
Fixes CI failure on trunk:
cc @desertfire @chenyang78 @penguinwu @yushangdi @benjaminglass1