Skip to content

Replace setup.py install with pip install#156711

Closed
zklaus wants to merge 29 commits intogh/zklaus/10/basefrom
gh/zklaus/10/head
Closed

Replace setup.py install with pip install#156711
zklaus wants to merge 29 commits intogh/zklaus/10/basefrom
gh/zklaus/10/head

Conversation

@zklaus
Copy link
Copy Markdown
Collaborator

@zklaus zklaus commented Jun 24, 2025 •
edited
Loading

#156027 already replaced most use of python setup.py install.
This PR only adds a few more occurrences and adds --no-build-isolation in a few places.

Stack from ghstack (oldest at bottom):

@zklaus
Update
845d8a6 
[ghstack-poisoned]
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Jun 24, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156711

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures

As of commit 0e52f5e with merge base e64dd8c (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Jun 24, 2025
This was referenced Jun 24, 2025
Closed
Closed
Closed
Closed
zklaus added 4 commits June 25, 2025 14:24
@zklaus
Update
c1a9c37 
[ghstack-poisoned]
@zklaus
Update
3069cca 
[ghstack-poisoned]
@zklaus
Update
3f7f9d8 
[ghstack-poisoned]
@zklaus
Update
dece4b3 
[ghstack-poisoned]
@zklaus zklaus marked this pull request as ready for review August 11, 2025 15:24
@zklaus zklaus requested a review from a team as a code owner August 11, 2025 15:24
zklaus added 3 commits August 11, 2025 18:18
@zklaus
Update
27a5e16 
[ghstack-poisoned]
@zklaus
Update
b35cfdd 
[ghstack-poisoned]
@zklaus
Update
0609945 
[ghstack-poisoned]
@zklaus zklaus mentioned this pull request Sep 2, 2025
Closed
@atalman atalman added ciflow/trunk Trigger trunk jobs on your pull request ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR ciflow/binaries_libtorch Trigger binary build and upload jobs for libtorch on the PR labels Sep 2, 2025
@zklaus
Update
420173b 
[ghstack-poisoned]
@zklaus
Update
abae495 
[ghstack-poisoned]
@zklaus
Update
1e35a96 
[ghstack-poisoned]
@zklaus
Update
6644e2f 
[ghstack-poisoned]
@zklaus
Update
17a17b4 
[ghstack-poisoned]
@zklaus
Update
939c230 
[ghstack-poisoned]
@zklaus
Update
f6a308a 
[ghstack-poisoned]
@zklaus
Update
26b7c23 
[ghstack-poisoned]
@zklaus
Update
ec8064a 
[ghstack-poisoned]
@zklaus
Update
b6dc0d2 
[ghstack-poisoned]
@zklaus
Update
fce40ba 
[ghstack-poisoned]
@zklaus
Update
2d78018 
[ghstack-poisoned]
@zklaus
Update
424fcec 
[ghstack-poisoned]
@zklaus
Update
2cadd76 
[ghstack-poisoned]
@zklaus
Update
47fa877 
[ghstack-poisoned]
@zklaus
Update
816d9b9 
[ghstack-poisoned]
@zklaus
Update
d573304 
[ghstack-poisoned]
@zklaus zklaus requested a review from atalman September 25, 2025 17:08
atalman
atalman approved these changes Sep 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atalman atalman mentioned this pull request Sep 26, 2025
Closed
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 26, 2025

Starting merge as part of PR stack under #156712

@zklaus
Update
257ee86 
[ghstack-poisoned]
@zklaus
Update
4720d25 
[ghstack-poisoned]
@zklaus
Update
06d9478 
[ghstack-poisoned]
@zklaus
Update
0e52f5e 
[ghstack-poisoned]
@zklaus
Copy link
Copy Markdown
Collaborator Author

zklaus commented Sep 29, 2025

@pytorchbot merge "The manywheel-...-rocm7_0-test failures are unrelated."

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Sep 29, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: The `manywheel-...-rocm7_0-test` failures are unrelated.

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick} ...

Try @pytorchbot --help for more info.

@zklaus
Copy link
Copy Markdown
Collaborator Author

zklaus commented Sep 29, 2025

@pytorchbot merge -f "The manywheel-...-rocm7_0-test failures are unrelated."

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 29, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Sep 29, 2025
@zklaus @pytorchmergebot
Replace setup.py bdist_wheel with python -m build --wheel (#156712)
50d418f 
Previously we already replaced most use of `python setup.py develop/install`.

This PR also replaces the use of `setup.py bdist_wheel` with the modern `python -m build --wheel` alternative.

Pull Request resolved: #156712
Approved by: https://github.com/atalman
ghstack dependencies: #156711
@github-actions github-actions bot deleted the gh/zklaus/10/head branch October 30, 2025 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atalman atalman atalman approved these changes

Assignees

No one assigned

Labels

ciflow/binaries_libtorch Trigger binary build and upload jobs for libtorch on the PR ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: onnx torch.onnx related changes that should show up in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zklaus @pytorchmergebot @atalman @pytorchbot