Skip to content

Replace setup.py bdist_wheel with python -m build --wheel#156712

Closed
zklaus wants to merge 34 commits intogh/zklaus/11/basefrom
gh/zklaus/11/head
Closed

Replace setup.py bdist_wheel with python -m build --wheel#156712
zklaus wants to merge 34 commits intogh/zklaus/11/basefrom
gh/zklaus/11/head

Conversation

@zklaus
Copy link
Copy Markdown
Collaborator

@zklaus zklaus commented Jun 24, 2025 •
edited
Loading

Previously we already replaced most use of python setup.py develop/install.

This PR also replaces the use of setup.py bdist_wheel with the modern python -m build --wheel alternative.

Stack from ghstack (oldest at bottom):

@zklaus
Update
939ad21 
[ghstack-poisoned]
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Jun 24, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156712

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures

As of commit 517410c with merge base e64dd8c (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: releng release notes category label Jun 24, 2025
This was referenced Jun 24, 2025
Closed
Closed
Closed
Closed
@zklaus
Update
33fb2c2 
[ghstack-poisoned]
zklaus added a commit to zklaus/pytorch that referenced this pull request Jun 25, 2025
@zklaus
Replace setup.py bdist_wheel with python -m build --wheel
eeebf28 
ghstack-source-id: 21ed131
Pull Request resolved: pytorch#156712
@zklaus zklaus mentioned this pull request Jul 9, 2025
Closed
zklaus added 3 commits August 11, 2025 13:00
@zklaus
Update
c178d79 
[ghstack-poisoned]
@zklaus
Update
e83e9c1 
[ghstack-poisoned]
@zklaus
Update
63ea1f6 
[ghstack-poisoned]
XuehaiPan
XuehaiPan reviewed Aug 11, 2025
View reviewed changes
XuehaiPan
XuehaiPan reviewed Aug 11, 2025
View reviewed changes
zklaus added 2 commits August 11, 2025 18:18
@zklaus
Update
5e3db77 
[ghstack-poisoned]
@zklaus
Update
b11c3ac 
[ghstack-poisoned]
@atalman atalman added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Aug 12, 2025
@atalman
Copy link
Copy Markdown
Contributor

atalman commented Aug 12, 2025

@zklaus one way of approaching this is to break it into parts: Linux, MacOS and Windows. We also need to test binary builds with these changes, attached ciflow/binaries

@atalman atalman mentioned this pull request Sep 1, 2025
Closed
@zklaus
Update
67b0ae3 
[ghstack-poisoned]
@zklaus zklaus mentioned this pull request Sep 2, 2025
Closed
@zklaus
Update
48c64f5 
[ghstack-poisoned]
@atalman atalman added this to the 2.10.0 milestone Sep 2, 2025
@zklaus
Update
0d24d90 
[ghstack-poisoned]
@zklaus
Update
eb894e8 
[ghstack-poisoned]
@zklaus
Update
d10e307 
[ghstack-poisoned]
@zklaus
Update
5039e8f 
[ghstack-poisoned]
zklaus added a commit that referenced this pull request Sep 8, 2025
@zklaus
Replace setup.py bdist_wheel with python -m build --wheel
a586802 
ghstack-source-id: 4f6c1bd
Pull Request resolved: #156712
@zklaus
Update
a0b62b6 
[ghstack-poisoned]
zklaus added a commit that referenced this pull request Sep 28, 2025
@zklaus
Replace setup.py bdist_wheel with python -m build --wheel
aef997f 
ghstack-source-id: 62a0d8a
Pull Request resolved: #156712
@zklaus
Update
da6c09f 
[ghstack-poisoned]
zklaus added a commit that referenced this pull request Sep 29, 2025
@zklaus
Replace setup.py bdist_wheel with python -m build --wheel
8c1fe7f 
ghstack-source-id: 5c99ad3
Pull Request resolved: #156712
@zklaus
Update
ae6d3b6 
[ghstack-poisoned]
zklaus added a commit that referenced this pull request Sep 29, 2025
@zklaus
Replace setup.py bdist_wheel with python -m build --wheel
784e504 
ghstack-source-id: 4b4cd6c
Pull Request resolved: #156712
@zklaus
Update
517410c 
[ghstack-poisoned]
zklaus added a commit that referenced this pull request Sep 29, 2025
@zklaus
Replace setup.py bdist_wheel with python -m build --wheel
f0ffb96 
ghstack-source-id: 902ddf4
Pull Request resolved: #156712
@zklaus
Copy link
Copy Markdown
Collaborator Author

zklaus commented Sep 29, 2025

@pytorchbot merge -i

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 29, 2025

Merge started

Your change will be merged while ignoring the following 7 checks: linux-binary-manywheel / manywheel-py3_11-rocm7_0-test, linux-binary-manywheel / manywheel-py3_12-rocm7_0-test, linux-binary-manywheel / manywheel-py3_10-rocm7_0-test, linux-binary-manywheel / manywheel-py3_14t-rocm7_0-test, linux-binary-manywheel / manywheel-py3_13-rocm7_0-test, linux-binary-manywheel / manywheel-py3_14-rocm7_0-test, linux-binary-manywheel / manywheel-py3_13t-rocm7_0-test

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 29, 2025

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@zklaus
Copy link
Copy Markdown
Collaborator Author

zklaus commented Sep 29, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 29, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 29, 2025

Merge failed

Reason: 7 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_11-rocm7_0-test, linux-binary-manywheel / manywheel-py3_12-rocm7_0-test, linux-binary-manywheel / manywheel-py3_10-rocm7_0-test, linux-binary-manywheel / manywheel-py3_14t-rocm7_0-test, linux-binary-manywheel / manywheel-py3_13-rocm7_0-test

Details for Dev Infra team Raised by workflow job

@zklaus
Copy link
Copy Markdown
Collaborator Author

zklaus commented Sep 29, 2025

@pytorchbot merge -f "The rocm 7 test failures are unrelated."

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 29, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/zklaus/11/head branch October 30, 2025 02:17
This was referenced Nov 3, 2025
Closed
Closed
pytorchmergebot pushed a commit that referenced this pull request Nov 6, 2025
@taras-janea @pytorchmergebot
Fix python -m build: error: unrecognized arguments: --no-build-isolat…
8523a64 
…ion (#166848)

Fixes #166326

The PR fixes the following error:
```
python -m build: error: unrecognized arguments: --no-build-isolation
```

The regression has been introduced in the [commit](50d418f#diff-e5a6ba9ea3717e5913cd885e81f143937ea727282edd6939479a2a60b1051bf5R73) in the scope of [PR](#156712).

Pull Request resolved: #166848
Approved by: https://github.com/seemethere
yarongmu-google pushed a commit to yarongmu-google/pytorch that referenced this pull request Nov 7, 2025
@taras-janea @yarongmu-google
Fix python -m build: error: unrecognized arguments: --no-build-isolat…
c75bcf0 
…ion (pytorch#166848)

Fixes pytorch#166326

The PR fixes the following error:
```
python -m build: error: unrecognized arguments: --no-build-isolation
```

The regression has been introduced in the [commit](pytorch@50d418f#diff-e5a6ba9ea3717e5913cd885e81f143937ea727282edd6939479a2a60b1051bf5R73) in the scope of [PR](pytorch#156712).

Pull Request resolved: pytorch#166848
Approved by: https://github.com/seemethere
Silv3S pushed a commit to Silv3S/pytorch that referenced this pull request Nov 18, 2025
@taras-janea @Silv3S
Fix python -m build: error: unrecognized arguments: --no-build-isolat…
8212be8 
…ion (pytorch#166848)

Fixes pytorch#166326

The PR fixes the following error:
```
python -m build: error: unrecognized arguments: --no-build-isolation
```

The regression has been introduced in the [commit](pytorch@50d418f#diff-e5a6ba9ea3717e5913cd885e81f143937ea727282edd6939479a2a60b1051bf5R73) in the scope of [PR](pytorch#156712).

Pull Request resolved: pytorch#166848
Approved by: https://github.com/seemethere
@atalman atalman mentioned this pull request Jan 15, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XuehaiPan XuehaiPan XuehaiPan left review comments

@atalman atalman atalman approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily

Assignees

No one assigned

Labels

ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: releng release notes category suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter)

Projects

None yet

Milestone

2.10.0

Development

Successfully merging this pull request may close these issues.

5 participants

@zklaus @atalman @pytorchmergebot @XuehaiPan @pytorchbot