[BE] Add __all__ to torch/nn/functional.pyi and torch/return_types.pyi#150729
[BE] Add __all__ to torch/nn/functional.pyi and torch/return_types.pyi#150729XuehaiPan wants to merge 22 commits intogh/XuehaiPan/266/basefrom
__all__ to torch/nn/functional.pyi and torch/return_types.pyi#150729Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150729
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit bbb0a1a with merge base e5e06d9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (2)
- torch/_C/return_types.pyi.in: Language not supported
- torch/nn/functional.pyi.in: Language not supported
Comments suppressed due to low confidence (2)
tools/pyi/gen_pyi.py:605
- Consider explicitly using unsorted_dispatched_hints.keys() when extending extra_nn_functional___all__ to make it clear that the keys are being added.
extra_nn_functional___all__.extend(unsorted_dispatched_hints)
tools/pyi/gen_pyi.py:558
- [nitpick] Consider adding a brief comment explaining why 'log_sigmoid' is renamed to 'logsigmoid' to improve code readability.
renamed = {"log_sigmoid": "logsigmoid"}
|
Rebased |
…es.pyi` ghstack-source-id: e6f7fe5 Pull Request resolved: pytorch#150729
|
Rebased |
…es.pyi` ghstack-source-id: 3223b54 Pull Request resolved: pytorch#150729
…es.pyi` ghstack-source-id: 144d3aa Pull Request resolved: pytorch#150729
…es.pyi` ghstack-source-id: be693b5 Pull Request resolved: pytorch#150729
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 2 jobs have failed, first few of them are: trunk / win-vs2022-cpu-py3 / build, trunk / win-vs2022-cuda12.6-py3 / build Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
…es.pyi` ghstack-source-id: 3f281ef Pull Request resolved: pytorch#150729
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack (oldest at bottom):
lintrunneron generated.pyistub files #150732.pyistub files #150731gen_pyiare properly formatted #150730torch/utils/data/datapipes/gen_pyi.pywithtorchgen#150626__all__totorch/nn/functional.pyiandtorch/return_types.pyi#150729cc @albanD @mruberry @jbschlosser @walterddr @mikaylagawarecki @ezyang @bhosmer @bdhirsh @kadeng