Skip to content

[BE][CI][Easy] Run lintrunner on generated .pyi stub files#150732

Closed
XuehaiPan wants to merge 33 commits intogh/XuehaiPan/269/basefrom
gh/XuehaiPan/269/head
Closed

[BE][CI][Easy] Run lintrunner on generated .pyi stub files#150732
XuehaiPan wants to merge 33 commits intogh/XuehaiPan/269/basefrom
gh/XuehaiPan/269/head

Conversation

@XuehaiPan
Copy link
Collaborator

@XuehaiPan XuehaiPan commented Apr 5, 2025

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 5, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150732

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 52a3c91 with merge base ef6306e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Apr 5, 2025
@XuehaiPan XuehaiPan added module: typing Related to mypy type annotations module: ci Related to continuous integration module: lint Issues related to our Python/C++ lint rules (run by Travis) better-engineering Relatively self-contained tasks for better engineering contributors labels Apr 5, 2025
@XuehaiPan XuehaiPan requested review from Skylion007 and ezyang April 5, 2025 07:58
@XuehaiPan XuehaiPan added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 5, 2025
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
python3 torch/utils/data/datapipes/gen_pyi.py

# Also check generated pyi files
find torch -name '*.pyi' -exec git add --force -- "{}" +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL I've learned about + variant, don't know when it was the first time I did it, but I would have done it as
find torch -name '*.pyi'| xargs git add --force

Copy link
Contributor

@aorenste aorenste May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a problem for non-git users (such as myself).
Edit: Nevermind - I didn't realize this was in the github scripts...

XuehaiPan added a commit that referenced this pull request May 16, 2025
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request May 17, 2025
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request May 17, 2025
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request May 20, 2025
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request May 26, 2025
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request May 27, 2025
@pytorch-bot pytorch-bot bot added the ciflow/mps Run MPS tests (subset of trunk) label May 27, 2025
@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/XuehaiPan/269/head branch June 27, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

better-engineering Relatively self-contained tasks for better engineering contributors ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged module: ci Related to continuous integration module: lint Issues related to our Python/C++ lint rules (run by Travis) module: typing Related to mypy type annotations open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants