Refactor `torch/utils/data/datapipes/gen_pyi.py` with `torchgen` by XuehaiPan · Pull Request #150626 · pytorch/pytorch

XuehaiPan · 2025-04-03T16:29:17Z

Stack from ghstack (oldest at bottom):

[ghstack-poisoned]

pytorch-bot · 2025-04-03T16:29:21Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150626

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

CUDA not found in NVIDIA runners

✅ No Failures

As of commit c715b4f with merge base cb5f31a ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ghstack-source-id: 7778da7 Pull Request resolved: pytorch#150626

test/allowlist_for_publicAPI.json

[ghstack-poisoned]

XuehaiPan · 2025-04-04T18:11:57Z

The gen_pyi.py file is not intended to export anything. Suppress the BC linter.

ghstack-source-id: f92a3a2 Pull Request resolved: pytorch#150626

[ghstack-poisoned]

ghstack-source-id: 909f4b3 Pull Request resolved: pytorch#150626

[ghstack-poisoned]

ghstack-source-id: c26fdb4 Pull Request resolved: pytorch#150626

[ghstack-poisoned]

aorenste · 2025-05-14T16:42:03Z

torch/utils/data/datapipes/gen_pyi.py

+except ImportError:
+    import sys
+
+    REPO_ROOT = _Path(__file__).absolute().parents[4]


Maybe a quick comment saying when this is expected to occur?

torch/utils/data/datapipes/gen_pyi.py

[ghstack-poisoned]

ghstack-source-id: 0b4fbf3 Pull Request resolved: pytorch#150626

aorenste · 2025-05-15T21:52:24Z

torch/utils/data/datapipes/gen_pyi.py

+__all__: list[str] = []  # not intended to expose any symbols
+
+
+def __dir__() -> list[str]:


How does this appease the public API test? I'm surprised that the test treats a module with no actually visible members any different than one with and empty '__all__' defined... I wonder if there's a test bug there...

The public API test checks symbols in set(dir(mod)) - set(mod.__all__).

XuehaiPan · 2025-05-16T16:14:45Z

@pytorchbot merge

pytorchmergebot · 2025-05-16T16:16:41Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-05-16T18:28:23Z

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_9-cuda12_6-test / test

Details for Dev Infra team

Raised by workflow job

XuehaiPan · 2025-05-17T06:14:15Z

@pytorchbot merge

pytorchmergebot · 2025-05-17T06:16:05Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Update

f45ecfe

[ghstack-poisoned]

XuehaiPan requested review from albanD and divyanshk as code owners April 3, 2025 16:29

pytorch-bot bot added the release notes: dataloader release notes category label Apr 3, 2025

XuehaiPan added topic: not user facing topic category and removed release notes: dataloader release notes category labels Apr 3, 2025

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Apr 3, 2025

Refactor torch/utils/data/datapipes with torchgen

e765275

ghstack-source-id: 7778da7 Pull Request resolved: pytorch#150626

pytorchbot added the open source label Apr 3, 2025

Skylion007 reviewed Apr 4, 2025

View reviewed changes

test/allowlist_for_publicAPI.json Outdated Show resolved Hide resolved

Update

c5e71eb

[ghstack-poisoned]

XuehaiPan changed the title ~~Refactor torch/utils/data/datapipes with torchgen~~ Refactor torch/utils/data/datapipes/gen_pyi.py with torchgen Apr 4, 2025

XuehaiPan added 2 commits April 5, 2025 02:06

Update

31693c5

[ghstack-poisoned]

Update

784096a

[ghstack-poisoned]

XuehaiPan added the suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) label Apr 4, 2025

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Apr 4, 2025

Refactor torch/utils/data/datapipes/gen_pyi.py with torchgen

835868a

ghstack-source-id: f92a3a2 Pull Request resolved: pytorch#150626

Update

83dd5e4

[ghstack-poisoned]

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Apr 4, 2025

Refactor torch/utils/data/datapipes/gen_pyi.py with torchgen

b885a89

ghstack-source-id: 909f4b3 Pull Request resolved: pytorch#150626

Update

1e42449

[ghstack-poisoned]

Update

421a151

[ghstack-poisoned]

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 14, 2025

Refactor torch/utils/data/datapipes/gen_pyi.py with torchgen

deb2f45

ghstack-source-id: c26fdb4 Pull Request resolved: pytorch#150626

Update

0c6bcc3

[ghstack-poisoned]

aorenste reviewed May 14, 2025

View reviewed changes

Update

1476a20

[ghstack-poisoned]

XuehaiPan requested a review from aorenste May 15, 2025 15:18

Update

6cec673

[ghstack-poisoned]

Update

c715b4f

[ghstack-poisoned]

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request May 16, 2025

Refactor torch/utils/data/datapipes/gen_pyi.py with torchgen

3da2770

ghstack-source-id: 0b4fbf3 Pull Request resolved: pytorch#150626

aorenste approved these changes May 16, 2025

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 16, 2025

pytorchmergebot added the merging label May 16, 2025

pytorchmergebot removed the merging label May 16, 2025

pytorchmergebot added the merging label May 17, 2025

pytorchmergebot closed this in 9b2a45a May 17, 2025

pytorchmergebot added Merged and removed merging labels May 17, 2025

github-actions bot deleted the gh/XuehaiPan/262/head branch June 19, 2025 02:20

adamjstewart mentioned this pull request Aug 7, 2025

PyTorch 2.8: PYTHONPATH no longer respected when building from source? #160092

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor `torch/utils/data/datapipes/gen_pyi.py` with `torchgen`#150626

Refactor `torch/utils/data/datapipes/gen_pyi.py` with `torchgen`#150626
XuehaiPan wants to merge 29 commits intogh/XuehaiPan/262/basefrom
gh/XuehaiPan/262/head

XuehaiPan commented Apr 3, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Apr 3, 2025 •

edited

Loading

Uh oh!

Uh oh!

XuehaiPan commented Apr 4, 2025

Uh oh!

aorenste May 14, 2025

Uh oh!

Uh oh!

aorenste May 15, 2025

Uh oh!

XuehaiPan May 16, 2025 •

edited

Loading

Uh oh!

XuehaiPan commented May 16, 2025

Uh oh!

pytorchmergebot commented May 16, 2025

Uh oh!

pytorchmergebot commented May 16, 2025

Uh oh!

XuehaiPan commented May 17, 2025

Uh oh!

pytorchmergebot commented May 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		__all__: list[str] = [] # not intended to expose any symbols


		def __dir__() -> list[str]:

Conversation

XuehaiPan commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150626

❗ 1 Active SEVs

✅ No Failures

Uh oh!

Uh oh!

XuehaiPan commented Apr 4, 2025

Uh oh!

aorenste May 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aorenste May 15, 2025

Choose a reason for hiding this comment

Uh oh!

XuehaiPan May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

XuehaiPan commented May 16, 2025

Uh oh!

pytorchmergebot commented May 16, 2025

Merge started

Uh oh!

pytorchmergebot commented May 16, 2025

Merge failed

Uh oh!

XuehaiPan commented May 17, 2025

Uh oh!

pytorchmergebot commented May 17, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

XuehaiPan commented Apr 3, 2025 •

edited

Loading

pytorch-bot bot commented Apr 3, 2025 •

edited

Loading

XuehaiPan May 16, 2025 •

edited

Loading