[ci, 3.13] fix/skip failing numpy 2.0+ dynamo-wrapped tests#141950
Closed
williamwen42 wants to merge 3 commits into
Closed
[ci, 3.13] fix/skip failing numpy 2.0+ dynamo-wrapped tests#141950williamwen42 wants to merge 3 commits into
williamwen42 wants to merge 3 commits into
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141950
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 649b3b9 with merge base 16676fd ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Dec 2, 2024
[ghstack-poisoned]
[ghstack-poisoned]
StrongerXi
approved these changes
Dec 4, 2024
Comment on lines
+36
to
+39
| if int(numpy.__version__[0]) >= 2: | ||
| from numpy.exceptions import AxisError | ||
| else: | ||
| from numpy import AxisError |
Contributor
There was a problem hiding this comment.
I thought PT is already compatible with numpy 2, or am I imagining things?
Member
Author
There was a problem hiding this comment.
The support might not be fully completed. Our test coverage also wasn't there since we didn't test numpy 2.0+ until 3.13.
atalman
approved these changes
Dec 4, 2024
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…141950) Pull Request resolved: pytorch#141950 Approved by: https://github.com/StrongerXi, https://github.com/atalman ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886, pytorch#141887
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…141951) Pull Request resolved: pytorch#141951 Approved by: https://github.com/sraikund16, https://github.com/atalman ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886, pytorch#141887, pytorch#141950
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Pull Request resolved: pytorch#141264 Approved by: https://github.com/StrongerXi, https://github.com/atalman ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886, pytorch#141887, pytorch#141950, pytorch#141951
AmdSampsa
pushed a commit
to AmdSampsa/pytorch
that referenced
this pull request
Dec 9, 2024
…141950) Pull Request resolved: pytorch#141950 Approved by: https://github.com/StrongerXi, https://github.com/atalman ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886, pytorch#141887
AmdSampsa
pushed a commit
to AmdSampsa/pytorch
that referenced
this pull request
Dec 9, 2024
Pull Request resolved: pytorch#141264 Approved by: https://github.com/StrongerXi, https://github.com/atalman ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886, pytorch#141887, pytorch#141950, pytorch#141951
37 tasks
Esquains
pushed a commit
to Esquains/study1
that referenced
this pull request
Dec 15, 2024
ghstack-source-id: e83a17b Pull Request resolved: pytorch/pytorch#141950
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):