Skip to content

[torch.package, 3.13] fixes to torch.package for 3.13#141409

Closed
williamwen42 wants to merge 15 commits into
gh/williamwen42/168/basefrom
gh/williamwen42/168/head
Closed

[torch.package, 3.13] fixes to torch.package for 3.13#141409
williamwen42 wants to merge 15 commits into
gh/williamwen42/168/basefrom
gh/williamwen42/168/head

Conversation

@williamwen42

@williamwen42 williamwen42 commented Nov 23, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Stack from ghstack (oldest at bottom):

@pytorch-bot

pytorch-bot Bot commented Nov 23, 2024 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141409

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d524a7e with merge base 16676fd (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot Bot added the release notes: package/deploy release notes category label Nov 23, 2024
This was referenced Nov 23, 2024
Closed
Closed
Closed
@williamwen42 williamwen42 mentioned this pull request Nov 26, 2024
Closed
@williamwen42 williamwen42 mentioned this pull request Nov 26, 2024
Closed
@williamwen42 williamwen42 mentioned this pull request Nov 26, 2024
Closed
@williamwen42 williamwen42 mentioned this pull request Nov 26, 2024
Closed
@williamwen42 williamwen42 mentioned this pull request Nov 26, 2024
Closed
@williamwen42 williamwen42 mentioned this pull request Nov 27, 2024
Closed
@williamwen42 williamwen42 mentioned this pull request Nov 27, 2024
Closed
This was referenced Dec 2, 2024
Closed
Closed
This was referenced Dec 2, 2024
Closed
Closed
Closed
Closed
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[ci] add 3.13 inductor unittests to CI (pytorch#140733)
3626125 
Pull Request resolved: pytorch#140733
Approved by: https://github.com/malfet, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[dynamo, 3.13] add JUMP_BACKWARD_NO_INTERRUPT to terminal opcodes (py…
21cf16d 
…torch#141859)

Pull Request resolved: pytorch#141859
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[dynamo, 3.13] disable 3.13.0 warning in dynamo-wrapped tests (pytorc…
bc6077b 
…h#141860)

Pull Request resolved: pytorch#141860
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[ci, 3.13] skip failing torch.package dynamo-wrapped test (pytorch#14…
82e76d0 
…1886)

Pull Request resolved: pytorch#141886
Approved by: https://github.com/PaliC
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[ci, 3.13] skip failing module tracker dynamo-wrapped test (pytorch#1…
3f7c8ae 
…41887)

Pull Request resolved: pytorch#141887
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[ci, 3.13] fix/skip failing numpy 2.0+ dynamo-wrapped tests (pytorch#…
ca4c72e 
…141950)

Pull Request resolved: pytorch#141950
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886, pytorch#141887
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[ci, 3.13] disable segfaulting dynamo-wrapped profiler test (pytorch#…
6ecd615 
…141951)

Pull Request resolved: pytorch#141951
Approved by: https://github.com/sraikund16, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886, pytorch#141887, pytorch#141950
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[CI, 3.13] enable dynamo_wrapped unittests in 3.13 (pytorch#141264)
33f35d6 
Pull Request resolved: pytorch#141264
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886, pytorch#141887, pytorch#141950, pytorch#141951
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[torch.package, 3.13] fixes to torch.package for 3.13 (pytorch#141409)
52d0e1b 
Pull Request resolved: pytorch#141409
Approved by: https://github.com/PaliC, https://github.com/atalman
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
format test_monitor.py and test_tensorboard.py (pytorch#142003)
74133d5 
Pull Request resolved: pytorch#142003
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[ci, 3.13] update tensorboard version for 3.13 to fix broken tests (p…
e8e5ad9 
…ytorch#141572)

Pull Request resolved: pytorch#141572
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[ci, 3.13] update test_testing.py usage of locals() for 3.13 (pytorch…
8821417 
…#141577)

Pull Request resolved: pytorch#141577
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[ci, 3.13] skip some parts of a failing jit test in 3.13 (pytorch#141605
d38d9f6 
)

Pull Request resolved: pytorch#141605
Approved by: https://github.com/davidberard98, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[ci, 3.13] disable some quantization tests affected by numpy 2.1 over…
369f4fd 
…flow error (pytorch#141621)

Pull Request resolved: pytorch#141621
Approved by: https://github.com/jerryzh168, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[ci, 3.13] disable failing cpp_extension test due to weights_only err…
3d2b7cf 
…or in numpy 2.1 (pytorch#141623)

Pull Request resolved: pytorch#141623
Approved by: https://github.com/mikaylagawarecki, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[ci, 3.13] disable another failing cpp_extension test in 3.13 (pytorc…
920c2dc 
…h#141673)

Pull Request resolved: pytorch#141673
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623
pytorch-bot Bot pushed a commit that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[ci, 3.13] disable segfaulting profiler tests in 3.13 (#141674)
79e68f9 
Pull Request resolved: #141674
Approved by: https://github.com/sraikund16, https://github.com/atalman
ghstack dependencies: #141409, #142003, #141572, #141577, #141605, #141621, #141623, #141673
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[dynamo, 3.13] support CONVERT_VALUE (pytorch#141858)
b5ac556 
Pull Request resolved: pytorch#141858
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[ci, 3.13] skip dynamo-xpass'd numpy tests in numpy >= 2.0 (pytorch#1…
4d2a3bc 
…41862)

Pull Request resolved: pytorch#141862
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[CI, 3.13] enable 3.13 CI (pytorch#139533)
776adcc 
Pull Request resolved: pytorch#139533
Approved by: https://github.com/atalman, https://github.com/malfet
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[ci] add 3.13 inductor unittests to CI (pytorch#140733)
602e75a 
Pull Request resolved: pytorch#140733
Approved by: https://github.com/malfet, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[dynamo, 3.13] add JUMP_BACKWARD_NO_INTERRUPT to terminal opcodes (py…
0bf73c9 
…torch#141859)

Pull Request resolved: pytorch#141859
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733
pytorch-bot Bot pushed a commit that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[dynamo, 3.13] disable 3.13.0 warning in dynamo-wrapped tests (#141860)
c1d0289 
Pull Request resolved: #141860
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: #141409, #142003, #141572, #141577, #141605, #141621, #141623, #141673, #141674, #141858, #141862, #139533, #140733, #141859
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[ci, 3.13] skip failing torch.package dynamo-wrapped test (pytorch#14…
86966d9 
…1886)

Pull Request resolved: pytorch#141886
Approved by: https://github.com/PaliC
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[ci, 3.13] skip failing module tracker dynamo-wrapped test (pytorch#1…
980eda7 
…41887)

Pull Request resolved: pytorch#141887
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886
pytorch-bot Bot pushed a commit that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[ci, 3.13] fix/skip failing numpy 2.0+ dynamo-wrapped tests (#141950)
ea06bac 
Pull Request resolved: #141950
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: #141409, #142003, #141572, #141577, #141605, #141621, #141623, #141673, #141674, #141858, #141862, #139533, #140733, #141859, #141860, #141886, #141887
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[ci, 3.13] disable segfaulting dynamo-wrapped profiler test (pytorch#…
ba7e1dc 
…141951)

Pull Request resolved: pytorch#141951
Approved by: https://github.com/sraikund16, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886, pytorch#141887, pytorch#141950
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[CI, 3.13] enable dynamo_wrapped unittests in 3.13 (pytorch#141264)
8eff273 
Pull Request resolved: pytorch#141264
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886, pytorch#141887, pytorch#141950, pytorch#141951
@atalman atalman mentioned this pull request Dec 12, 2024
Closed
37 tasks
@github-actions github-actions Bot deleted the gh/williamwen42/168/head branch January 4, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atalman atalman atalman approved these changes

+1 more reviewer

@PaliC PaliC PaliC approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: package/deploy release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@williamwen42 @pytorchmergebot @atalman @PaliC