[ci, 3.13] skip failing module tracker dynamo-wrapped test#141887
Closed
williamwen42 wants to merge 6 commits into
Closed
[ci, 3.13] skip failing module tracker dynamo-wrapped test#141887williamwen42 wants to merge 6 commits into
williamwen42 wants to merge 6 commits into
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141887
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 652f8fd with merge base 16676fd ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Dec 2, 2024
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
This was referenced Dec 3, 2024
[ghstack-poisoned]
[ghstack-poisoned]
StrongerXi
approved these changes
Dec 4, 2024
| ], | ||
| ) | ||
|
|
||
| @skipIfTorchDynamo("unexplained 3.13+ recursion error") |
Contributor
There was a problem hiding this comment.
☠️.
Btw what's the preference of this v.s. test/dynamo_expected_failures/...?
Member
Author
There was a problem hiding this comment.
Ah, I briefly forgot about those directories. We should probably be sticking them there in the future. But this would have gone under dynamo_skips since it only fails in 3.13.
atalman
approved these changes
Dec 5, 2024
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…41887) Pull Request resolved: pytorch#141887 Approved by: https://github.com/StrongerXi, https://github.com/atalman ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…141950) Pull Request resolved: pytorch#141950 Approved by: https://github.com/StrongerXi, https://github.com/atalman ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886, pytorch#141887
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…141951) Pull Request resolved: pytorch#141951 Approved by: https://github.com/sraikund16, https://github.com/atalman ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886, pytorch#141887, pytorch#141950
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Pull Request resolved: pytorch#141264 Approved by: https://github.com/StrongerXi, https://github.com/atalman ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886, pytorch#141887, pytorch#141950, pytorch#141951
37 tasks
Esquains
pushed a commit
to Esquains/study1
that referenced
this pull request
Dec 15, 2024
ghstack-source-id: dc75ce8 Pull Request resolved: pytorch/pytorch#141887
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):