Use std::bit_cast as c10::bit_cast if available#141035
Closed
swolchok wants to merge 4 commits intogh/swolchok/701/basefrom
Closed
Use std::bit_cast as c10::bit_cast if available#141035swolchok wants to merge 4 commits intogh/swolchok/701/basefrom
swolchok wants to merge 4 commits intogh/swolchok/701/basefrom
Conversation
Make what we're doing as obvious as possible to the compiler. Differential Revision: [D66108811](https://our.internmc.facebook.com/intern/diff/D66108811/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141035
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 7f3d535 with merge base 33191bb ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66108811 |
Make what we're doing as obvious as possible to the compiler. Differential Revision: [D66108811](https://our.internmc.facebook.com/intern/diff/D66108811/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Nov 19, 2024
Pull Request resolved: #141035 Make what we're doing as obvious as possible to the compiler. ghstack-source-id: 254339612 @exported-using-ghexport Differential Revision: [D66108811](https://our.internmc.facebook.com/intern/diff/D66108811/)
Skylion007
approved these changes
Nov 19, 2024
Skylion007
reviewed
Nov 19, 2024
| #include <bit> | ||
| #define C10_HAVE_STD_BIT_CAST 1 | ||
| #else | ||
| #define C10_HAVE_STD_BIT_CAST 0 |
Collaborator
There was a problem hiding this comment.
Similar logic to the prev PR. Does this macro serve any useful purpose. Main difference is whether bit_cast is constexpr I guess?
Contributor
There was a problem hiding this comment.
Generally speaking, it would be good to move those C10_HAVE_... macros to say c10/macros/Macros.h or define new Compiler.h there
As defining those in various headers can lead to a potential duplication and than divergence
Contributor
Author
There was a problem hiding this comment.
I just wanted to avoid duplicating the condition in this file.
defining those in various headers
what other header would reasonably define or consume this? this is the bit_cast header.
I can update the diff to undefine its temporary macro
ezyang
approved these changes
Nov 19, 2024
malfet
approved these changes
Nov 19, 2024
Make what we're doing as obvious as possible to the compiler. Differential Revision: [D66108811](https://our.internmc.facebook.com/intern/diff/D66108811/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66108811 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66108811 |
Make what we're doing as obvious as possible to the compiler. Differential Revision: [D66108811](https://our.internmc.facebook.com/intern/diff/D66108811/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Nov 19, 2024
Pull Request resolved: #141035 Make what we're doing as obvious as possible to the compiler. ghstack-source-id: 254364210 @exported-using-ghexport Differential Revision: [D66108811](https://our.internmc.facebook.com/intern/diff/D66108811/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66108811 |
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Contributor
|
Getting build errors, does this need |
Contributor
|
(Seems the #include is already there, but something is failing here...) |
MatzeB
reviewed
Nov 20, 2024
| @@ -3,8 +3,19 @@ | |||
| #include <cstring> | |||
| #include <type_traits> | |||
|
|
|||
Contributor
There was a problem hiding this comment.
This needs #include <version> before testing __cpp_lib_xxx.
(though I think this is unlikely the root cause of my build failures...)
facebook-github-bot
pushed a commit
to pytorch/FBGEMM
that referenced
this pull request
Nov 21, 2024
Summary: X-link: facebookresearch/FBGEMM#486 - Upgrade gcc version to support newer libstdc++, which is required now that pytorch/pytorch#141035 has landed - Deprecate support for CUDA 12.1 and add support for 12.6, per changes in pytorch/pytorch#138899 Pull Request resolved: #3398 Reviewed By: sryap Differential Revision: D66277492 Pulled By: q10 fbshipit-source-id: 24817efb5c07c1985ab3beeb1610879edbd81acc
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Make what we're doing as obvious as possible to the compiler. Differential Revision: [D66108811](https://our.internmc.facebook.com/intern/diff/D66108811/) Pull Request resolved: pytorch#141035 Approved by: https://github.com/Skylion007, https://github.com/ezyang, https://github.com/malfet ghstack dependencies: pytorch#140564, pytorch#140565, pytorch#140566, pytorch#140567, pytorch#140720, pytorch#140994
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Dec 23, 2024
Summary: TorchRec CI currently is failing with issues on incompatible GLIBCXX version. The cause is that FBGEMM now requires g++ 11.1+ for building binaries that reference GLIBCXX_3.4.29 (as of pytorch/pytorch#141035) As recommended in https://github.com/pytorch/FBGEMM/blob/main/.github/scripts/utils_build.bash and pytorch/FBGEMM#3423, install GCC using conda to control glibcxx version being used. Differential Revision: D67607624
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Dec 23, 2024
Summary: TorchRec CI currently is failing with issues on incompatible GLIBCXX version. The cause is that FBGEMM now requires g++ 11.1+ for building binaries that reference GLIBCXX_3.4.29 (as of pytorch/pytorch#141035) As recommended in https://github.com/pytorch/FBGEMM/blob/main/.github/scripts/utils_build.bash and pytorch/FBGEMM#3423, install GCC using conda to control glibcxx version being used. Differential Revision: D67607624
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Dec 23, 2024
Summary: TorchRec CI currently is failing with issues on incompatible GLIBCXX version. The cause is that FBGEMM now requires g++ 11.1+ for building binaries that reference GLIBCXX_3.4.29 (as of pytorch/pytorch#141035) As recommended in https://github.com/pytorch/FBGEMM/blob/main/.github/scripts/utils_build.bash and pytorch/FBGEMM#3423, install GCC using conda to control glibcxx version being used. Differential Revision: D67607624
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Dec 23, 2024
Summary: TorchRec CI currently is failing with issues on incompatible GLIBCXX version. The cause is that FBGEMM now requires g++ 11.1+ for building binaries that reference GLIBCXX_3.4.29 (as of pytorch/pytorch#141035) As recommended in https://github.com/pytorch/FBGEMM/blob/main/.github/scripts/utils_build.bash and pytorch/FBGEMM#3423, install GCC using conda to control glibcxx version being used. Differential Revision: D67607624
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Dec 24, 2024
Summary: TorchRec CI currently is failing with issues on incompatible GLIBCXX version. The cause is that FBGEMM now requires g++ 11.1+ for building binaries that reference GLIBCXX_3.4.29 (as of pytorch/pytorch#141035) As recommended in https://github.com/pytorch/FBGEMM/blob/main/.github/scripts/utils_build.bash and pytorch/FBGEMM#3423, install GCC using conda to control glibcxx version being used. Differential Revision: D67607624
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Dec 26, 2024
Summary: TorchRec CI currently is failing with issues on incompatible GLIBCXX version. The cause is that FBGEMM now requires g++ 11.1+ for building binaries that reference GLIBCXX_3.4.29 (as of pytorch/pytorch#141035) As recommended in https://github.com/pytorch/FBGEMM/blob/main/.github/scripts/utils_build.bash and pytorch/FBGEMM#3423, install GCC using conda to control glibcxx version being used. Differential Revision: D67607624
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Jan 3, 2025
Summary: TorchRec CI currently is failing with issues on incompatible GLIBCXX version. The cause is that FBGEMM now requires g++ 11.1+ for building binaries that reference GLIBCXX_3.4.29 (as of pytorch/pytorch#141035) As recommended in https://github.com/pytorch/FBGEMM/blob/main/.github/scripts/utils_build.bash and pytorch/FBGEMM#3423, install GCC using conda to control glibcxx version being used. Differential Revision: D67607624
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Jan 3, 2025
Summary: TorchRec CI currently is failing with issues on incompatible GLIBCXX version. The cause is that FBGEMM now requires g++ 11.1+ for building binaries that reference GLIBCXX_3.4.29 (as of pytorch/pytorch#141035) As recommended in https://github.com/pytorch/FBGEMM/blob/main/.github/scripts/utils_build.bash and pytorch/FBGEMM#3423, install GCC using conda to control glibcxx version being used. Differential Revision: D67607624
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Jan 3, 2025
Summary: TorchRec CI currently is failing with issues on incompatible GLIBCXX version. The cause is that FBGEMM now requires g++ 11.1+ for building binaries that reference GLIBCXX_3.4.29 (as of pytorch/pytorch#141035) As recommended in https://github.com/pytorch/FBGEMM/blob/main/.github/scripts/utils_build.bash and pytorch/FBGEMM#3423, install GCC using conda to control glibcxx version being used. Differential Revision: D67607624
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Jan 3, 2025
Summary: TorchRec CI currently is failing with issues on incompatible GLIBCXX version. The cause is that FBGEMM now requires g++ 11.1+ for building binaries that reference GLIBCXX_3.4.29 (as of pytorch/pytorch#141035) As recommended in https://github.com/pytorch/FBGEMM/blob/main/.github/scripts/utils_build.bash and pytorch/FBGEMM#3423, install GCC using conda to control glibcxx version being used. Differential Revision: D67607624
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Jan 6, 2025
Summary: TorchRec CI currently is failing with issues on incompatible GLIBCXX version. The cause is that FBGEMM now requires g++ 11.1+ for building binaries that reference GLIBCXX_3.4.29 (as of pytorch/pytorch#141035) As recommended in https://github.com/pytorch/FBGEMM/blob/main/.github/scripts/utils_build.bash and pytorch/FBGEMM#3423, install GCC using conda to control glibcxx version being used. Differential Revision: D67607624
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Jan 6, 2025
Summary: TorchRec CI currently is failing with issues on incompatible GLIBCXX version. The cause is that FBGEMM now requires g++ 11.1+ for building binaries that reference GLIBCXX_3.4.29 (as of pytorch/pytorch#141035) As recommended in https://github.com/pytorch/FBGEMM/blob/main/.github/scripts/utils_build.bash and pytorch/FBGEMM#3423, install GCC using conda to control glibcxx version being used. Differential Revision: D67607624
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Jan 6, 2025
Summary: TorchRec CI currently is failing with issues on incompatible GLIBCXX version. The cause is that FBGEMM now requires g++ 11.1+ for building binaries that reference GLIBCXX_3.4.29 (as of pytorch/pytorch#141035) As recommended in https://github.com/pytorch/FBGEMM/blob/main/.github/scripts/utils_build.bash and pytorch/FBGEMM#3423, install GCC using conda to control glibcxx version being used. Differential Revision: D67607624
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Make what we're doing as obvious as possible to the compiler.
Differential Revision: D66108811