Update gcc version for FBGEMM install in CI#2654
Closed
sarckk wants to merge 1 commit intometa-pytorch:mainfrom
Closed
Update gcc version for FBGEMM install in CI#2654sarckk wants to merge 1 commit intometa-pytorch:mainfrom
sarckk wants to merge 1 commit intometa-pytorch:mainfrom
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67607624 |
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Dec 23, 2024
Summary: TorchRec CI currently is failing with issues on incompatible GLIBCXX version. The cause is that FBGEMM now requires g++ 11.1+ for building binaries that reference GLIBCXX_3.4.29 (as of pytorch/pytorch#141035) As recommended in https://github.com/pytorch/FBGEMM/blob/main/.github/scripts/utils_build.bash and pytorch/FBGEMM#3423, install GCC using conda to control glibcxx version being used. Differential Revision: D67607624
007d5d8 to
fc5bb7b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67607624 |
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Dec 23, 2024
Summary: TorchRec CI currently is failing with issues on incompatible GLIBCXX version. The cause is that FBGEMM now requires g++ 11.1+ for building binaries that reference GLIBCXX_3.4.29 (as of pytorch/pytorch#141035) As recommended in https://github.com/pytorch/FBGEMM/blob/main/.github/scripts/utils_build.bash and pytorch/FBGEMM#3423, install GCC using conda to control glibcxx version being used. Differential Revision: D67607624
fc5bb7b to
77e4f9f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67607624 |
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Dec 23, 2024
Summary: TorchRec CI currently is failing with issues on incompatible GLIBCXX version. The cause is that FBGEMM now requires g++ 11.1+ for building binaries that reference GLIBCXX_3.4.29 (as of pytorch/pytorch#141035) As recommended in https://github.com/pytorch/FBGEMM/blob/main/.github/scripts/utils_build.bash and pytorch/FBGEMM#3423, install GCC using conda to control glibcxx version being used. Differential Revision: D67607624
77e4f9f to
1ec9475
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67607624 |
Contributor
|
I think I have a fix for this upstream in fbgemm (where the issue comes from) pytorch/FBGEMM#3528, so let's hold on to see if we need this PR |
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Dec 24, 2024
Summary: TorchRec CI currently is failing with issues on incompatible GLIBCXX version. The cause is that FBGEMM now requires g++ 11.1+ for building binaries that reference GLIBCXX_3.4.29 (as of pytorch/pytorch#141035) As recommended in https://github.com/pytorch/FBGEMM/blob/main/.github/scripts/utils_build.bash and pytorch/FBGEMM#3423, install GCC using conda to control glibcxx version being used. Differential Revision: D67607624
1ec9475 to
b131e5d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67607624 |
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Dec 26, 2024
Summary: TorchRec CI currently is failing with issues on incompatible GLIBCXX version. The cause is that FBGEMM now requires g++ 11.1+ for building binaries that reference GLIBCXX_3.4.29 (as of pytorch/pytorch#141035) As recommended in https://github.com/pytorch/FBGEMM/blob/main/.github/scripts/utils_build.bash and pytorch/FBGEMM#3423, install GCC using conda to control glibcxx version being used. Differential Revision: D67607624
b131e5d to
890b279
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67607624 |
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Jan 3, 2025
Summary: TorchRec CI currently is failing with issues on incompatible GLIBCXX version. The cause is that FBGEMM now requires g++ 11.1+ for building binaries that reference GLIBCXX_3.4.29 (as of pytorch/pytorch#141035) As recommended in https://github.com/pytorch/FBGEMM/blob/main/.github/scripts/utils_build.bash and pytorch/FBGEMM#3423, install GCC using conda to control glibcxx version being used. Differential Revision: D67607624
890b279 to
46e42a3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67607624 |
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Jan 3, 2025
Summary: TorchRec CI currently is failing with issues on incompatible GLIBCXX version. The cause is that FBGEMM now requires g++ 11.1+ for building binaries that reference GLIBCXX_3.4.29 (as of pytorch/pytorch#141035) As recommended in https://github.com/pytorch/FBGEMM/blob/main/.github/scripts/utils_build.bash and pytorch/FBGEMM#3423, install GCC using conda to control glibcxx version being used. Differential Revision: D67607624
46e42a3 to
b0167a6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67607624 |
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Jan 3, 2025
Summary: TorchRec CI currently is failing with issues on incompatible GLIBCXX version. The cause is that FBGEMM now requires g++ 11.1+ for building binaries that reference GLIBCXX_3.4.29 (as of pytorch/pytorch#141035) As recommended in https://github.com/pytorch/FBGEMM/blob/main/.github/scripts/utils_build.bash and pytorch/FBGEMM#3423, install GCC using conda to control glibcxx version being used. Differential Revision: D67607624
b0167a6 to
1227be2
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67607624 |
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Jan 3, 2025
Summary: TorchRec CI currently is failing with issues on incompatible GLIBCXX version. The cause is that FBGEMM now requires g++ 11.1+ for building binaries that reference GLIBCXX_3.4.29 (as of pytorch/pytorch#141035) As recommended in https://github.com/pytorch/FBGEMM/blob/main/.github/scripts/utils_build.bash and pytorch/FBGEMM#3423, install GCC using conda to control glibcxx version being used. Differential Revision: D67607624
1227be2 to
ee65f80
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67607624 |
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Jan 6, 2025
Summary: TorchRec CI currently is failing with issues on incompatible GLIBCXX version. The cause is that FBGEMM now requires g++ 11.1+ for building binaries that reference GLIBCXX_3.4.29 (as of pytorch/pytorch#141035) As recommended in https://github.com/pytorch/FBGEMM/blob/main/.github/scripts/utils_build.bash and pytorch/FBGEMM#3423, install GCC using conda to control glibcxx version being used. Differential Revision: D67607624
ee65f80 to
a3999b1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67607624 |
sarckk
added a commit
to sarckk/torchrec
that referenced
this pull request
Jan 6, 2025
Summary: TorchRec CI currently is failing with issues on incompatible GLIBCXX version. The cause is that FBGEMM now requires g++ 11.1+ for building binaries that reference GLIBCXX_3.4.29 (as of pytorch/pytorch#141035) As recommended in https://github.com/pytorch/FBGEMM/blob/main/.github/scripts/utils_build.bash and pytorch/FBGEMM#3423, install GCC using conda to control glibcxx version being used. Differential Revision: D67607624
a3999b1 to
f577083
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67607624 |
Summary: TorchRec CI currently is failing with issues on incompatible GLIBCXX version. The cause is that FBGEMM now requires g++ 11.1+ for building binaries that reference GLIBCXX_3.4.29 (as of pytorch/pytorch#141035) As recommended in https://github.com/pytorch/FBGEMM/blob/main/.github/scripts/utils_build.bash and pytorch/FBGEMM#3423, install GCC using conda to control glibcxx version being used. Differential Revision: D67607624
f577083 to
7a1a690
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67607624 |
Contributor
|
@sarckk Sorry for all the delay. I want to double check if this issue is still relevant. One thing is that FBGEMM and TorchRec should not need to install a newer gcc version now because we have finished updating the build to use gcc-11. I removed the step to install gcc in FBGEMM in pytorch/FBGEMM#3528. If there is still an issue somewhere, please ping me the link to that failure, I could take a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
TorchRec CI currently is failing with issues on incompatible GLIBCXX version. The cause is that FBGEMM now requires g++ 11.1+ for building binaries that reference GLIBCXX_3.4.29 (as of pytorch/pytorch#141035)
As recommended in https://github.com/pytorch/FBGEMM/blob/main/.github/scripts/utils_build.bash and pytorch/FBGEMM#3423, install GCC using conda to control glibcxx version being used.
Differential Revision: D67607624