Move complex<Half> from Half.h to complex.h by swolchok · Pull Request #140565 · pytorch/pytorch

swolchok · 2024-11-13T17:33:30Z

Stack from ghstack (oldest at bottom):

Executing on old TODO on the way to sharing Half.h with ExecuTorch.

Differential Revision: D65888037

Executing on old TODO on the way to sharing Half.h with ExecuTorch. Differential Revision: [D65888037](https://our.internmc.facebook.com/intern/diff/D65888037/) [ghstack-poisoned]

pytorch-bot · 2024-11-13T17:33:35Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140565

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

[DomainsOnly] Jobs fail with GLIBC version not found

✅ No Failures

As of commit 72d085a with merge base 891ba2e ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2024-11-13T17:33:49Z

This pull request was exported from Phabricator. Differential Revision: D65888037

Executing on old TODO on the way to sharing Half.h with ExecuTorch. Differential Revision: [D65888037](https://our.internmc.facebook.com/intern/diff/D65888037/) [ghstack-poisoned]

facebook-github-bot · 2024-11-14T16:32:42Z

This pull request was exported from Phabricator. Differential Revision: D65888037

Executing on old TODO on the way to sharing Half.h with ExecuTorch. Differential Revision: [D65888037](https://our.internmc.facebook.com/intern/diff/D65888037/) [ghstack-poisoned]

facebook-github-bot · 2024-11-14T18:34:14Z

This pull request was exported from Phabricator. Differential Revision: D65888037

malfet · 2024-11-18T15:48:41Z

@pytorchbot merge

pytorchmergebot · 2024-11-18T15:50:30Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

We want to use Half/BFloat16 in ExecuTorch to support shared kernel code. They will need to be used in ExecuTorch core, so they can't have streams. This diff introduces a macro to gate the stream code off. Differential Revision: [D65888035](https://our.internmc.facebook.com/intern/diff/D65888035/) Pull Request resolved: #140566 Approved by: https://github.com/ezyang, https://github.com/malfet ghstack dependencies: #140564, #140565

Accessing the inactive member of a union is undefined behavior. Fortunately, we have c10::bit_cast. Differential Revision: [D65888680](https://our.internmc.facebook.com/intern/diff/D65888680/) Pull Request resolved: #140567 Approved by: https://github.com/Skylion007, https://github.com/malfet ghstack dependencies: #140564, #140565, #140566

This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/) Pull Request resolved: #140720 Approved by: https://github.com/malfet ghstack dependencies: #140564, #140565, #140566, #140567

facebook-github-bot · 2024-11-19T00:27:48Z

This pull request was exported from Phabricator. Differential Revision: D65888037

It passed PyTorch CI, but internally we saw failures from this. Differential Revision: [D66137897](https://our.internmc.facebook.com/intern/diff/D66137897/) Pull Request resolved: #140994 Approved by: https://github.com/malfet ghstack dependencies: #140564, #140565, #140566, #140567, #140720

Make what we're doing as obvious as possible to the compiler. Differential Revision: [D66108811](https://our.internmc.facebook.com/intern/diff/D66108811/) Pull Request resolved: #141035 Approved by: https://github.com/Skylion007, https://github.com/ezyang, https://github.com/malfet ghstack dependencies: #140564, #140565, #140566, #140567, #140720, #140994

Executing on old TODO on the way to sharing Half.h with ExecuTorch. Differential Revision: [D65888037](https://our.internmc.facebook.com/intern/diff/D65888037/) Pull Request resolved: pytorch#140565 Approved by: https://github.com/ezyang, https://github.com/malfet ghstack dependencies: pytorch#140564

We want to use Half/BFloat16 in ExecuTorch to support shared kernel code. They will need to be used in ExecuTorch core, so they can't have streams. This diff introduces a macro to gate the stream code off. Differential Revision: [D65888035](https://our.internmc.facebook.com/intern/diff/D65888035/) Pull Request resolved: pytorch#140566 Approved by: https://github.com/ezyang, https://github.com/malfet ghstack dependencies: pytorch#140564, pytorch#140565

…140567) Accessing the inactive member of a union is undefined behavior. Fortunately, we have c10::bit_cast. Differential Revision: [D65888680](https://our.internmc.facebook.com/intern/diff/D65888680/) Pull Request resolved: pytorch#140567 Approved by: https://github.com/Skylion007, https://github.com/malfet ghstack dependencies: pytorch#140564, pytorch#140565, pytorch#140566

This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/) Pull Request resolved: pytorch#140720 Approved by: https://github.com/malfet ghstack dependencies: pytorch#140564, pytorch#140565, pytorch#140566, pytorch#140567

It passed PyTorch CI, but internally we saw failures from this. Differential Revision: [D66137897](https://our.internmc.facebook.com/intern/diff/D66137897/) Pull Request resolved: pytorch#140994 Approved by: https://github.com/malfet ghstack dependencies: pytorch#140564, pytorch#140565, pytorch#140566, pytorch#140567, pytorch#140720

Make what we're doing as obvious as possible to the compiler. Differential Revision: [D66108811](https://our.internmc.facebook.com/intern/diff/D66108811/) Pull Request resolved: pytorch#141035 Approved by: https://github.com/Skylion007, https://github.com/ezyang, https://github.com/malfet ghstack dependencies: pytorch#140564, pytorch#140565, pytorch#140566, pytorch#140567, pytorch#140720, pytorch#140994

Move complex<Half> from Half.h to complex.h

b72566b

Executing on old TODO on the way to sharing Half.h with ExecuTorch. Differential Revision: [D65888037](https://our.internmc.facebook.com/intern/diff/D65888037/) [ghstack-poisoned]

facebook-github-bot added the fb-exported label Nov 13, 2024

This was referenced Nov 13, 2024

move c10::overflows to its own header #140564

Closed

Add C10_EMBEDDED to gate ostream usage in Half/BFloat16 #140566

Closed

Remove UB type punning from c10/util/floating_point_utils.h #140567

Closed

swolchok added the topic: not user facing topic category label Nov 13, 2024

ezyang approved these changes Nov 14, 2024

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 14, 2024

Update on "Move complex<Half> from Half.h to complex.h"

e67d7b8

Executing on old TODO on the way to sharing Half.h with ExecuTorch. Differential Revision: [D65888037](https://our.internmc.facebook.com/intern/diff/D65888037/) [ghstack-poisoned]

swolchok mentioned this pull request Nov 14, 2024

Port X86_F16 from executorch half to PyTorch half #140720

Closed

Update on "Move complex<Half> from Half.h to complex.h"

72d085a

Executing on old TODO on the way to sharing Half.h with ExecuTorch. Differential Revision: [D65888037](https://our.internmc.facebook.com/intern/diff/D65888037/) [ghstack-poisoned]

malfet approved these changes Nov 18, 2024

View reviewed changes

pytorchmergebot added the merging label Nov 18, 2024

pytorchmergebot added the Merged label Nov 18, 2024

pytorchmergebot closed this in e429a3b Nov 18, 2024

pytorchmergebot removed the merging label Nov 18, 2024

swolchok mentioned this pull request Nov 19, 2024

Fix Half X86_F16 CUDA build failure #140994

Closed

swolchok mentioned this pull request Nov 19, 2024

Use std::bit_cast as c10::bit_cast if available #141035

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move complex<Half> from Half.h to complex.h#140565

Move complex<Half> from Half.h to complex.h#140565
swolchok wants to merge 3 commits intogh/swolchok/692/basefrom
gh/swolchok/692/head

swolchok commented Nov 13, 2024 •

edited

Loading

Uh oh!

pytorch-bot bot commented Nov 13, 2024 •

edited

Loading

Uh oh!

facebook-github-bot commented Nov 13, 2024

Uh oh!

facebook-github-bot commented Nov 14, 2024

Uh oh!

facebook-github-bot commented Nov 14, 2024

Uh oh!

malfet commented Nov 18, 2024

Uh oh!

pytorchmergebot commented Nov 18, 2024

Uh oh!

facebook-github-bot commented Nov 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

swolchok commented Nov 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Nov 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140565

❗ 1 Active SEVs

✅ No Failures

Uh oh!

facebook-github-bot commented Nov 13, 2024

Uh oh!

facebook-github-bot commented Nov 14, 2024

Uh oh!

facebook-github-bot commented Nov 14, 2024

Uh oh!

malfet commented Nov 18, 2024

Uh oh!

pytorchmergebot commented Nov 18, 2024

Merge started

Uh oh!

facebook-github-bot commented Nov 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

swolchok commented Nov 13, 2024 •

edited

Loading

pytorch-bot bot commented Nov 13, 2024 •

edited

Loading