Use Intel x86 intrinsics for half/float conversion#1789
Closed
Use Intel x86 intrinsics for half/float conversion#1789
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/1789
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit abea4c9 with merge base aff6f68 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53283798 |
Summary: Use Intel x86 intrinsics for half/float conversion with GCC and clang Reviewed By: cpuhrsch Differential Revision: D53283798
71ac2ca to
abea4c9
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53283798 |
mikekgfb
pushed a commit
that referenced
this pull request
Feb 1, 2024
Summary: Use Intel x86 intrinsics for half/float conversion with GCC and clang Reviewed By: cpuhrsch Differential Revision: D53283798
Contributor
|
This pull request has been merged in deb24a8. |
swolchok
added a commit
to pytorch/pytorch
that referenced
this pull request
Nov 14, 2024
This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/) [ghstack-poisoned]
swolchok
added a commit
to pytorch/pytorch
that referenced
this pull request
Nov 14, 2024
…ch half" This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/) [ghstack-poisoned]
swolchok
added a commit
to pytorch/pytorch
that referenced
this pull request
Nov 14, 2024
This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/) [ghstack-poisoned]
swolchok
added a commit
to pytorch/pytorch
that referenced
this pull request
Nov 14, 2024
Pull Request resolved: #140720 This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. ghstack-source-id: 253592160 @exported-using-ghexport Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/)
swolchok
added a commit
to pytorch/pytorch
that referenced
this pull request
Nov 15, 2024
…ch half" This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/) [ghstack-poisoned]
swolchok
added a commit
to pytorch/pytorch
that referenced
this pull request
Nov 15, 2024
This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/) [ghstack-poisoned]
swolchok
added a commit
to pytorch/pytorch
that referenced
this pull request
Nov 15, 2024
…ch half" This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/) [ghstack-poisoned]
swolchok
added a commit
to pytorch/pytorch
that referenced
this pull request
Nov 15, 2024
This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/) [ghstack-poisoned]
swolchok
added a commit
to pytorch/pytorch
that referenced
this pull request
Nov 15, 2024
Pull Request resolved: #140720 This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. ghstack-source-id: 253813016 @exported-using-ghexport Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/)
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Nov 18, 2024
This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/) Pull Request resolved: #140720 Approved by: https://github.com/malfet ghstack dependencies: #140564, #140565, #140566, #140567
swolchok
added a commit
to pytorch/pytorch
that referenced
this pull request
Nov 19, 2024
…ch half" This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/) [ghstack-poisoned]
swolchok
added a commit
to pytorch/pytorch
that referenced
this pull request
Nov 19, 2024
This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/) [ghstack-poisoned]
swolchok
added a commit
to pytorch/pytorch
that referenced
this pull request
Nov 19, 2024
…ch half" This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/) [ghstack-poisoned]
swolchok
added a commit
to pytorch/pytorch
that referenced
this pull request
Nov 19, 2024
This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/) [ghstack-poisoned]
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/) Pull Request resolved: pytorch#140720 Approved by: https://github.com/malfet ghstack dependencies: pytorch#140564, pytorch#140565, pytorch#140566, pytorch#140567
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Use Intel x86 intrinsics for half/float conversion with GCC and clang
Reviewed By: cpuhrsch
Differential Revision: D53283798