Skip to content

[AOTI][refactor] Switch remaining aoti_torch_get_data_ptr#140448

Closed
desertfire wants to merge 1 commit intogh/desertfire/507/basefrom
gh/desertfire/507/head
Closed

[AOTI][refactor] Switch remaining aoti_torch_get_data_ptr#140448
desertfire wants to merge 1 commit intogh/desertfire/507/basefrom
gh/desertfire/507/head

Conversation

@desertfire
Copy link
Contributor

@desertfire desertfire commented Nov 12, 2024

Summary: #139895 added data_ptr(), but there is a remaining place in cpp_wrapper_gpu.py didn't switch over. Also moved a few AtenTensorHandle related utility functions from arrayref_tensor.h to utils.h.

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 12, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140448

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 2b738df with merge base 965555d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@desertfire
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 13, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@desertfire
Copy link
Contributor Author

@pytorchbot merge -f "manywheel building queueing"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Nov 14, 2024
Summary: Similar to #139895, add sizes and strides methods to RAIIAtenTensorHandle and ConstantHandle, to increase the code readability.

Pull Request resolved: #140449
Approved by: https://github.com/chenyang78
ghstack dependencies: #140447, #140448
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
…0448)

Summary: pytorch#139895 added data_ptr(), but there is a remaining place in cpp_wrapper_gpu.py didn't switch over. Also moved a few AtenTensorHandle related utility functions from arrayref_tensor.h to utils.h.

Pull Request resolved: pytorch#140448
Approved by: https://github.com/chenyang78
ghstack dependencies: pytorch#140447
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
Summary: Similar to pytorch#139895, add sizes and strides methods to RAIIAtenTensorHandle and ConstantHandle, to increase the code readability.

Pull Request resolved: pytorch#140449
Approved by: https://github.com/chenyang78
ghstack dependencies: pytorch#140447, pytorch#140448
@github-actions github-actions bot deleted the gh/desertfire/507/head branch December 15, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants