[AOTI][refactor] Rename generate_extern_kernel_alloc_and_find_schema_if_needed#140447
Closed
desertfire wants to merge 1 commit intogh/desertfire/506/basefrom
Closed
[AOTI][refactor] Rename generate_extern_kernel_alloc_and_find_schema_if_needed#140447desertfire wants to merge 1 commit intogh/desertfire/506/basefrom
desertfire wants to merge 1 commit intogh/desertfire/506/basefrom
Conversation
…if_needed Summary: Rename generate_extern_kernel_alloc_and_find_schema_if_needed to better reflect its meaning. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140447
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 60be41f with merge base 965555d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Nov 12, 2024
chenyang78
approved these changes
Nov 13, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 14, 2024
Summary: #139895 added data_ptr(), but there is a remaining place in cpp_wrapper_gpu.py didn't switch over. Also moved a few AtenTensorHandle related utility functions from arrayref_tensor.h to utils.h. Pull Request resolved: #140448 Approved by: https://github.com/chenyang78 ghstack dependencies: #140447
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 14, 2024
Summary: Similar to #139895, add sizes and strides methods to RAIIAtenTensorHandle and ConstantHandle, to increase the code readability. Pull Request resolved: #140449 Approved by: https://github.com/chenyang78 ghstack dependencies: #140447, #140448
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…if_needed (pytorch#140447) Summary: Rename generate_extern_kernel_alloc_and_find_schema_if_needed to better reflect its meaning. Pull Request resolved: pytorch#140447 Approved by: https://github.com/chenyang78
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…0448) Summary: pytorch#139895 added data_ptr(), but there is a remaining place in cpp_wrapper_gpu.py didn't switch over. Also moved a few AtenTensorHandle related utility functions from arrayref_tensor.h to utils.h. Pull Request resolved: pytorch#140448 Approved by: https://github.com/chenyang78 ghstack dependencies: pytorch#140447
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Summary: Similar to pytorch#139895, add sizes and strides methods to RAIIAtenTensorHandle and ConstantHandle, to increase the code readability. Pull Request resolved: pytorch#140449 Approved by: https://github.com/chenyang78 ghstack dependencies: pytorch#140447, pytorch#140448
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: Rename generate_extern_kernel_alloc_and_find_schema_if_needed to better reflect its meaning.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @chauhang @aakhundov