[AOTI] Add data_ptr to RAIIAtenTensorHandle#139895
Closed
desertfire wants to merge 3 commits intogh/desertfire/502/basefrom
Closed
[AOTI] Add data_ptr to RAIIAtenTensorHandle#139895desertfire wants to merge 3 commits intogh/desertfire/502/basefrom
desertfire wants to merge 3 commits intogh/desertfire/502/basefrom
Conversation
Summary: To increase the readbility of the generated code. This is not BC-breaking, because RAIIAtenTensorHandle is implemented as header-only. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139895
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c20bb8e with merge base d031d1b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Summary: To increase the readbility of the generated code. This is not BC-breaking, because RAIIAtenTensorHandle is implemented as header-only. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang aakhundov [ghstack-poisoned]
Summary: To increase the readbility of the generated code. This is not BC-breaking, because RAIIAtenTensorHandle is implemented as header-only. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang aakhundov [ghstack-poisoned]
Contributor
Author
|
@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
chenyang78
approved these changes
Nov 6, 2024
Contributor
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
desertfire
added a commit
that referenced
this pull request
Nov 12, 2024
Summary: #139895 added data_ptr(), but there is a remaining place in cpp_wrapper_gpu.py didn't switch over. Also moved a few AtenTensorHandle related utility functions from arrayref_tensor.h to utils.h. [ghstack-poisoned]
desertfire
added a commit
that referenced
this pull request
Nov 12, 2024
Summary: Similar to #139895, add sizes and strides methods to RAIIAtenTensorHandle and ConstantHandle, to increase the code readability. [ghstack-poisoned]
desertfire
added a commit
that referenced
this pull request
Nov 13, 2024
Summary: Similar to #139895, add sizes and strides methods to RAIIAtenTensorHandle and ConstantHandle, to increase the code readability. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang aakhundov [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 14, 2024
Summary: #139895 added data_ptr(), but there is a remaining place in cpp_wrapper_gpu.py didn't switch over. Also moved a few AtenTensorHandle related utility functions from arrayref_tensor.h to utils.h. Pull Request resolved: #140448 Approved by: https://github.com/chenyang78 ghstack dependencies: #140447
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 14, 2024
Summary: Similar to #139895, add sizes and strides methods to RAIIAtenTensorHandle and ConstantHandle, to increase the code readability. Pull Request resolved: #140449 Approved by: https://github.com/chenyang78 ghstack dependencies: #140447, #140448
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Summary: To increase the readbility of the generated code. This is not BC-breaking, because RAIIAtenTensorHandle is implemented as header-only. Differential Revision: [D65547216](https://our.internmc.facebook.com/intern/diff/D65547216) Pull Request resolved: pytorch#139895 Approved by: https://github.com/chenyang78
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…0448) Summary: pytorch#139895 added data_ptr(), but there is a remaining place in cpp_wrapper_gpu.py didn't switch over. Also moved a few AtenTensorHandle related utility functions from arrayref_tensor.h to utils.h. Pull Request resolved: pytorch#140448 Approved by: https://github.com/chenyang78 ghstack dependencies: pytorch#140447
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Summary: Similar to pytorch#139895, add sizes and strides methods to RAIIAtenTensorHandle and ConstantHandle, to increase the code readability. Pull Request resolved: pytorch#140449 Approved by: https://github.com/chenyang78 ghstack dependencies: pytorch#140447, pytorch#140448
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: To increase the readbility of the generated code. This is not BC-breaking, because RAIIAtenTensorHandle is implemented as header-only.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @chauhang @aakhundov
Differential Revision: D65547216