Skip to content

[4/N] Fix clang-tidy warnings in torch/csrc/api/ #138382

Closed
cyyever wants to merge 1 commit intopytorch:mainfrom
cyyever:any_value_tidy
Closed

[4/N] Fix clang-tidy warnings in torch/csrc/api/ #138382
cyyever wants to merge 1 commit intopytorch:mainfrom
cyyever:any_value_tidy

Conversation

@cyyever
Copy link
Collaborator

@cyyever cyyever commented Oct 19, 2024 •
edited
Loading

Follows #138328

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 19, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138382

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures

As of commit e9aa013 with merge base 2f91d7c (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: cpp release notes category label Oct 19, 2024
@cyyever cyyever marked this pull request as draft October 19, 2024 02:03
@cyyever cyyever changed the title Cleanup header inclusions and warnings in any_value.h [4/N] Fix clang-tidy warnings in torch/csrc/api/ Oct 19, 2024
@cyyever cyyever requested a review from Skylion007 October 19, 2024 08:27
@cyyever cyyever assigned ezyang and cyyever and unassigned ezyang Oct 19, 2024
@cyyever cyyever requested review from ezyang and removed request for Skylion007 October 19, 2024 08:27
@cyyever cyyever marked this pull request as ready for review October 19, 2024 08:27
@cyyever cyyever removed their assignment Oct 19, 2024
@cyyever
Copy link
Collaborator Author

cyyever commented Oct 19, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 19, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 19, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 19, 2024

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-libtorch-pre-cxx11 / libtorch-cpu-shared-with-deps-pre-cxx11-build / build

Details for Dev Infra team Raised by workflow job

@cyyever
Copy link
Collaborator Author

cyyever commented Oct 19, 2024

@pytorchmergebot merge -f "Unrelated failures"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 19, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever mentioned this pull request Oct 20, 2024
Closed
pytorchmergebot pushed a commit that referenced this pull request Oct 21, 2024
@cyyever @pytorchmergebot
[5/N] Fix clang-tidy warnings in torch/csrc/api/ (#138389)
e7b8a9a 
Follows #138382

Pull Request resolved: #138389
Approved by: https://github.com/ezyang
@cyyever cyyever deleted the any_value_tidy branch October 23, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: cpp release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cyyever @pytorchmergebot @ezyang @pytorchbot