Skip to content

[3/N] Fix clang-tidy warnings in torch/csrc/api/ #138328

Closed
cyyever wants to merge 5 commits intopytorch:mainfrom
cyyever:tidy_api5
Closed

[3/N] Fix clang-tidy warnings in torch/csrc/api/ #138328
cyyever wants to merge 5 commits intopytorch:mainfrom
cyyever:tidy_api5

Conversation

@cyyever
Copy link
Collaborator

@cyyever cyyever commented Oct 18, 2024 •
edited
Loading

Follows #136998

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 18, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138328

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures

As of commit e71f9e6 with merge base 8cfe28e (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: cpp release notes category label Oct 18, 2024
@cyyever cyyever changed the title Fix clang-tidy warnings [3/N] Fix clang-tidy warnings in torch/csrc/api/ Oct 18, 2024
@cyyever cyyever requested a review from ezyang October 18, 2024 13:50
@cyyever cyyever marked this pull request as draft October 18, 2024 14:09
@cyyever cyyever force-pushed the tidy_api5 branch 2 times, most recently from 33a2f3a to 4fa6e7c Compare October 18, 2024 14:16
@cyyever cyyever marked this pull request as ready for review October 18, 2024 17:28
@janeyx99 janeyx99 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 18, 2024
@cyyever
Copy link
Collaborator Author

cyyever commented Oct 19, 2024

@pytorchbot merge -i

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 19, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 19, 2024

Merge started

Your change will be merged while ignoring the following 0 checks:

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 19, 2024

Merge failed

Reason: 2 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_9-cuda12_4-build / build, trunk / macos-py3-arm64 / build

Details for Dev Infra team Raised by workflow job

@cyyever
Copy link
Collaborator Author

cyyever commented Oct 19, 2024

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 19, 2024

Merge started

Your change will be merged while ignoring the following 0 checks:

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 19, 2024

Merge failed

Reason: 4 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_9-cuda11_8-build / build, linux-binary-manywheel / manywheel-py3_9-cuda12_4-build / build, linux-binary-manywheel / manywheel-py3_9-cuda12_1-build / build, linux-binary-libtorch-pre-cxx11 / libtorch-cpu-shared-with-deps-pre-cxx11-build / build

Details for Dev Infra team Raised by workflow job

@cyyever
Copy link
Collaborator Author

cyyever commented Oct 19, 2024

@pytorchmergebot merge -f "Unrelated failures"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 19, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever deleted the tidy_api5 branch October 19, 2024 07:07
@cyyever cyyever restored the tidy_api5 branch October 19, 2024 07:08
@cyyever cyyever mentioned this pull request Oct 19, 2024
Closed
pytorchmergebot pushed a commit that referenced this pull request Oct 19, 2024
@cyyever @pytorchmergebot
[4/N] Fix clang-tidy warnings in torch/csrc/api/ (#138382)
cdc9f14 
Follows #138328

Pull Request resolved: #138382
Approved by: https://github.com/ezyang
@cyyever cyyever deleted the tidy_api5 branch October 22, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: cpp release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cyyever @pytorchmergebot @ezyang @pytorchbot @janeyx99